[GitHub] [arrow-ballista] andygrove commented on a diff in pull request #475: Add support for Tableau

[GitBox <gi...@apache.org>]

andygrove commented on code in PR #475:
URL: https://github.com/apache/arrow-ballista/pull/475#discussion_r1008433059


##########
ballista/scheduler/src/flight_sql.rs:
##########
@@ -257,6 +333,11 @@ impl FlightSqlServiceImpl {
 
     fn df_schema_to_arrow(&self, schema: &DFSchemaRef) -> Result<Vec<u8>, Status> {
         let arrow_schema: Schema = (&**schema).into();
+        let schema_bytes = self.schema_to_arrow(Arc::new(arrow_schema))?;
+        Ok(schema_bytes)

Review Comment:
   looks like it can be simplified to:
   
   ```suggestion
           self.schema_to_arrow(Arc::new(arrow_schema))
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org