You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/01/15 07:46:59 UTC
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #996: Ftr: Use nacos constant instead of hardcoded string in nacos registry
codecov-io edited a comment on pull request #996:
URL: https://github.com/apache/dubbo-go/pull/996#issuecomment-760710987
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/996?src=pr&el=h1) Report
> Merging [#996](https://codecov.io/gh/apache/dubbo-go/pull/996?src=pr&el=desc) (109d1dc) into [master](https://codecov.io/gh/apache/dubbo-go/commit/a3bc853dd650ae2d7f954eeaa3d8984cd07e6cbc?el=desc) (a3bc853) will **decrease** coverage by `0.02%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/996?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #996 +/- ##
==========================================
- Coverage 59.71% 59.68% -0.03%
==========================================
Files 261 261
Lines 12907 12907
==========================================
- Hits 7707 7704 -3
- Misses 4232 4234 +2
- Partials 968 969 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/996?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/nacos/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/996/diff?src=pr&el=tree#diff-cmVnaXN0cnkvbmFjb3MvcmVnaXN0cnkuZ28=) | `50.36% <100.00%> (ø)` | |
| [remoting/kubernetes/registry\_controller.go](https://codecov.io/gh/apache/dubbo-go/pull/996/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9yZWdpc3RyeV9jb250cm9sbGVyLmdv) | `46.12% <0.00%> (-5.31%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/996/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `76.92% <0.00%> (-2.20%)` | :arrow_down: |
| [metadata/report/delegate/delegate\_report.go](https://codecov.io/gh/apache/dubbo-go/pull/996/diff?src=pr&el=tree#diff-bWV0YWRhdGEvcmVwb3J0L2RlbGVnYXRlL2RlbGVnYXRlX3JlcG9ydC5nbw==) | `37.60% <0.00%> (+9.60%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/996?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/996?src=pr&el=footer). Last update [a3bc853...109d1dc](https://codecov.io/gh/apache/dubbo-go/pull/996?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org