You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2019/08/13 12:51:36 UTC

[GitHub] [couchdb] iilyak commented on a change in pull request #2107: Configurable FDB directory prefixes for CouchDB instances

iilyak commented on a change in pull request #2107: Configurable FDB directory prefixes for CouchDB instances
URL: https://github.com/apache/couchdb/pull/2107#discussion_r313377796
 
 

 ##########
 File path: src/fabric/src/fabric2_server.erl
 ##########
 @@ -81,6 +84,14 @@ init(_) ->
     end,
     application:set_env(fabric, db, Db),
 
+    Dir = case config:get("fabric", "fdb_directory") of
+        undefined ->
+            [?DEFAULT_FDB_DIRECTORY];
+        Val when is_list(Val), length(Val) > 0 ->
 
 Review comment:
   It is a good practice to avoid using `length` (because `length` has O(n) complexity). Especially in cases where `Val <> []` would do.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services