You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by mi...@apache.org on 2022/07/24 11:52:17 UTC
[lucene-jira-archive] branch more_shoshin_polish created (now 70741a4d)
This is an automated email from the ASF dual-hosted git repository.
mikemccand pushed a change to branch more_shoshin_polish
in repository https://gitbox.apache.org/repos/asf/lucene-jira-archive.git
at 70741a4d just polishing a few sharp edges that hit me when running remap_cross_issue_links.py for the first few times
This branch includes the following new commits:
new 70741a4d just polishing a few sharp edges that hit me when running remap_cross_issue_links.py for the first few times
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
[lucene-jira-archive] 01/01: just polishing a few sharp edges that hit me when running remap_cross_issue_links.py for the first few times
Posted by mi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
mikemccand pushed a commit to branch more_shoshin_polish
in repository https://gitbox.apache.org/repos/asf/lucene-jira-archive.git
commit 70741a4d74b5306f8675d198d7845683e64d429d
Author: Mike McCandless <mi...@apache.org>
AuthorDate: Sun Jul 24 07:51:54 2022 -0400
just polishing a few sharp edges that hit me when running remap_cross_issue_links.py for the first few times
---
migration/README.md | 2 +-
migration/src/remap_cross_issue_links.py | 8 ++++----
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/migration/README.md b/migration/README.md
index 2fe3fae0..75bb8839 100644
--- a/migration/README.md
+++ b/migration/README.md
@@ -105,7 +105,7 @@ LUCENE-10502,https://github.com/mocobeta/migration-test-3/issues/44,44
### 5. Re-map cross-issue links on GitHub
-`src/remap_cross_issue_links.py` exports issues and comments from GitHub and save updated issue/comment bodies to `migration/github-remapped-data`.
+`src/remap_cross_issue_links.py` exports issues and comments from GitHub and saves updated issue/comment bodies to `migration/github-remapped-data`. Note that a given body and comment will only be saved into `migration/github-remapped-data` if it contained (now updated) issue cross-links.
```
(.venv) migration $ python src/remap_cross_issue_links.py --issues 40 41
diff --git a/migration/src/remap_cross_issue_links.py b/migration/src/remap_cross_issue_links.py
index 11d3bc5f..5c805a19 100644
--- a/migration/src/remap_cross_issue_links.py
+++ b/migration/src/remap_cross_issue_links.py
@@ -68,11 +68,11 @@ if __name__ == "__main__":
check_authentication(github_token)
parser = argparse.ArgumentParser()
- parser.add_argument('--issues', type=int, required=False, nargs='*', help='GitHub issue number list to be downloaded')
- args = parser.parse_args()
-
mapping_data_dir = Path(__file__).resolve().parent.parent.joinpath(MAPPINGS_DATA_DIRNAME)
issue_mapping_file = mapping_data_dir.joinpath(ISSUE_MAPPING_FILENAME)
+ parser.add_argument('--issues', type=int, required=False, nargs='*', help=f'GitHub issue number list to be downloaded, else all GitHub issues in {issue_mapping_file.relative_to(Path.cwd())}')
+ args = parser.parse_args()
+
if not issue_mapping_file.exists():
logger.error(f"Jira-GitHub issue id mapping file not found. {issue_mapping_file}")
sys.exit(1)
@@ -102,4 +102,4 @@ if __name__ == "__main__":
logger.error(f"Failed to export/convert issue comments. Skipped issue {num}")
continue
- logger.info("Done.")
\ No newline at end of file
+ logger.info("Done.")