You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "ashishkumar50 (via GitHub)" <gi...@apache.org> on 2024/08/05 11:35:36 UTC
[PR] HDDS-11280. Add Synchronize in AbstractCommitWatcher.addAckDataLength [ozone]
ashishkumar50 opened a new pull request, #7032:
URL: https://github.com/apache/ozone/pull/7032
## What changes were proposed in this pull request?
TestBlockOutputStream.testWriteMoreThanFlushSize is flaky after HDDS-9844 fix.
It is due to addAckDataLength is not kept as thread safe which is causing wrong totalAckDataLength.
In this PR we are adding synchronized in AbstractCommitWatcher.addAckDataLength to make thread safe.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-11280
## How was this patch tested?
Verified in 10X10 run and it is green after the fix
https://github.com/ashishkumar50/ozone/actions/runs/10244918136/workflow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11280. Add Synchronize in AbstractCommitWatcher.addAckDataLength [ozone]
Posted by "jojochuang (via GitHub)" <gi...@apache.org>.
jojochuang merged PR #7032:
URL: https://github.com/apache/ozone/pull/7032
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11280. Add Synchronize in AbstractCommitWatcher.addAckDataLength [ozone]
Posted by "ashishkumar50 (via GitHub)" <gi...@apache.org>.
ashishkumar50 commented on PR #7032:
URL: https://github.com/apache/ozone/pull/7032#issuecomment-2269525643
@szetszwo Thanks for the review.
Updated with AtomicLong.
It looks like there is still flakiness and it failed in second 10X10 run while the first 10X10 run was all success.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org