You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Deepak Jaiswal <dj...@hortonworks.com> on 2017/08/09 23:15:36 UTC
Review Request 61543: HIVE-17283
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61543/
-----------------------------------------------------------
Review request for hive, Gopal V and Jason Dere.
Bugs: HIVE-17283
https://issues.apache.org/jira/browse/HIVE-17283
Repository: hive-git
Description
-------
Enable parallel edges of semijoin along with mapjoins
Diffs
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 7cee344295
ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java 5614c26819
ql/src/test/queries/clientpositive/dynamic_semijoin_reduction.q d631401760
ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction.q.out 2eedb6efb3
Diff: https://reviews.apache.org/r/61543/diff/1/
Testing
-------
Unit test added.
Pending ptests.
Thanks,
Deepak Jaiswal
Re: Review Request 61543: HIVE-17283
Posted by Gopal V <go...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61543/#review182555
-----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
Lines 2931 (patched)
<https://reviews.apache.org/r/61543/#comment258459>
Replace doc note with "Use a semi-join branch for map-joins. This may not make it faster, but is helpful in certain join patterns."
ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java
Lines 1064 (patched)
<https://reviews.apache.org/r/61543/#comment258460>
minor nit - semijoins twice
- Gopal V
On Aug. 9, 2017, 11:15 p.m., Deepak Jaiswal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61543/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2017, 11:15 p.m.)
>
>
> Review request for hive, Gopal V and Jason Dere.
>
>
> Bugs: HIVE-17283
> https://issues.apache.org/jira/browse/HIVE-17283
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Enable parallel edges of semijoin along with mapjoins
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 7cee344295
> ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java 5614c26819
> ql/src/test/queries/clientpositive/dynamic_semijoin_reduction.q d631401760
> ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction.q.out 2eedb6efb3
>
>
> Diff: https://reviews.apache.org/r/61543/diff/1/
>
>
> Testing
> -------
>
> Unit test added.
> Pending ptests.
>
>
> Thanks,
>
> Deepak Jaiswal
>
>
Re: Review Request 61543: HIVE-17283
Posted by Gopal V <go...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61543/#review182560
-----------------------------------------------------------
Ship it!
Ship It!
- Gopal V
On Aug. 10, 2017, 6:54 a.m., Deepak Jaiswal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61543/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2017, 6:54 a.m.)
>
>
> Review request for hive, Gopal V and Jason Dere.
>
>
> Bugs: HIVE-17283
> https://issues.apache.org/jira/browse/HIVE-17283
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Enable parallel edges of semijoin along with mapjoins
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 7cee344295
> ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java 5614c26819
> ql/src/test/queries/clientpositive/dynamic_semijoin_reduction.q d631401760
> ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction.q.out 2eedb6efb3
>
>
> Diff: https://reviews.apache.org/r/61543/diff/2/
>
>
> Testing
> -------
>
> Unit test added.
> Pending ptests.
>
>
> Thanks,
>
> Deepak Jaiswal
>
>
Re: Review Request 61543: HIVE-17283
Posted by Deepak Jaiswal <dj...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61543/
-----------------------------------------------------------
(Updated Aug. 10, 2017, 6:54 a.m.)
Review request for hive, Gopal V and Jason Dere.
Changes
-------
Implemented review comments
Bugs: HIVE-17283
https://issues.apache.org/jira/browse/HIVE-17283
Repository: hive-git
Description
-------
Enable parallel edges of semijoin along with mapjoins
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 7cee344295
ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java 5614c26819
ql/src/test/queries/clientpositive/dynamic_semijoin_reduction.q d631401760
ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction.q.out 2eedb6efb3
Diff: https://reviews.apache.org/r/61543/diff/2/
Changes: https://reviews.apache.org/r/61543/diff/1-2/
Testing
-------
Unit test added.
Pending ptests.
Thanks,
Deepak Jaiswal