You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by ad...@apache.org on 2013/09/25 22:46:41 UTC

svn commit: r1526296 - in /ofbiz/trunk/framework/common/data: CommonTypeData.xml GeoData.xml

Author: adrianc
Date: Wed Sep 25 20:46:40 2013
New Revision: 1526296

URL: http://svn.apache.org/r1526296
Log:
Move geo-related seed data to the GeoData.xml file. No functional change.

Modified:
    ofbiz/trunk/framework/common/data/CommonTypeData.xml
    ofbiz/trunk/framework/common/data/GeoData.xml

Modified: ofbiz/trunk/framework/common/data/CommonTypeData.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/data/CommonTypeData.xml?rev=1526296&r1=1526295&r2=1526296&view=diff
==============================================================================
--- ofbiz/trunk/framework/common/data/CommonTypeData.xml (original)
+++ ofbiz/trunk/framework/common/data/CommonTypeData.xml Wed Sep 25 20:46:40 2013
@@ -64,26 +64,6 @@ under the License.
     <Enumeration description="Lang: Spanish" enumCode="LANG_SP" enumId="KWTR_LANG_SP" sequenceId="21" enumTypeId="KW_THES_REL"/>
     <Enumeration description="Lang: French" enumCode="LANG_FR" enumId="KWTR_LANG_FR" sequenceId="22" enumTypeId="KW_THES_REL"/>
 
-    <GeoType description="City" geoTypeId="CITY" hasTable="N" parentTypeId=""/>
-    <GeoType description="Group" geoTypeId="GROUP" hasTable="N" parentTypeId=""/>
-    <GeoType description="State" geoTypeId="STATE" hasTable="N" parentTypeId=""/>
-    <GeoType description="Postal Code" geoTypeId="POSTAL_CODE" hasTable="N" parentTypeId=""/>
-    <GeoType description="Country" geoTypeId="COUNTRY" hasTable="N" parentTypeId=""/>
-    <GeoType description="County" geoTypeId="COUNTY" hasTable="N" parentTypeId=""/>
-    <GeoType description="County-City" geoTypeId="COUNTY_CITY" hasTable="N" parentTypeId=""/>
-    <GeoType description="Municipality" geoTypeId="MUNICIPALITY" hasTable="N" parentTypeId=""/>
-    <GeoType description="Province" geoTypeId="PROVINCE" hasTable="N" parentTypeId=""/>
-    <GeoType description="Region" geoTypeId="REGION" hasTable="N" parentTypeId=""/>
-    <GeoType description="Territory" geoTypeId="TERRITORY" hasTable="N" parentTypeId=""/>
-    <GeoType description="Sales Territory" geoTypeId="SALES_TERRITORY" hasTable="N" parentTypeId="TERRITORY"/>
-    <GeoType description="Service Territory" geoTypeId="SERVICE_TERRITORY" hasTable="N" parentTypeId="TERRITORY"/>
-
-    <GeoAssocType geoAssocTypeId="GROUP_MEMBER" description="Geo Group Member"/>
-    <GeoAssocType geoAssocTypeId="REGIONS" description="For a region of a larger Geo, i.e. states, counties, provinces..."/>
-    <GeoAssocType geoAssocTypeId="COUNTY_CITY" description="City in a county"/>
-    <GeoAssocType geoAssocTypeId="COUNTY_SEAT" description="Administrative Main City of a County"/>
-    <GeoAssocType geoAssocTypeId="POSTAL_CODE" description="Postal code associated to a GeoType"/>
-
     <!-- sync status -->
     <StatusType description="Synchronize" hasTable="N" parentTypeId="" statusTypeId="SYNCHRONIZE_STATUS"/>
     <StatusItem description="Not-Synchronized" sequenceId="01" statusCode="NOT_SYNCHRONIZED" statusId="NOT_SYNCHRONIZED" statusTypeId="SYNCHRONIZE_STATUS"/>

Modified: ofbiz/trunk/framework/common/data/GeoData.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/data/GeoData.xml?rev=1526296&r1=1526295&r2=1526296&view=diff
==============================================================================
--- ofbiz/trunk/framework/common/data/GeoData.xml (original)
+++ ofbiz/trunk/framework/common/data/GeoData.xml Wed Sep 25 20:46:40 2013
@@ -19,6 +19,27 @@ under the License.
 -->
 
 <entity-engine-xml>
+
+    <GeoType description="City" geoTypeId="CITY" hasTable="N" parentTypeId=""/>
+    <GeoType description="Group" geoTypeId="GROUP" hasTable="N" parentTypeId=""/>
+    <GeoType description="State" geoTypeId="STATE" hasTable="N" parentTypeId=""/>
+    <GeoType description="Postal Code" geoTypeId="POSTAL_CODE" hasTable="N" parentTypeId=""/>
+    <GeoType description="Country" geoTypeId="COUNTRY" hasTable="N" parentTypeId=""/>
+    <GeoType description="County" geoTypeId="COUNTY" hasTable="N" parentTypeId=""/>
+    <GeoType description="County-City" geoTypeId="COUNTY_CITY" hasTable="N" parentTypeId=""/>
+    <GeoType description="Municipality" geoTypeId="MUNICIPALITY" hasTable="N" parentTypeId=""/>
+    <GeoType description="Province" geoTypeId="PROVINCE" hasTable="N" parentTypeId=""/>
+    <GeoType description="Region" geoTypeId="REGION" hasTable="N" parentTypeId=""/>
+    <GeoType description="Territory" geoTypeId="TERRITORY" hasTable="N" parentTypeId=""/>
+    <GeoType description="Sales Territory" geoTypeId="SALES_TERRITORY" hasTable="N" parentTypeId="TERRITORY"/>
+    <GeoType description="Service Territory" geoTypeId="SERVICE_TERRITORY" hasTable="N" parentTypeId="TERRITORY"/>
+
+    <GeoAssocType geoAssocTypeId="GROUP_MEMBER" description="Geo Group Member"/>
+    <GeoAssocType geoAssocTypeId="REGIONS" description="For a region of a larger Geo, i.e. states, counties, provinces..."/>
+    <GeoAssocType geoAssocTypeId="COUNTY_CITY" description="City in a county"/>
+    <GeoAssocType geoAssocTypeId="COUNTY_SEAT" description="Administrative Main City of a County"/>
+    <GeoAssocType geoAssocTypeId="POSTAL_CODE" description="Postal code associated to a GeoType"/>
+
     <!--
         Based on: ISO 3166  https://www.iso.org/obp/ui/#search 
                   and http://www.iso.org/iso/home/standards/country_codes/country_names_and_code_elements.htm. 



Re: svn commit: r1526296 - in /ofbiz/trunk/framework/common/data: CommonTypeData.xml GeoData.xml

Posted by Pierre Smits <pi...@gmail.com>.
When doing a search for CountryCode vs GEO in *forms.xml I got following
results
CountryCode: 47 hits, only 7 related to the entity
Geo: 432 hits, only 73 related to the entity

Similarly, in *ftl:
CountryCode: 67
Geo: 927 hits

So it is safe to say that the impact of harmonisation is in favour of using
Geo over CountryCode.

If it is communicated that such a change would be implemented in (one of)
the upcoming release(s) then implementers and developers of custom
solutions can plan and prep for the change. That is why releases are staged
and planned.

Pierre Smits

*ORRTIZ.COM <http://www.orrtiz.com>*
Services & Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail & Trade
http://www.orrtiz.com

Re: Geo Location Discussion

Posted by Jacques Le Roux <ja...@les7arts.com>.
Then please open a Jira and we will continue there

Thanks

Jacques


Adrian Crum wrote:
> The idea is to pick out the model features that are useful to fix the
> current model - like replacing the CountryCapital entity with
> GeoLocCharacteristic. The GeoLocCharacteristic entity could contain
> Country Capital, State Capital, County Seat, etc.
> 
> Adrian Crum
> Sandglass Software
> www.sandglass-software.com
> 
> On 9/28/2013 1:07 AM, Jacques Le Roux wrote:
>> Thanks for Sharing Adrian. Indeed this would be a lot of changes.
>> 
>>>>> Years later there is so
>>>>> much code written around those things, that we don't want to change
>>>>> them. So, that is why I choose to replace them locally.
>> 
>> I agree!
>> 
>> Jacques
>> 
>> Adrian Crum wrote:
>>> http://www.sandglass-software.com/products/sandglass/documents/v1/LocationModels.pdf
>>> 
>>> Adrian Crum
>>> Sandglass Software
>>> www.sandglass-software.com
>>> 
>>> On 9/26/2013 12:50 PM, Jacques Le Roux wrote:
>>>> Adrian Crum wrote:
>>>>> I will prepare a PDF of the model I am using and share it.
>>>>> 
>>>>> David makes a good point in that discussion: "this is why I'm a little
>>>>> picky about who makes data model changes... they aren't too complex but
>>>>> for anyone that hasn't done them a fair amount it is easy to miss
>>>>> things, and once the entities are used becomes difficult to fix."
>>>>> 
>>>>> There are a lot of things like that in OFBiz - despite our best
>>>>> intentions, some things didn't come out right. Years later there is so
>>>>> much code written around those things, that we don't want to change
>>>>> them. So, that is why I choose to replace them locally.
>>>> 
>>>> Yes I know. We discussed this part lengthly, there were a lot of good ideas and finally a consensus.
>>>> But we can always improve and use the data migration page. We should not stay fossilised, despites some opininons, like Skip
>>>> recently.
>>>> 
>>>> Jacques
>>>> 
>>>>> Adrian Crum
>>>>> Sandglass Software
>>>>> www.sandglass-software.com
>>>>> 
>>>>> On 9/26/2013 7:01 AM, Jacques Le Roux wrote:
>>>>>> I think it mostly started from there https://issues.apache.org/jira/browse/OFBIZ-1923
>>>>>> and related thread/s in dev ML (look for geopoint)
>>>>>> 
>>>>>> I'm open to discussion...
>>>>>> 
>>>>>> Jacques
>>>>>> 
>>>>>> 
>>>>>> Adrian Crum wrote:
>>>>>>> I agree there is a lot of overlap in the data and in the geo data model.
>>>>>>> 
>>>>>>> The Geo data model is a denormalized, disorganized mess. That was the
>>>>>>> reason for my changes - so I can comment all of it out and replace it
>>>>>>> with a better model on my local copy.
>>>>>>> 
>>>>>>> Yes, it needs to be fixed - but there seems to be a problem finding
>>>>>>> agreement on what the model should look like.
>>>>>>> 
>>>>>>> Conceptually, geo data is location data - just like contact mechanisms.
>>>>>>>    From my perspective, the geo artifacts should be in the same component
>>>>>>> as the contact mechanism artifacts. It doesn't belong in the framework.
>>>>>>> 
>>>>>>> Adrian Crum
>>>>>>> Sandglass Software
>>>>>>> www.sandglass-software.com
>>>>>>> 
>>>>>>> On 9/26/2013 12:33 AM, Pierre Smits wrote:
>>>>>>>> It seems that there is a significant overlap between the data in
>>>>>>>> CountryCodeData.xml and GeoData.xml.
>>>>>>>> 
>>>>>>>> Would it not - in the spirit of slimdown - wise to merge the two sets (and
>>>>>>>> possible others related to Country and GEO data)?
>>>>>>>> 
>>>>>>>> Regards,
>>>>>>>> 
>>>>>>>> Pierre Smits
>>>>>>>> 
>>>>>>>> *ORRTIZ.COM <http://www.orrtiz.com>*
>>>>>>>> Services & Solutions for Cloud-
>>>>>>>> Based Manufacturing, Professional
>>>>>>>> Services and Retail & Trade
>>>>>>>> http://www.orrtiz.com
>>>>>>>> 
>>>>>>>> 
>>>>>>>> On Wed, Sep 25, 2013 at 10:46 PM, <ad...@apache.org> wrote:
>>>>>>>> 
>>>>>>>>> Author: adrianc
>>>>>>>>> Date: Wed Sep 25 20:46:40 2013
>>>>>>>>> New Revision: 1526296
>>>>>>>>> 
>>>>>>>>> URL: http://svn.apache.org/r1526296
>>>>>>>>> Log:
>>>>>>>>> Move geo-related seed data to the GeoData.xml file. No functional change.
>>>>>>>>> 
>>>>>>>>> Modified:
>>>>>>>>>         ofbiz/trunk/framework/common/data/CommonTypeData.xml
>>>>>>>>>         ofbiz/trunk/framework/common/data/GeoData.xml
>>>>>>>>> 
>>>>>>>>> Modified: ofbiz/trunk/framework/common/data/CommonTypeData.xml
>>>>>>>>> URL:
>>>>>>>>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/data/CommonTypeData.xml?rev=1526296&r1=1526295&r2=1526296&view=diff
>>>>>>>>> 
>>>>>>>>> ==============================================================================
>>>>>>>>> --- ofbiz/trunk/framework/common/data/CommonTypeData.xml (original)
>>>>>>>>> +++ ofbiz/trunk/framework/common/data/CommonTypeData.xml Wed Sep 25
>>>>>>>>> 20:46:40 2013
>>>>>>>>> @@ -64,26 +64,6 @@ under the License.
>>>>>>>>>          <Enumeration description="Lang: Spanish" enumCode="LANG_SP"
>>>>>>>>> enumId="KWTR_LANG_SP" sequenceId="21" enumTypeId="KW_THES_REL"/>
>>>>>>>>>          <Enumeration description="Lang: French" enumCode="LANG_FR"
>>>>>>>>> enumId="KWTR_LANG_FR" sequenceId="22" enumTypeId="KW_THES_REL"/>
>>>>>>>>> 
>>>>>>>>> -    <GeoType description="City" geoTypeId="CITY" hasTable="N"
>>>>>>>>> parentTypeId=""/>
>>>>>>>>> -    <GeoType description="Group" geoTypeId="GROUP" hasTable="N"
>>>>>>>>> parentTypeId=""/>
>>>>>>>>> -    <GeoType description="State" geoTypeId="STATE" hasTable="N"
>>>>>>>>> parentTypeId=""/>
>>>>>>>>> -    <GeoType description="Postal Code" geoTypeId="POSTAL_CODE"
>>>>>>>>> hasTable="N" parentTypeId=""/>
>>>>>>>>> -    <GeoType description="Country" geoTypeId="COUNTRY" hasTable="N"
>>>>>>>>> parentTypeId=""/>
>>>>>>>>> -    <GeoType description="County" geoTypeId="COUNTY" hasTable="N"
>>>>>>>>> parentTypeId=""/>
>>>>>>>>> -    <GeoType description="County-City" geoTypeId="COUNTY_CITY"
>>>>>>>>> hasTable="N" parentTypeId=""/>
>>>>>>>>> -    <GeoType description="Municipality" geoTypeId="MUNICIPALITY"
>>>>>>>>> hasTable="N" parentTypeId=""/>
>>>>>>>>> -    <GeoType description="Province" geoTypeId="PROVINCE" hasTable="N"
>>>>>>>>> parentTypeId=""/>
>>>>>>>>> -    <GeoType description="Region" geoTypeId="REGION" hasTable="N"
>>>>>>>>> parentTypeId=""/>
>>>>>>>>> -    <GeoType description="Territory" geoTypeId="TERRITORY" hasTable="N"
>>>>>>>>> parentTypeId=""/>
>>>>>>>>> -    <GeoType description="Sales Territory" geoTypeId="SALES_TERRITORY"
>>>>>>>>> hasTable="N" parentTypeId="TERRITORY"/>
>>>>>>>>> -    <GeoType description="Service Territory"
>>>>>>>>> geoTypeId="SERVICE_TERRITORY" hasTable="N" parentTypeId="TERRITORY"/>
>>>>>>>>> -
>>>>>>>>> -    <GeoAssocType geoAssocTypeId="GROUP_MEMBER" description="Geo Group
>>>>>>>>> Member"/>
>>>>>>>>> -    <GeoAssocType geoAssocTypeId="REGIONS" description="For a region of a
>>>>>>>>> larger Geo, i.e. states, counties, provinces..."/>
>>>>>>>>> -    <GeoAssocType geoAssocTypeId="COUNTY_CITY" description="City in a
>>>>>>>>> county"/>
>>>>>>>>> -    <GeoAssocType geoAssocTypeId="COUNTY_SEAT"
>>>>>>>>> description="Administrative Main City of a County"/>
>>>>>>>>> -    <GeoAssocType geoAssocTypeId="POSTAL_CODE" description="Postal code
>>>>>>>>> associated to a GeoType"/>
>>>>>>>>> -
>>>>>>>>>          <!-- sync status -->
>>>>>>>>>          <StatusType description="Synchronize" hasTable="N" parentTypeId=""
>>>>>>>>> statusTypeId="SYNCHRONIZE_STATUS"/>
>>>>>>>>>          <StatusItem description="Not-Synchronized" sequenceId="01"
>>>>>>>>> statusCode="NOT_SYNCHRONIZED" statusId="NOT_SYNCHRONIZED"
>>>>>>>>> statusTypeId="SYNCHRONIZE_STATUS"/>
>>>>>>>>> 
>>>>>>>>> Modified: ofbiz/trunk/framework/common/data/GeoData.xml
>>>>>>>>> URL:
>>>>>>>>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/data/GeoData.xml?rev=1526296&r1=1526295&r2=1526296&view=diff
>>>>>>>>> 
>>>>>>>>> ==============================================================================
>>>>>>>>> --- ofbiz/trunk/framework/common/data/GeoData.xml (original)
>>>>>>>>> +++ ofbiz/trunk/framework/common/data/GeoData.xml Wed Sep 25 20:46:40 2013
>>>>>>>>> @@ -19,6 +19,27 @@ under the License.
>>>>>>>>>      -->
>>>>>>>>> 
>>>>>>>>>      <entity-engine-xml>
>>>>>>>>> +
>>>>>>>>> +    <GeoType description="City" geoTypeId="CITY" hasTable="N"
>>>>>>>>> parentTypeId=""/>
>>>>>>>>> +    <GeoType description="Group" geoTypeId="GROUP" hasTable="N"
>>>>>>>>> parentTypeId=""/>
>>>>>>>>> +    <GeoType description="State" geoTypeId="STATE" hasTable="N"
>>>>>>>>> parentTypeId=""/>
>>>>>>>>> +    <GeoType description="Postal Code" geoTypeId="POSTAL_CODE"
>>>>>>>>> hasTable="N" parentTypeId=""/>
>>>>>>>>> +    <GeoType description="Country" geoTypeId="COUNTRY" hasTable="N"
>>>>>>>>> parentTypeId=""/>
>>>>>>>>> +    <GeoType description="County" geoTypeId="COUNTY" hasTable="N"
>>>>>>>>> parentTypeId=""/>
>>>>>>>>> +    <GeoType description="County-City" geoTypeId="COUNTY_CITY"
>>>>>>>>> hasTable="N" parentTypeId=""/>
>>>>>>>>> +    <GeoType description="Municipality" geoTypeId="MUNICIPALITY"
>>>>>>>>> hasTable="N" parentTypeId=""/>
>>>>>>>>> +    <GeoType description="Province" geoTypeId="PROVINCE" hasTable="N"
>>>>>>>>> parentTypeId=""/>
>>>>>>>>> +    <GeoType description="Region" geoTypeId="REGION" hasTable="N"
>>>>>>>>> parentTypeId=""/>
>>>>>>>>> +    <GeoType description="Territory" geoTypeId="TERRITORY" hasTable="N"
>>>>>>>>> parentTypeId=""/>
>>>>>>>>> +    <GeoType description="Sales Territory" geoTypeId="SALES_TERRITORY"
>>>>>>>>> hasTable="N" parentTypeId="TERRITORY"/>
>>>>>>>>> +    <GeoType description="Service Territory"
>>>>>>>>> geoTypeId="SERVICE_TERRITORY" hasTable="N" parentTypeId="TERRITORY"/>
>>>>>>>>> +
>>>>>>>>> +    <GeoAssocType geoAssocTypeId="GROUP_MEMBER" description="Geo Group
>>>>>>>>> Member"/>
>>>>>>>>> +    <GeoAssocType geoAssocTypeId="REGIONS" description="For a region of a
>>>>>>>>> larger Geo, i.e. states, counties, provinces..."/>
>>>>>>>>> +    <GeoAssocType geoAssocTypeId="COUNTY_CITY" description="City in a
>>>>>>>>> county"/>
>>>>>>>>> +    <GeoAssocType geoAssocTypeId="COUNTY_SEAT"
>>>>>>>>> description="Administrative Main City of a County"/>
>>>>>>>>> +    <GeoAssocType geoAssocTypeId="POSTAL_CODE" description="Postal code
>>>>>>>>> associated to a GeoType"/>
>>>>>>>>> +
>>>>>>>>>          <!--
>>>>>>>>>              Based on: ISO 3166  https://www.iso.org/obp/ui/#search
>>>>>>>>>                        and
>>>>>>>>> http://www.iso.org/iso/home/standards/country_codes/country_names_and_code_elements.htm
>>>>>>>>> .

Re: Geo Location Discussion

Posted by Adrian Crum <ad...@sandglass-software.com>.
The idea is to pick out the model features that are useful to fix the 
current model - like replacing the CountryCapital entity with 
GeoLocCharacteristic. The GeoLocCharacteristic entity could contain 
Country Capital, State Capital, County Seat, etc.

Adrian Crum
Sandglass Software
www.sandglass-software.com

On 9/28/2013 1:07 AM, Jacques Le Roux wrote:
> Thanks for Sharing Adrian. Indeed this would be a lot of changes.
>
>>>> Years later there is so
>>>> much code written around those things, that we don't want to change
>>>> them. So, that is why I choose to replace them locally.
>
> I agree!
>
> Jacques
>
> Adrian Crum wrote:
>> http://www.sandglass-software.com/products/sandglass/documents/v1/LocationModels.pdf
>>
>> Adrian Crum
>> Sandglass Software
>> www.sandglass-software.com
>>
>> On 9/26/2013 12:50 PM, Jacques Le Roux wrote:
>>> Adrian Crum wrote:
>>>> I will prepare a PDF of the model I am using and share it.
>>>>
>>>> David makes a good point in that discussion: "this is why I'm a little
>>>> picky about who makes data model changes... they aren't too complex but
>>>> for anyone that hasn't done them a fair amount it is easy to miss
>>>> things, and once the entities are used becomes difficult to fix."
>>>>
>>>> There are a lot of things like that in OFBiz - despite our best
>>>> intentions, some things didn't come out right. Years later there is so
>>>> much code written around those things, that we don't want to change
>>>> them. So, that is why I choose to replace them locally.
>>>
>>> Yes I know. We discussed this part lengthly, there were a lot of good ideas and finally a consensus.
>>> But we can always improve and use the data migration page. We should not stay fossilised, despites some opininons, like Skip
>>> recently.
>>>
>>> Jacques
>>>
>>>> Adrian Crum
>>>> Sandglass Software
>>>> www.sandglass-software.com
>>>>
>>>> On 9/26/2013 7:01 AM, Jacques Le Roux wrote:
>>>>> I think it mostly started from there https://issues.apache.org/jira/browse/OFBIZ-1923
>>>>> and related thread/s in dev ML (look for geopoint)
>>>>>
>>>>> I'm open to discussion...
>>>>>
>>>>> Jacques
>>>>>
>>>>>
>>>>> Adrian Crum wrote:
>>>>>> I agree there is a lot of overlap in the data and in the geo data model.
>>>>>>
>>>>>> The Geo data model is a denormalized, disorganized mess. That was the
>>>>>> reason for my changes - so I can comment all of it out and replace it
>>>>>> with a better model on my local copy.
>>>>>>
>>>>>> Yes, it needs to be fixed - but there seems to be a problem finding
>>>>>> agreement on what the model should look like.
>>>>>>
>>>>>> Conceptually, geo data is location data - just like contact mechanisms.
>>>>>>    From my perspective, the geo artifacts should be in the same component
>>>>>> as the contact mechanism artifacts. It doesn't belong in the framework.
>>>>>>
>>>>>> Adrian Crum
>>>>>> Sandglass Software
>>>>>> www.sandglass-software.com
>>>>>>
>>>>>> On 9/26/2013 12:33 AM, Pierre Smits wrote:
>>>>>>> It seems that there is a significant overlap between the data in
>>>>>>> CountryCodeData.xml and GeoData.xml.
>>>>>>>
>>>>>>> Would it not - in the spirit of slimdown - wise to merge the two sets (and
>>>>>>> possible others related to Country and GEO data)?
>>>>>>>
>>>>>>> Regards,
>>>>>>>
>>>>>>> Pierre Smits
>>>>>>>
>>>>>>> *ORRTIZ.COM <http://www.orrtiz.com>*
>>>>>>> Services & Solutions for Cloud-
>>>>>>> Based Manufacturing, Professional
>>>>>>> Services and Retail & Trade
>>>>>>> http://www.orrtiz.com
>>>>>>>
>>>>>>>
>>>>>>> On Wed, Sep 25, 2013 at 10:46 PM, <ad...@apache.org> wrote:
>>>>>>>
>>>>>>>> Author: adrianc
>>>>>>>> Date: Wed Sep 25 20:46:40 2013
>>>>>>>> New Revision: 1526296
>>>>>>>>
>>>>>>>> URL: http://svn.apache.org/r1526296
>>>>>>>> Log:
>>>>>>>> Move geo-related seed data to the GeoData.xml file. No functional change.
>>>>>>>>
>>>>>>>> Modified:
>>>>>>>>         ofbiz/trunk/framework/common/data/CommonTypeData.xml
>>>>>>>>         ofbiz/trunk/framework/common/data/GeoData.xml
>>>>>>>>
>>>>>>>> Modified: ofbiz/trunk/framework/common/data/CommonTypeData.xml
>>>>>>>> URL:
>>>>>>>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/data/CommonTypeData.xml?rev=1526296&r1=1526295&r2=1526296&view=diff
>>>>>>>>
>>>>>>>> ==============================================================================
>>>>>>>> --- ofbiz/trunk/framework/common/data/CommonTypeData.xml (original)
>>>>>>>> +++ ofbiz/trunk/framework/common/data/CommonTypeData.xml Wed Sep 25
>>>>>>>> 20:46:40 2013
>>>>>>>> @@ -64,26 +64,6 @@ under the License.
>>>>>>>>          <Enumeration description="Lang: Spanish" enumCode="LANG_SP"
>>>>>>>> enumId="KWTR_LANG_SP" sequenceId="21" enumTypeId="KW_THES_REL"/>
>>>>>>>>          <Enumeration description="Lang: French" enumCode="LANG_FR"
>>>>>>>> enumId="KWTR_LANG_FR" sequenceId="22" enumTypeId="KW_THES_REL"/>
>>>>>>>>
>>>>>>>> -    <GeoType description="City" geoTypeId="CITY" hasTable="N"
>>>>>>>> parentTypeId=""/>
>>>>>>>> -    <GeoType description="Group" geoTypeId="GROUP" hasTable="N"
>>>>>>>> parentTypeId=""/>
>>>>>>>> -    <GeoType description="State" geoTypeId="STATE" hasTable="N"
>>>>>>>> parentTypeId=""/>
>>>>>>>> -    <GeoType description="Postal Code" geoTypeId="POSTAL_CODE"
>>>>>>>> hasTable="N" parentTypeId=""/>
>>>>>>>> -    <GeoType description="Country" geoTypeId="COUNTRY" hasTable="N"
>>>>>>>> parentTypeId=""/>
>>>>>>>> -    <GeoType description="County" geoTypeId="COUNTY" hasTable="N"
>>>>>>>> parentTypeId=""/>
>>>>>>>> -    <GeoType description="County-City" geoTypeId="COUNTY_CITY"
>>>>>>>> hasTable="N" parentTypeId=""/>
>>>>>>>> -    <GeoType description="Municipality" geoTypeId="MUNICIPALITY"
>>>>>>>> hasTable="N" parentTypeId=""/>
>>>>>>>> -    <GeoType description="Province" geoTypeId="PROVINCE" hasTable="N"
>>>>>>>> parentTypeId=""/>
>>>>>>>> -    <GeoType description="Region" geoTypeId="REGION" hasTable="N"
>>>>>>>> parentTypeId=""/>
>>>>>>>> -    <GeoType description="Territory" geoTypeId="TERRITORY" hasTable="N"
>>>>>>>> parentTypeId=""/>
>>>>>>>> -    <GeoType description="Sales Territory" geoTypeId="SALES_TERRITORY"
>>>>>>>> hasTable="N" parentTypeId="TERRITORY"/>
>>>>>>>> -    <GeoType description="Service Territory"
>>>>>>>> geoTypeId="SERVICE_TERRITORY" hasTable="N" parentTypeId="TERRITORY"/>
>>>>>>>> -
>>>>>>>> -    <GeoAssocType geoAssocTypeId="GROUP_MEMBER" description="Geo Group
>>>>>>>> Member"/>
>>>>>>>> -    <GeoAssocType geoAssocTypeId="REGIONS" description="For a region of a
>>>>>>>> larger Geo, i.e. states, counties, provinces..."/>
>>>>>>>> -    <GeoAssocType geoAssocTypeId="COUNTY_CITY" description="City in a
>>>>>>>> county"/>
>>>>>>>> -    <GeoAssocType geoAssocTypeId="COUNTY_SEAT"
>>>>>>>> description="Administrative Main City of a County"/>
>>>>>>>> -    <GeoAssocType geoAssocTypeId="POSTAL_CODE" description="Postal code
>>>>>>>> associated to a GeoType"/>
>>>>>>>> -
>>>>>>>>          <!-- sync status -->
>>>>>>>>          <StatusType description="Synchronize" hasTable="N" parentTypeId=""
>>>>>>>> statusTypeId="SYNCHRONIZE_STATUS"/>
>>>>>>>>          <StatusItem description="Not-Synchronized" sequenceId="01"
>>>>>>>> statusCode="NOT_SYNCHRONIZED" statusId="NOT_SYNCHRONIZED"
>>>>>>>> statusTypeId="SYNCHRONIZE_STATUS"/>
>>>>>>>>
>>>>>>>> Modified: ofbiz/trunk/framework/common/data/GeoData.xml
>>>>>>>> URL:
>>>>>>>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/data/GeoData.xml?rev=1526296&r1=1526295&r2=1526296&view=diff
>>>>>>>>
>>>>>>>> ==============================================================================
>>>>>>>> --- ofbiz/trunk/framework/common/data/GeoData.xml (original)
>>>>>>>> +++ ofbiz/trunk/framework/common/data/GeoData.xml Wed Sep 25 20:46:40 2013
>>>>>>>> @@ -19,6 +19,27 @@ under the License.
>>>>>>>>      -->
>>>>>>>>
>>>>>>>>      <entity-engine-xml>
>>>>>>>> +
>>>>>>>> +    <GeoType description="City" geoTypeId="CITY" hasTable="N"
>>>>>>>> parentTypeId=""/>
>>>>>>>> +    <GeoType description="Group" geoTypeId="GROUP" hasTable="N"
>>>>>>>> parentTypeId=""/>
>>>>>>>> +    <GeoType description="State" geoTypeId="STATE" hasTable="N"
>>>>>>>> parentTypeId=""/>
>>>>>>>> +    <GeoType description="Postal Code" geoTypeId="POSTAL_CODE"
>>>>>>>> hasTable="N" parentTypeId=""/>
>>>>>>>> +    <GeoType description="Country" geoTypeId="COUNTRY" hasTable="N"
>>>>>>>> parentTypeId=""/>
>>>>>>>> +    <GeoType description="County" geoTypeId="COUNTY" hasTable="N"
>>>>>>>> parentTypeId=""/>
>>>>>>>> +    <GeoType description="County-City" geoTypeId="COUNTY_CITY"
>>>>>>>> hasTable="N" parentTypeId=""/>
>>>>>>>> +    <GeoType description="Municipality" geoTypeId="MUNICIPALITY"
>>>>>>>> hasTable="N" parentTypeId=""/>
>>>>>>>> +    <GeoType description="Province" geoTypeId="PROVINCE" hasTable="N"
>>>>>>>> parentTypeId=""/>
>>>>>>>> +    <GeoType description="Region" geoTypeId="REGION" hasTable="N"
>>>>>>>> parentTypeId=""/>
>>>>>>>> +    <GeoType description="Territory" geoTypeId="TERRITORY" hasTable="N"
>>>>>>>> parentTypeId=""/>
>>>>>>>> +    <GeoType description="Sales Territory" geoTypeId="SALES_TERRITORY"
>>>>>>>> hasTable="N" parentTypeId="TERRITORY"/>
>>>>>>>> +    <GeoType description="Service Territory"
>>>>>>>> geoTypeId="SERVICE_TERRITORY" hasTable="N" parentTypeId="TERRITORY"/>
>>>>>>>> +
>>>>>>>> +    <GeoAssocType geoAssocTypeId="GROUP_MEMBER" description="Geo Group
>>>>>>>> Member"/>
>>>>>>>> +    <GeoAssocType geoAssocTypeId="REGIONS" description="For a region of a
>>>>>>>> larger Geo, i.e. states, counties, provinces..."/>
>>>>>>>> +    <GeoAssocType geoAssocTypeId="COUNTY_CITY" description="City in a
>>>>>>>> county"/>
>>>>>>>> +    <GeoAssocType geoAssocTypeId="COUNTY_SEAT"
>>>>>>>> description="Administrative Main City of a County"/>
>>>>>>>> +    <GeoAssocType geoAssocTypeId="POSTAL_CODE" description="Postal code
>>>>>>>> associated to a GeoType"/>
>>>>>>>> +
>>>>>>>>          <!--
>>>>>>>>              Based on: ISO 3166  https://www.iso.org/obp/ui/#search
>>>>>>>>                        and
>>>>>>>> http://www.iso.org/iso/home/standards/country_codes/country_names_and_code_elements.htm
>>>>>>>> .

Re: Geo Location Discussion (was: svn commit: r1526296 - in /ofbiz/trunk/framework/common/data: CommonTypeData.xml GeoData.xml)

Posted by Jacques Le Roux <ja...@les7arts.com>.
Thanks for Sharing Adrian. Indeed this would be a lot of changes. 

>>> Years later there is so
>>> much code written around those things, that we don't want to change
>>> them. So, that is why I choose to replace them locally.

I agree!

Jacques

Adrian Crum wrote:
> http://www.sandglass-software.com/products/sandglass/documents/v1/LocationModels.pdf
> 
> Adrian Crum
> Sandglass Software
> www.sandglass-software.com
> 
> On 9/26/2013 12:50 PM, Jacques Le Roux wrote:
>> Adrian Crum wrote:
>>> I will prepare a PDF of the model I am using and share it.
>>> 
>>> David makes a good point in that discussion: "this is why I'm a little
>>> picky about who makes data model changes... they aren't too complex but
>>> for anyone that hasn't done them a fair amount it is easy to miss
>>> things, and once the entities are used becomes difficult to fix."
>>> 
>>> There are a lot of things like that in OFBiz - despite our best
>>> intentions, some things didn't come out right. Years later there is so
>>> much code written around those things, that we don't want to change
>>> them. So, that is why I choose to replace them locally.
>> 
>> Yes I know. We discussed this part lengthly, there were a lot of good ideas and finally a consensus.
>> But we can always improve and use the data migration page. We should not stay fossilised, despites some opininons, like Skip
>> recently. 
>> 
>> Jacques
>> 
>>> Adrian Crum
>>> Sandglass Software
>>> www.sandglass-software.com
>>> 
>>> On 9/26/2013 7:01 AM, Jacques Le Roux wrote:
>>>> I think it mostly started from there https://issues.apache.org/jira/browse/OFBIZ-1923
>>>> and related thread/s in dev ML (look for geopoint)
>>>> 
>>>> I'm open to discussion...
>>>> 
>>>> Jacques
>>>> 
>>>> 
>>>> Adrian Crum wrote:
>>>>> I agree there is a lot of overlap in the data and in the geo data model.
>>>>> 
>>>>> The Geo data model is a denormalized, disorganized mess. That was the
>>>>> reason for my changes - so I can comment all of it out and replace it
>>>>> with a better model on my local copy.
>>>>> 
>>>>> Yes, it needs to be fixed - but there seems to be a problem finding
>>>>> agreement on what the model should look like.
>>>>> 
>>>>> Conceptually, geo data is location data - just like contact mechanisms.
>>>>>   From my perspective, the geo artifacts should be in the same component
>>>>> as the contact mechanism artifacts. It doesn't belong in the framework.
>>>>> 
>>>>> Adrian Crum
>>>>> Sandglass Software
>>>>> www.sandglass-software.com
>>>>> 
>>>>> On 9/26/2013 12:33 AM, Pierre Smits wrote:
>>>>>> It seems that there is a significant overlap between the data in
>>>>>> CountryCodeData.xml and GeoData.xml.
>>>>>> 
>>>>>> Would it not - in the spirit of slimdown - wise to merge the two sets (and
>>>>>> possible others related to Country and GEO data)?
>>>>>> 
>>>>>> Regards,
>>>>>> 
>>>>>> Pierre Smits
>>>>>> 
>>>>>> *ORRTIZ.COM <http://www.orrtiz.com>*
>>>>>> Services & Solutions for Cloud-
>>>>>> Based Manufacturing, Professional
>>>>>> Services and Retail & Trade
>>>>>> http://www.orrtiz.com
>>>>>> 
>>>>>> 
>>>>>> On Wed, Sep 25, 2013 at 10:46 PM, <ad...@apache.org> wrote:
>>>>>> 
>>>>>>> Author: adrianc
>>>>>>> Date: Wed Sep 25 20:46:40 2013
>>>>>>> New Revision: 1526296
>>>>>>> 
>>>>>>> URL: http://svn.apache.org/r1526296
>>>>>>> Log:
>>>>>>> Move geo-related seed data to the GeoData.xml file. No functional change.
>>>>>>> 
>>>>>>> Modified:
>>>>>>>        ofbiz/trunk/framework/common/data/CommonTypeData.xml
>>>>>>>        ofbiz/trunk/framework/common/data/GeoData.xml
>>>>>>> 
>>>>>>> Modified: ofbiz/trunk/framework/common/data/CommonTypeData.xml
>>>>>>> URL:
>>>>>>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/data/CommonTypeData.xml?rev=1526296&r1=1526295&r2=1526296&view=diff
>>>>>>> 
>>>>>>> ==============================================================================
>>>>>>> --- ofbiz/trunk/framework/common/data/CommonTypeData.xml (original)
>>>>>>> +++ ofbiz/trunk/framework/common/data/CommonTypeData.xml Wed Sep 25
>>>>>>> 20:46:40 2013
>>>>>>> @@ -64,26 +64,6 @@ under the License.
>>>>>>>         <Enumeration description="Lang: Spanish" enumCode="LANG_SP"
>>>>>>> enumId="KWTR_LANG_SP" sequenceId="21" enumTypeId="KW_THES_REL"/>
>>>>>>>         <Enumeration description="Lang: French" enumCode="LANG_FR"
>>>>>>> enumId="KWTR_LANG_FR" sequenceId="22" enumTypeId="KW_THES_REL"/>
>>>>>>> 
>>>>>>> -    <GeoType description="City" geoTypeId="CITY" hasTable="N"
>>>>>>> parentTypeId=""/>
>>>>>>> -    <GeoType description="Group" geoTypeId="GROUP" hasTable="N"
>>>>>>> parentTypeId=""/>
>>>>>>> -    <GeoType description="State" geoTypeId="STATE" hasTable="N"
>>>>>>> parentTypeId=""/>
>>>>>>> -    <GeoType description="Postal Code" geoTypeId="POSTAL_CODE"
>>>>>>> hasTable="N" parentTypeId=""/>
>>>>>>> -    <GeoType description="Country" geoTypeId="COUNTRY" hasTable="N"
>>>>>>> parentTypeId=""/>
>>>>>>> -    <GeoType description="County" geoTypeId="COUNTY" hasTable="N"
>>>>>>> parentTypeId=""/>
>>>>>>> -    <GeoType description="County-City" geoTypeId="COUNTY_CITY"
>>>>>>> hasTable="N" parentTypeId=""/>
>>>>>>> -    <GeoType description="Municipality" geoTypeId="MUNICIPALITY"
>>>>>>> hasTable="N" parentTypeId=""/>
>>>>>>> -    <GeoType description="Province" geoTypeId="PROVINCE" hasTable="N"
>>>>>>> parentTypeId=""/>
>>>>>>> -    <GeoType description="Region" geoTypeId="REGION" hasTable="N"
>>>>>>> parentTypeId=""/>
>>>>>>> -    <GeoType description="Territory" geoTypeId="TERRITORY" hasTable="N"
>>>>>>> parentTypeId=""/>
>>>>>>> -    <GeoType description="Sales Territory" geoTypeId="SALES_TERRITORY"
>>>>>>> hasTable="N" parentTypeId="TERRITORY"/>
>>>>>>> -    <GeoType description="Service Territory"
>>>>>>> geoTypeId="SERVICE_TERRITORY" hasTable="N" parentTypeId="TERRITORY"/>
>>>>>>> -
>>>>>>> -    <GeoAssocType geoAssocTypeId="GROUP_MEMBER" description="Geo Group
>>>>>>> Member"/>
>>>>>>> -    <GeoAssocType geoAssocTypeId="REGIONS" description="For a region of a
>>>>>>> larger Geo, i.e. states, counties, provinces..."/>
>>>>>>> -    <GeoAssocType geoAssocTypeId="COUNTY_CITY" description="City in a
>>>>>>> county"/>
>>>>>>> -    <GeoAssocType geoAssocTypeId="COUNTY_SEAT"
>>>>>>> description="Administrative Main City of a County"/>
>>>>>>> -    <GeoAssocType geoAssocTypeId="POSTAL_CODE" description="Postal code
>>>>>>> associated to a GeoType"/>
>>>>>>> -
>>>>>>>         <!-- sync status -->
>>>>>>>         <StatusType description="Synchronize" hasTable="N" parentTypeId=""
>>>>>>> statusTypeId="SYNCHRONIZE_STATUS"/>
>>>>>>>         <StatusItem description="Not-Synchronized" sequenceId="01"
>>>>>>> statusCode="NOT_SYNCHRONIZED" statusId="NOT_SYNCHRONIZED"
>>>>>>> statusTypeId="SYNCHRONIZE_STATUS"/>
>>>>>>> 
>>>>>>> Modified: ofbiz/trunk/framework/common/data/GeoData.xml
>>>>>>> URL:
>>>>>>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/data/GeoData.xml?rev=1526296&r1=1526295&r2=1526296&view=diff
>>>>>>> 
>>>>>>> ==============================================================================
>>>>>>> --- ofbiz/trunk/framework/common/data/GeoData.xml (original)
>>>>>>> +++ ofbiz/trunk/framework/common/data/GeoData.xml Wed Sep 25 20:46:40 2013
>>>>>>> @@ -19,6 +19,27 @@ under the License.
>>>>>>>     -->
>>>>>>> 
>>>>>>>     <entity-engine-xml>
>>>>>>> +
>>>>>>> +    <GeoType description="City" geoTypeId="CITY" hasTable="N"
>>>>>>> parentTypeId=""/>
>>>>>>> +    <GeoType description="Group" geoTypeId="GROUP" hasTable="N"
>>>>>>> parentTypeId=""/>
>>>>>>> +    <GeoType description="State" geoTypeId="STATE" hasTable="N"
>>>>>>> parentTypeId=""/>
>>>>>>> +    <GeoType description="Postal Code" geoTypeId="POSTAL_CODE"
>>>>>>> hasTable="N" parentTypeId=""/>
>>>>>>> +    <GeoType description="Country" geoTypeId="COUNTRY" hasTable="N"
>>>>>>> parentTypeId=""/>
>>>>>>> +    <GeoType description="County" geoTypeId="COUNTY" hasTable="N"
>>>>>>> parentTypeId=""/>
>>>>>>> +    <GeoType description="County-City" geoTypeId="COUNTY_CITY"
>>>>>>> hasTable="N" parentTypeId=""/>
>>>>>>> +    <GeoType description="Municipality" geoTypeId="MUNICIPALITY"
>>>>>>> hasTable="N" parentTypeId=""/>
>>>>>>> +    <GeoType description="Province" geoTypeId="PROVINCE" hasTable="N"
>>>>>>> parentTypeId=""/>
>>>>>>> +    <GeoType description="Region" geoTypeId="REGION" hasTable="N"
>>>>>>> parentTypeId=""/>
>>>>>>> +    <GeoType description="Territory" geoTypeId="TERRITORY" hasTable="N"
>>>>>>> parentTypeId=""/>
>>>>>>> +    <GeoType description="Sales Territory" geoTypeId="SALES_TERRITORY"
>>>>>>> hasTable="N" parentTypeId="TERRITORY"/>
>>>>>>> +    <GeoType description="Service Territory"
>>>>>>> geoTypeId="SERVICE_TERRITORY" hasTable="N" parentTypeId="TERRITORY"/>
>>>>>>> +
>>>>>>> +    <GeoAssocType geoAssocTypeId="GROUP_MEMBER" description="Geo Group
>>>>>>> Member"/>
>>>>>>> +    <GeoAssocType geoAssocTypeId="REGIONS" description="For a region of a
>>>>>>> larger Geo, i.e. states, counties, provinces..."/>
>>>>>>> +    <GeoAssocType geoAssocTypeId="COUNTY_CITY" description="City in a
>>>>>>> county"/>
>>>>>>> +    <GeoAssocType geoAssocTypeId="COUNTY_SEAT"
>>>>>>> description="Administrative Main City of a County"/>
>>>>>>> +    <GeoAssocType geoAssocTypeId="POSTAL_CODE" description="Postal code
>>>>>>> associated to a GeoType"/>
>>>>>>> +
>>>>>>>         <!--
>>>>>>>             Based on: ISO 3166  https://www.iso.org/obp/ui/#search
>>>>>>>                       and
>>>>>>> http://www.iso.org/iso/home/standards/country_codes/country_names_and_code_elements.htm
>>>>>>> .

Geo Location Discussion (was: svn commit: r1526296 - in /ofbiz/trunk/framework/common/data: CommonTypeData.xml GeoData.xml)

Posted by Adrian Crum <ad...@sandglass-software.com>.
http://www.sandglass-software.com/products/sandglass/documents/v1/LocationModels.pdf

Adrian Crum
Sandglass Software
www.sandglass-software.com

On 9/26/2013 12:50 PM, Jacques Le Roux wrote:
> Adrian Crum wrote:
>> I will prepare a PDF of the model I am using and share it.
>>
>> David makes a good point in that discussion: "this is why I'm a little
>> picky about who makes data model changes... they aren't too complex but
>> for anyone that hasn't done them a fair amount it is easy to miss
>> things, and once the entities are used becomes difficult to fix."
>>
>> There are a lot of things like that in OFBiz - despite our best
>> intentions, some things didn't come out right. Years later there is so
>> much code written around those things, that we don't want to change
>> them. So, that is why I choose to replace them locally.
>
> Yes I know. We discussed this part lengthly, there were a lot of good ideas and finally a consensus.
> But we can always improve and use the data migration page. We should not stay fossilised, despites some opininons, like Skip recently.
>
> Jacques
>
>> Adrian Crum
>> Sandglass Software
>> www.sandglass-software.com
>>
>> On 9/26/2013 7:01 AM, Jacques Le Roux wrote:
>>> I think it mostly started from there https://issues.apache.org/jira/browse/OFBIZ-1923
>>> and related thread/s in dev ML (look for geopoint)
>>>
>>> I'm open to discussion...
>>>
>>> Jacques
>>>
>>>
>>> Adrian Crum wrote:
>>>> I agree there is a lot of overlap in the data and in the geo data model.
>>>>
>>>> The Geo data model is a denormalized, disorganized mess. That was the
>>>> reason for my changes - so I can comment all of it out and replace it
>>>> with a better model on my local copy.
>>>>
>>>> Yes, it needs to be fixed - but there seems to be a problem finding
>>>> agreement on what the model should look like.
>>>>
>>>> Conceptually, geo data is location data - just like contact mechanisms.
>>>>   From my perspective, the geo artifacts should be in the same component
>>>> as the contact mechanism artifacts. It doesn't belong in the framework.
>>>>
>>>> Adrian Crum
>>>> Sandglass Software
>>>> www.sandglass-software.com
>>>>
>>>> On 9/26/2013 12:33 AM, Pierre Smits wrote:
>>>>> It seems that there is a significant overlap between the data in
>>>>> CountryCodeData.xml and GeoData.xml.
>>>>>
>>>>> Would it not - in the spirit of slimdown - wise to merge the two sets (and
>>>>> possible others related to Country and GEO data)?
>>>>>
>>>>> Regards,
>>>>>
>>>>> Pierre Smits
>>>>>
>>>>> *ORRTIZ.COM <http://www.orrtiz.com>*
>>>>> Services & Solutions for Cloud-
>>>>> Based Manufacturing, Professional
>>>>> Services and Retail & Trade
>>>>> http://www.orrtiz.com
>>>>>
>>>>>
>>>>> On Wed, Sep 25, 2013 at 10:46 PM, <ad...@apache.org> wrote:
>>>>>
>>>>>> Author: adrianc
>>>>>> Date: Wed Sep 25 20:46:40 2013
>>>>>> New Revision: 1526296
>>>>>>
>>>>>> URL: http://svn.apache.org/r1526296
>>>>>> Log:
>>>>>> Move geo-related seed data to the GeoData.xml file. No functional change.
>>>>>>
>>>>>> Modified:
>>>>>>        ofbiz/trunk/framework/common/data/CommonTypeData.xml
>>>>>>        ofbiz/trunk/framework/common/data/GeoData.xml
>>>>>>
>>>>>> Modified: ofbiz/trunk/framework/common/data/CommonTypeData.xml
>>>>>> URL:
>>>>>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/data/CommonTypeData.xml?rev=1526296&r1=1526295&r2=1526296&view=diff
>>>>>>
>>>>>> ==============================================================================
>>>>>> --- ofbiz/trunk/framework/common/data/CommonTypeData.xml (original)
>>>>>> +++ ofbiz/trunk/framework/common/data/CommonTypeData.xml Wed Sep 25
>>>>>> 20:46:40 2013
>>>>>> @@ -64,26 +64,6 @@ under the License.
>>>>>>         <Enumeration description="Lang: Spanish" enumCode="LANG_SP"
>>>>>> enumId="KWTR_LANG_SP" sequenceId="21" enumTypeId="KW_THES_REL"/>
>>>>>>         <Enumeration description="Lang: French" enumCode="LANG_FR"
>>>>>> enumId="KWTR_LANG_FR" sequenceId="22" enumTypeId="KW_THES_REL"/>
>>>>>>
>>>>>> -    <GeoType description="City" geoTypeId="CITY" hasTable="N"
>>>>>> parentTypeId=""/>
>>>>>> -    <GeoType description="Group" geoTypeId="GROUP" hasTable="N"
>>>>>> parentTypeId=""/>
>>>>>> -    <GeoType description="State" geoTypeId="STATE" hasTable="N"
>>>>>> parentTypeId=""/>
>>>>>> -    <GeoType description="Postal Code" geoTypeId="POSTAL_CODE"
>>>>>> hasTable="N" parentTypeId=""/>
>>>>>> -    <GeoType description="Country" geoTypeId="COUNTRY" hasTable="N"
>>>>>> parentTypeId=""/>
>>>>>> -    <GeoType description="County" geoTypeId="COUNTY" hasTable="N"
>>>>>> parentTypeId=""/>
>>>>>> -    <GeoType description="County-City" geoTypeId="COUNTY_CITY"
>>>>>> hasTable="N" parentTypeId=""/>
>>>>>> -    <GeoType description="Municipality" geoTypeId="MUNICIPALITY"
>>>>>> hasTable="N" parentTypeId=""/>
>>>>>> -    <GeoType description="Province" geoTypeId="PROVINCE" hasTable="N"
>>>>>> parentTypeId=""/>
>>>>>> -    <GeoType description="Region" geoTypeId="REGION" hasTable="N"
>>>>>> parentTypeId=""/>
>>>>>> -    <GeoType description="Territory" geoTypeId="TERRITORY" hasTable="N"
>>>>>> parentTypeId=""/>
>>>>>> -    <GeoType description="Sales Territory" geoTypeId="SALES_TERRITORY"
>>>>>> hasTable="N" parentTypeId="TERRITORY"/>
>>>>>> -    <GeoType description="Service Territory"
>>>>>> geoTypeId="SERVICE_TERRITORY" hasTable="N" parentTypeId="TERRITORY"/>
>>>>>> -
>>>>>> -    <GeoAssocType geoAssocTypeId="GROUP_MEMBER" description="Geo Group
>>>>>> Member"/>
>>>>>> -    <GeoAssocType geoAssocTypeId="REGIONS" description="For a region of a
>>>>>> larger Geo, i.e. states, counties, provinces..."/>
>>>>>> -    <GeoAssocType geoAssocTypeId="COUNTY_CITY" description="City in a
>>>>>> county"/>
>>>>>> -    <GeoAssocType geoAssocTypeId="COUNTY_SEAT"
>>>>>> description="Administrative Main City of a County"/>
>>>>>> -    <GeoAssocType geoAssocTypeId="POSTAL_CODE" description="Postal code
>>>>>> associated to a GeoType"/>
>>>>>> -
>>>>>>         <!-- sync status -->
>>>>>>         <StatusType description="Synchronize" hasTable="N" parentTypeId=""
>>>>>> statusTypeId="SYNCHRONIZE_STATUS"/>
>>>>>>         <StatusItem description="Not-Synchronized" sequenceId="01"
>>>>>> statusCode="NOT_SYNCHRONIZED" statusId="NOT_SYNCHRONIZED"
>>>>>> statusTypeId="SYNCHRONIZE_STATUS"/>
>>>>>>
>>>>>> Modified: ofbiz/trunk/framework/common/data/GeoData.xml
>>>>>> URL:
>>>>>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/data/GeoData.xml?rev=1526296&r1=1526295&r2=1526296&view=diff
>>>>>>
>>>>>> ==============================================================================
>>>>>> --- ofbiz/trunk/framework/common/data/GeoData.xml (original)
>>>>>> +++ ofbiz/trunk/framework/common/data/GeoData.xml Wed Sep 25 20:46:40 2013
>>>>>> @@ -19,6 +19,27 @@ under the License.
>>>>>>     -->
>>>>>>
>>>>>>     <entity-engine-xml>
>>>>>> +
>>>>>> +    <GeoType description="City" geoTypeId="CITY" hasTable="N"
>>>>>> parentTypeId=""/>
>>>>>> +    <GeoType description="Group" geoTypeId="GROUP" hasTable="N"
>>>>>> parentTypeId=""/>
>>>>>> +    <GeoType description="State" geoTypeId="STATE" hasTable="N"
>>>>>> parentTypeId=""/>
>>>>>> +    <GeoType description="Postal Code" geoTypeId="POSTAL_CODE"
>>>>>> hasTable="N" parentTypeId=""/>
>>>>>> +    <GeoType description="Country" geoTypeId="COUNTRY" hasTable="N"
>>>>>> parentTypeId=""/>
>>>>>> +    <GeoType description="County" geoTypeId="COUNTY" hasTable="N"
>>>>>> parentTypeId=""/>
>>>>>> +    <GeoType description="County-City" geoTypeId="COUNTY_CITY"
>>>>>> hasTable="N" parentTypeId=""/>
>>>>>> +    <GeoType description="Municipality" geoTypeId="MUNICIPALITY"
>>>>>> hasTable="N" parentTypeId=""/>
>>>>>> +    <GeoType description="Province" geoTypeId="PROVINCE" hasTable="N"
>>>>>> parentTypeId=""/>
>>>>>> +    <GeoType description="Region" geoTypeId="REGION" hasTable="N"
>>>>>> parentTypeId=""/>
>>>>>> +    <GeoType description="Territory" geoTypeId="TERRITORY" hasTable="N"
>>>>>> parentTypeId=""/>
>>>>>> +    <GeoType description="Sales Territory" geoTypeId="SALES_TERRITORY"
>>>>>> hasTable="N" parentTypeId="TERRITORY"/>
>>>>>> +    <GeoType description="Service Territory"
>>>>>> geoTypeId="SERVICE_TERRITORY" hasTable="N" parentTypeId="TERRITORY"/>
>>>>>> +
>>>>>> +    <GeoAssocType geoAssocTypeId="GROUP_MEMBER" description="Geo Group
>>>>>> Member"/>
>>>>>> +    <GeoAssocType geoAssocTypeId="REGIONS" description="For a region of a
>>>>>> larger Geo, i.e. states, counties, provinces..."/>
>>>>>> +    <GeoAssocType geoAssocTypeId="COUNTY_CITY" description="City in a
>>>>>> county"/>
>>>>>> +    <GeoAssocType geoAssocTypeId="COUNTY_SEAT"
>>>>>> description="Administrative Main City of a County"/>
>>>>>> +    <GeoAssocType geoAssocTypeId="POSTAL_CODE" description="Postal code
>>>>>> associated to a GeoType"/>
>>>>>> +
>>>>>>         <!--
>>>>>>             Based on: ISO 3166  https://www.iso.org/obp/ui/#search
>>>>>>                       and
>>>>>> http://www.iso.org/iso/home/standards/country_codes/country_names_and_code_elements.htm
>>>>>> .

Re: svn commit: r1526296 - in /ofbiz/trunk/framework/common/data: CommonTypeData.xml GeoData.xml

Posted by Jacques Le Roux <ja...@les7arts.com>.
Adrian Crum wrote:
> I will prepare a PDF of the model I am using and share it.
> 
> David makes a good point in that discussion: "this is why I'm a little
> picky about who makes data model changes... they aren't too complex but
> for anyone that hasn't done them a fair amount it is easy to miss
> things, and once the entities are used becomes difficult to fix."
> 
> There are a lot of things like that in OFBiz - despite our best
> intentions, some things didn't come out right. Years later there is so
> much code written around those things, that we don't want to change
> them. So, that is why I choose to replace them locally.

Yes I know. We discussed this part lengthly, there were a lot of good ideas and finally a consensus.
But we can always improve and use the data migration page. We should not stay fossilised, despites some opininons, like Skip recently.

Jacques
 
> Adrian Crum
> Sandglass Software
> www.sandglass-software.com
> 
> On 9/26/2013 7:01 AM, Jacques Le Roux wrote:
>> I think it mostly started from there https://issues.apache.org/jira/browse/OFBIZ-1923
>> and related thread/s in dev ML (look for geopoint)
>> 
>> I'm open to discussion...
>> 
>> Jacques
>> 
>> 
>> Adrian Crum wrote:
>>> I agree there is a lot of overlap in the data and in the geo data model.
>>> 
>>> The Geo data model is a denormalized, disorganized mess. That was the
>>> reason for my changes - so I can comment all of it out and replace it
>>> with a better model on my local copy.
>>> 
>>> Yes, it needs to be fixed - but there seems to be a problem finding
>>> agreement on what the model should look like.
>>> 
>>> Conceptually, geo data is location data - just like contact mechanisms.
>>>  From my perspective, the geo artifacts should be in the same component
>>> as the contact mechanism artifacts. It doesn't belong in the framework.
>>> 
>>> Adrian Crum
>>> Sandglass Software
>>> www.sandglass-software.com
>>> 
>>> On 9/26/2013 12:33 AM, Pierre Smits wrote:
>>>> It seems that there is a significant overlap between the data in
>>>> CountryCodeData.xml and GeoData.xml.
>>>> 
>>>> Would it not - in the spirit of slimdown - wise to merge the two sets (and
>>>> possible others related to Country and GEO data)?
>>>> 
>>>> Regards,
>>>> 
>>>> Pierre Smits
>>>> 
>>>> *ORRTIZ.COM <http://www.orrtiz.com>*
>>>> Services & Solutions for Cloud-
>>>> Based Manufacturing, Professional
>>>> Services and Retail & Trade
>>>> http://www.orrtiz.com
>>>> 
>>>> 
>>>> On Wed, Sep 25, 2013 at 10:46 PM, <ad...@apache.org> wrote:
>>>> 
>>>>> Author: adrianc
>>>>> Date: Wed Sep 25 20:46:40 2013
>>>>> New Revision: 1526296
>>>>> 
>>>>> URL: http://svn.apache.org/r1526296
>>>>> Log:
>>>>> Move geo-related seed data to the GeoData.xml file. No functional change.
>>>>> 
>>>>> Modified:
>>>>>       ofbiz/trunk/framework/common/data/CommonTypeData.xml
>>>>>       ofbiz/trunk/framework/common/data/GeoData.xml
>>>>> 
>>>>> Modified: ofbiz/trunk/framework/common/data/CommonTypeData.xml
>>>>> URL:
>>>>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/data/CommonTypeData.xml?rev=1526296&r1=1526295&r2=1526296&view=diff
>>>>> 
>>>>> ==============================================================================
>>>>> --- ofbiz/trunk/framework/common/data/CommonTypeData.xml (original)
>>>>> +++ ofbiz/trunk/framework/common/data/CommonTypeData.xml Wed Sep 25
>>>>> 20:46:40 2013
>>>>> @@ -64,26 +64,6 @@ under the License.
>>>>>        <Enumeration description="Lang: Spanish" enumCode="LANG_SP"
>>>>> enumId="KWTR_LANG_SP" sequenceId="21" enumTypeId="KW_THES_REL"/>
>>>>>        <Enumeration description="Lang: French" enumCode="LANG_FR"
>>>>> enumId="KWTR_LANG_FR" sequenceId="22" enumTypeId="KW_THES_REL"/>
>>>>> 
>>>>> -    <GeoType description="City" geoTypeId="CITY" hasTable="N"
>>>>> parentTypeId=""/>
>>>>> -    <GeoType description="Group" geoTypeId="GROUP" hasTable="N"
>>>>> parentTypeId=""/>
>>>>> -    <GeoType description="State" geoTypeId="STATE" hasTable="N"
>>>>> parentTypeId=""/>
>>>>> -    <GeoType description="Postal Code" geoTypeId="POSTAL_CODE"
>>>>> hasTable="N" parentTypeId=""/>
>>>>> -    <GeoType description="Country" geoTypeId="COUNTRY" hasTable="N"
>>>>> parentTypeId=""/>
>>>>> -    <GeoType description="County" geoTypeId="COUNTY" hasTable="N"
>>>>> parentTypeId=""/>
>>>>> -    <GeoType description="County-City" geoTypeId="COUNTY_CITY"
>>>>> hasTable="N" parentTypeId=""/>
>>>>> -    <GeoType description="Municipality" geoTypeId="MUNICIPALITY"
>>>>> hasTable="N" parentTypeId=""/>
>>>>> -    <GeoType description="Province" geoTypeId="PROVINCE" hasTable="N"
>>>>> parentTypeId=""/>
>>>>> -    <GeoType description="Region" geoTypeId="REGION" hasTable="N"
>>>>> parentTypeId=""/>
>>>>> -    <GeoType description="Territory" geoTypeId="TERRITORY" hasTable="N"
>>>>> parentTypeId=""/>
>>>>> -    <GeoType description="Sales Territory" geoTypeId="SALES_TERRITORY"
>>>>> hasTable="N" parentTypeId="TERRITORY"/>
>>>>> -    <GeoType description="Service Territory"
>>>>> geoTypeId="SERVICE_TERRITORY" hasTable="N" parentTypeId="TERRITORY"/>
>>>>> -
>>>>> -    <GeoAssocType geoAssocTypeId="GROUP_MEMBER" description="Geo Group
>>>>> Member"/>
>>>>> -    <GeoAssocType geoAssocTypeId="REGIONS" description="For a region of a
>>>>> larger Geo, i.e. states, counties, provinces..."/>
>>>>> -    <GeoAssocType geoAssocTypeId="COUNTY_CITY" description="City in a
>>>>> county"/>
>>>>> -    <GeoAssocType geoAssocTypeId="COUNTY_SEAT"
>>>>> description="Administrative Main City of a County"/>
>>>>> -    <GeoAssocType geoAssocTypeId="POSTAL_CODE" description="Postal code
>>>>> associated to a GeoType"/>
>>>>> -
>>>>>        <!-- sync status -->
>>>>>        <StatusType description="Synchronize" hasTable="N" parentTypeId=""
>>>>> statusTypeId="SYNCHRONIZE_STATUS"/>
>>>>>        <StatusItem description="Not-Synchronized" sequenceId="01"
>>>>> statusCode="NOT_SYNCHRONIZED" statusId="NOT_SYNCHRONIZED"
>>>>> statusTypeId="SYNCHRONIZE_STATUS"/>
>>>>> 
>>>>> Modified: ofbiz/trunk/framework/common/data/GeoData.xml
>>>>> URL:
>>>>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/data/GeoData.xml?rev=1526296&r1=1526295&r2=1526296&view=diff
>>>>> 
>>>>> ==============================================================================
>>>>> --- ofbiz/trunk/framework/common/data/GeoData.xml (original)
>>>>> +++ ofbiz/trunk/framework/common/data/GeoData.xml Wed Sep 25 20:46:40 2013
>>>>> @@ -19,6 +19,27 @@ under the License.
>>>>>    -->
>>>>> 
>>>>>    <entity-engine-xml>
>>>>> +
>>>>> +    <GeoType description="City" geoTypeId="CITY" hasTable="N"
>>>>> parentTypeId=""/>
>>>>> +    <GeoType description="Group" geoTypeId="GROUP" hasTable="N"
>>>>> parentTypeId=""/>
>>>>> +    <GeoType description="State" geoTypeId="STATE" hasTable="N"
>>>>> parentTypeId=""/>
>>>>> +    <GeoType description="Postal Code" geoTypeId="POSTAL_CODE"
>>>>> hasTable="N" parentTypeId=""/>
>>>>> +    <GeoType description="Country" geoTypeId="COUNTRY" hasTable="N"
>>>>> parentTypeId=""/>
>>>>> +    <GeoType description="County" geoTypeId="COUNTY" hasTable="N"
>>>>> parentTypeId=""/>
>>>>> +    <GeoType description="County-City" geoTypeId="COUNTY_CITY"
>>>>> hasTable="N" parentTypeId=""/>
>>>>> +    <GeoType description="Municipality" geoTypeId="MUNICIPALITY"
>>>>> hasTable="N" parentTypeId=""/>
>>>>> +    <GeoType description="Province" geoTypeId="PROVINCE" hasTable="N"
>>>>> parentTypeId=""/>
>>>>> +    <GeoType description="Region" geoTypeId="REGION" hasTable="N"
>>>>> parentTypeId=""/>
>>>>> +    <GeoType description="Territory" geoTypeId="TERRITORY" hasTable="N"
>>>>> parentTypeId=""/>
>>>>> +    <GeoType description="Sales Territory" geoTypeId="SALES_TERRITORY"
>>>>> hasTable="N" parentTypeId="TERRITORY"/>
>>>>> +    <GeoType description="Service Territory"
>>>>> geoTypeId="SERVICE_TERRITORY" hasTable="N" parentTypeId="TERRITORY"/>
>>>>> +
>>>>> +    <GeoAssocType geoAssocTypeId="GROUP_MEMBER" description="Geo Group
>>>>> Member"/>
>>>>> +    <GeoAssocType geoAssocTypeId="REGIONS" description="For a region of a
>>>>> larger Geo, i.e. states, counties, provinces..."/>
>>>>> +    <GeoAssocType geoAssocTypeId="COUNTY_CITY" description="City in a
>>>>> county"/>
>>>>> +    <GeoAssocType geoAssocTypeId="COUNTY_SEAT"
>>>>> description="Administrative Main City of a County"/>
>>>>> +    <GeoAssocType geoAssocTypeId="POSTAL_CODE" description="Postal code
>>>>> associated to a GeoType"/>
>>>>> +
>>>>>        <!--
>>>>>            Based on: ISO 3166  https://www.iso.org/obp/ui/#search
>>>>>                      and
>>>>> http://www.iso.org/iso/home/standards/country_codes/country_names_and_code_elements.htm
>>>>> .

Re: svn commit: r1526296 - in /ofbiz/trunk/framework/common/data: CommonTypeData.xml GeoData.xml

Posted by Adrian Crum <ad...@sandglass-software.com>.
I will prepare a PDF of the model I am using and share it.

David makes a good point in that discussion: "this is why I'm a little 
picky about who makes data model changes... they aren't too complex but 
for anyone that hasn't done them a fair amount it is easy to miss 
things, and once the entities are used becomes difficult to fix."

There are a lot of things like that in OFBiz - despite our best 
intentions, some things didn't come out right. Years later there is so 
much code written around those things, that we don't want to change 
them. So, that is why I choose to replace them locally.

Adrian Crum
Sandglass Software
www.sandglass-software.com

On 9/26/2013 7:01 AM, Jacques Le Roux wrote:
> I think it mostly started from there https://issues.apache.org/jira/browse/OFBIZ-1923
> and related thread/s in dev ML (look for geopoint)
>
> I'm open to discussion...
>
> Jacques
>
>
> Adrian Crum wrote:
>> I agree there is a lot of overlap in the data and in the geo data model.
>>
>> The Geo data model is a denormalized, disorganized mess. That was the
>> reason for my changes - so I can comment all of it out and replace it
>> with a better model on my local copy.
>>
>> Yes, it needs to be fixed - but there seems to be a problem finding
>> agreement on what the model should look like.
>>
>> Conceptually, geo data is location data - just like contact mechanisms.
>>  From my perspective, the geo artifacts should be in the same component
>> as the contact mechanism artifacts. It doesn't belong in the framework.
>>
>> Adrian Crum
>> Sandglass Software
>> www.sandglass-software.com
>>
>> On 9/26/2013 12:33 AM, Pierre Smits wrote:
>>> It seems that there is a significant overlap between the data in
>>> CountryCodeData.xml and GeoData.xml.
>>>
>>> Would it not - in the spirit of slimdown - wise to merge the two sets (and
>>> possible others related to Country and GEO data)?
>>>
>>> Regards,
>>>
>>> Pierre Smits
>>>
>>> *ORRTIZ.COM <http://www.orrtiz.com>*
>>> Services & Solutions for Cloud-
>>> Based Manufacturing, Professional
>>> Services and Retail & Trade
>>> http://www.orrtiz.com
>>>
>>>
>>> On Wed, Sep 25, 2013 at 10:46 PM, <ad...@apache.org> wrote:
>>>
>>>> Author: adrianc
>>>> Date: Wed Sep 25 20:46:40 2013
>>>> New Revision: 1526296
>>>>
>>>> URL: http://svn.apache.org/r1526296
>>>> Log:
>>>> Move geo-related seed data to the GeoData.xml file. No functional change.
>>>>
>>>> Modified:
>>>>       ofbiz/trunk/framework/common/data/CommonTypeData.xml
>>>>       ofbiz/trunk/framework/common/data/GeoData.xml
>>>>
>>>> Modified: ofbiz/trunk/framework/common/data/CommonTypeData.xml
>>>> URL:
>>>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/data/CommonTypeData.xml?rev=1526296&r1=1526295&r2=1526296&view=diff
>>>>
>>>> ==============================================================================
>>>> --- ofbiz/trunk/framework/common/data/CommonTypeData.xml (original)
>>>> +++ ofbiz/trunk/framework/common/data/CommonTypeData.xml Wed Sep 25
>>>> 20:46:40 2013
>>>> @@ -64,26 +64,6 @@ under the License.
>>>>        <Enumeration description="Lang: Spanish" enumCode="LANG_SP"
>>>> enumId="KWTR_LANG_SP" sequenceId="21" enumTypeId="KW_THES_REL"/>
>>>>        <Enumeration description="Lang: French" enumCode="LANG_FR"
>>>> enumId="KWTR_LANG_FR" sequenceId="22" enumTypeId="KW_THES_REL"/>
>>>>
>>>> -    <GeoType description="City" geoTypeId="CITY" hasTable="N"
>>>> parentTypeId=""/>
>>>> -    <GeoType description="Group" geoTypeId="GROUP" hasTable="N"
>>>> parentTypeId=""/>
>>>> -    <GeoType description="State" geoTypeId="STATE" hasTable="N"
>>>> parentTypeId=""/>
>>>> -    <GeoType description="Postal Code" geoTypeId="POSTAL_CODE"
>>>> hasTable="N" parentTypeId=""/>
>>>> -    <GeoType description="Country" geoTypeId="COUNTRY" hasTable="N"
>>>> parentTypeId=""/>
>>>> -    <GeoType description="County" geoTypeId="COUNTY" hasTable="N"
>>>> parentTypeId=""/>
>>>> -    <GeoType description="County-City" geoTypeId="COUNTY_CITY"
>>>> hasTable="N" parentTypeId=""/>
>>>> -    <GeoType description="Municipality" geoTypeId="MUNICIPALITY"
>>>> hasTable="N" parentTypeId=""/>
>>>> -    <GeoType description="Province" geoTypeId="PROVINCE" hasTable="N"
>>>> parentTypeId=""/>
>>>> -    <GeoType description="Region" geoTypeId="REGION" hasTable="N"
>>>> parentTypeId=""/>
>>>> -    <GeoType description="Territory" geoTypeId="TERRITORY" hasTable="N"
>>>> parentTypeId=""/>
>>>> -    <GeoType description="Sales Territory" geoTypeId="SALES_TERRITORY"
>>>> hasTable="N" parentTypeId="TERRITORY"/>
>>>> -    <GeoType description="Service Territory"
>>>> geoTypeId="SERVICE_TERRITORY" hasTable="N" parentTypeId="TERRITORY"/>
>>>> -
>>>> -    <GeoAssocType geoAssocTypeId="GROUP_MEMBER" description="Geo Group
>>>> Member"/>
>>>> -    <GeoAssocType geoAssocTypeId="REGIONS" description="For a region of a
>>>> larger Geo, i.e. states, counties, provinces..."/>
>>>> -    <GeoAssocType geoAssocTypeId="COUNTY_CITY" description="City in a
>>>> county"/>
>>>> -    <GeoAssocType geoAssocTypeId="COUNTY_SEAT"
>>>> description="Administrative Main City of a County"/>
>>>> -    <GeoAssocType geoAssocTypeId="POSTAL_CODE" description="Postal code
>>>> associated to a GeoType"/>
>>>> -
>>>>        <!-- sync status -->
>>>>        <StatusType description="Synchronize" hasTable="N" parentTypeId=""
>>>> statusTypeId="SYNCHRONIZE_STATUS"/>
>>>>        <StatusItem description="Not-Synchronized" sequenceId="01"
>>>> statusCode="NOT_SYNCHRONIZED" statusId="NOT_SYNCHRONIZED"
>>>> statusTypeId="SYNCHRONIZE_STATUS"/>
>>>>
>>>> Modified: ofbiz/trunk/framework/common/data/GeoData.xml
>>>> URL:
>>>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/data/GeoData.xml?rev=1526296&r1=1526295&r2=1526296&view=diff
>>>>
>>>> ==============================================================================
>>>> --- ofbiz/trunk/framework/common/data/GeoData.xml (original)
>>>> +++ ofbiz/trunk/framework/common/data/GeoData.xml Wed Sep 25 20:46:40 2013
>>>> @@ -19,6 +19,27 @@ under the License.
>>>>    -->
>>>>
>>>>    <entity-engine-xml>
>>>> +
>>>> +    <GeoType description="City" geoTypeId="CITY" hasTable="N"
>>>> parentTypeId=""/>
>>>> +    <GeoType description="Group" geoTypeId="GROUP" hasTable="N"
>>>> parentTypeId=""/>
>>>> +    <GeoType description="State" geoTypeId="STATE" hasTable="N"
>>>> parentTypeId=""/>
>>>> +    <GeoType description="Postal Code" geoTypeId="POSTAL_CODE"
>>>> hasTable="N" parentTypeId=""/>
>>>> +    <GeoType description="Country" geoTypeId="COUNTRY" hasTable="N"
>>>> parentTypeId=""/>
>>>> +    <GeoType description="County" geoTypeId="COUNTY" hasTable="N"
>>>> parentTypeId=""/>
>>>> +    <GeoType description="County-City" geoTypeId="COUNTY_CITY"
>>>> hasTable="N" parentTypeId=""/>
>>>> +    <GeoType description="Municipality" geoTypeId="MUNICIPALITY"
>>>> hasTable="N" parentTypeId=""/>
>>>> +    <GeoType description="Province" geoTypeId="PROVINCE" hasTable="N"
>>>> parentTypeId=""/>
>>>> +    <GeoType description="Region" geoTypeId="REGION" hasTable="N"
>>>> parentTypeId=""/>
>>>> +    <GeoType description="Territory" geoTypeId="TERRITORY" hasTable="N"
>>>> parentTypeId=""/>
>>>> +    <GeoType description="Sales Territory" geoTypeId="SALES_TERRITORY"
>>>> hasTable="N" parentTypeId="TERRITORY"/>
>>>> +    <GeoType description="Service Territory"
>>>> geoTypeId="SERVICE_TERRITORY" hasTable="N" parentTypeId="TERRITORY"/>
>>>> +
>>>> +    <GeoAssocType geoAssocTypeId="GROUP_MEMBER" description="Geo Group
>>>> Member"/>
>>>> +    <GeoAssocType geoAssocTypeId="REGIONS" description="For a region of a
>>>> larger Geo, i.e. states, counties, provinces..."/>
>>>> +    <GeoAssocType geoAssocTypeId="COUNTY_CITY" description="City in a
>>>> county"/>
>>>> +    <GeoAssocType geoAssocTypeId="COUNTY_SEAT"
>>>> description="Administrative Main City of a County"/>
>>>> +    <GeoAssocType geoAssocTypeId="POSTAL_CODE" description="Postal code
>>>> associated to a GeoType"/>
>>>> +
>>>>        <!--
>>>>            Based on: ISO 3166  https://www.iso.org/obp/ui/#search
>>>>                      and
>>>> http://www.iso.org/iso/home/standards/country_codes/country_names_and_code_elements.htm
>>>> .

Re: svn commit: r1526296 - in /ofbiz/trunk/framework/common/data: CommonTypeData.xml GeoData.xml

Posted by Jacques Le Roux <ja...@les7arts.com>.
I think it mostly started from there https://issues.apache.org/jira/browse/OFBIZ-1923
and related thread/s in dev ML (look for geopoint)

I'm open to discussion...

Jacques


Adrian Crum wrote:
> I agree there is a lot of overlap in the data and in the geo data model.
> 
> The Geo data model is a denormalized, disorganized mess. That was the
> reason for my changes - so I can comment all of it out and replace it
> with a better model on my local copy.
> 
> Yes, it needs to be fixed - but there seems to be a problem finding
> agreement on what the model should look like.
> 
> Conceptually, geo data is location data - just like contact mechanisms.
> From my perspective, the geo artifacts should be in the same component
> as the contact mechanism artifacts. It doesn't belong in the framework.
> 
> Adrian Crum
> Sandglass Software
> www.sandglass-software.com
> 
> On 9/26/2013 12:33 AM, Pierre Smits wrote:
>> It seems that there is a significant overlap between the data in
>> CountryCodeData.xml and GeoData.xml.
>> 
>> Would it not - in the spirit of slimdown - wise to merge the two sets (and
>> possible others related to Country and GEO data)?
>> 
>> Regards,
>> 
>> Pierre Smits
>> 
>> *ORRTIZ.COM <http://www.orrtiz.com>*
>> Services & Solutions for Cloud-
>> Based Manufacturing, Professional
>> Services and Retail & Trade
>> http://www.orrtiz.com
>> 
>> 
>> On Wed, Sep 25, 2013 at 10:46 PM, <ad...@apache.org> wrote:
>> 
>>> Author: adrianc
>>> Date: Wed Sep 25 20:46:40 2013
>>> New Revision: 1526296
>>> 
>>> URL: http://svn.apache.org/r1526296
>>> Log:
>>> Move geo-related seed data to the GeoData.xml file. No functional change.
>>> 
>>> Modified:
>>>      ofbiz/trunk/framework/common/data/CommonTypeData.xml
>>>      ofbiz/trunk/framework/common/data/GeoData.xml
>>> 
>>> Modified: ofbiz/trunk/framework/common/data/CommonTypeData.xml
>>> URL:
>>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/data/CommonTypeData.xml?rev=1526296&r1=1526295&r2=1526296&view=diff
>>> 
>>> ==============================================================================
>>> --- ofbiz/trunk/framework/common/data/CommonTypeData.xml (original)
>>> +++ ofbiz/trunk/framework/common/data/CommonTypeData.xml Wed Sep 25
>>> 20:46:40 2013
>>> @@ -64,26 +64,6 @@ under the License.
>>>       <Enumeration description="Lang: Spanish" enumCode="LANG_SP"
>>> enumId="KWTR_LANG_SP" sequenceId="21" enumTypeId="KW_THES_REL"/>
>>>       <Enumeration description="Lang: French" enumCode="LANG_FR"
>>> enumId="KWTR_LANG_FR" sequenceId="22" enumTypeId="KW_THES_REL"/>
>>> 
>>> -    <GeoType description="City" geoTypeId="CITY" hasTable="N"
>>> parentTypeId=""/>
>>> -    <GeoType description="Group" geoTypeId="GROUP" hasTable="N"
>>> parentTypeId=""/>
>>> -    <GeoType description="State" geoTypeId="STATE" hasTable="N"
>>> parentTypeId=""/>
>>> -    <GeoType description="Postal Code" geoTypeId="POSTAL_CODE"
>>> hasTable="N" parentTypeId=""/>
>>> -    <GeoType description="Country" geoTypeId="COUNTRY" hasTable="N"
>>> parentTypeId=""/>
>>> -    <GeoType description="County" geoTypeId="COUNTY" hasTable="N"
>>> parentTypeId=""/>
>>> -    <GeoType description="County-City" geoTypeId="COUNTY_CITY"
>>> hasTable="N" parentTypeId=""/>
>>> -    <GeoType description="Municipality" geoTypeId="MUNICIPALITY"
>>> hasTable="N" parentTypeId=""/>
>>> -    <GeoType description="Province" geoTypeId="PROVINCE" hasTable="N"
>>> parentTypeId=""/>
>>> -    <GeoType description="Region" geoTypeId="REGION" hasTable="N"
>>> parentTypeId=""/>
>>> -    <GeoType description="Territory" geoTypeId="TERRITORY" hasTable="N"
>>> parentTypeId=""/>
>>> -    <GeoType description="Sales Territory" geoTypeId="SALES_TERRITORY"
>>> hasTable="N" parentTypeId="TERRITORY"/>
>>> -    <GeoType description="Service Territory"
>>> geoTypeId="SERVICE_TERRITORY" hasTable="N" parentTypeId="TERRITORY"/>
>>> -
>>> -    <GeoAssocType geoAssocTypeId="GROUP_MEMBER" description="Geo Group
>>> Member"/>
>>> -    <GeoAssocType geoAssocTypeId="REGIONS" description="For a region of a
>>> larger Geo, i.e. states, counties, provinces..."/>
>>> -    <GeoAssocType geoAssocTypeId="COUNTY_CITY" description="City in a
>>> county"/>
>>> -    <GeoAssocType geoAssocTypeId="COUNTY_SEAT"
>>> description="Administrative Main City of a County"/>
>>> -    <GeoAssocType geoAssocTypeId="POSTAL_CODE" description="Postal code
>>> associated to a GeoType"/>
>>> -
>>>       <!-- sync status -->
>>>       <StatusType description="Synchronize" hasTable="N" parentTypeId=""
>>> statusTypeId="SYNCHRONIZE_STATUS"/>
>>>       <StatusItem description="Not-Synchronized" sequenceId="01"
>>> statusCode="NOT_SYNCHRONIZED" statusId="NOT_SYNCHRONIZED"
>>> statusTypeId="SYNCHRONIZE_STATUS"/>
>>> 
>>> Modified: ofbiz/trunk/framework/common/data/GeoData.xml
>>> URL:
>>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/data/GeoData.xml?rev=1526296&r1=1526295&r2=1526296&view=diff
>>> 
>>> ==============================================================================
>>> --- ofbiz/trunk/framework/common/data/GeoData.xml (original)
>>> +++ ofbiz/trunk/framework/common/data/GeoData.xml Wed Sep 25 20:46:40 2013
>>> @@ -19,6 +19,27 @@ under the License.
>>>   -->
>>> 
>>>   <entity-engine-xml>
>>> +
>>> +    <GeoType description="City" geoTypeId="CITY" hasTable="N"
>>> parentTypeId=""/>
>>> +    <GeoType description="Group" geoTypeId="GROUP" hasTable="N"
>>> parentTypeId=""/>
>>> +    <GeoType description="State" geoTypeId="STATE" hasTable="N"
>>> parentTypeId=""/>
>>> +    <GeoType description="Postal Code" geoTypeId="POSTAL_CODE"
>>> hasTable="N" parentTypeId=""/>
>>> +    <GeoType description="Country" geoTypeId="COUNTRY" hasTable="N"
>>> parentTypeId=""/>
>>> +    <GeoType description="County" geoTypeId="COUNTY" hasTable="N"
>>> parentTypeId=""/>
>>> +    <GeoType description="County-City" geoTypeId="COUNTY_CITY"
>>> hasTable="N" parentTypeId=""/>
>>> +    <GeoType description="Municipality" geoTypeId="MUNICIPALITY"
>>> hasTable="N" parentTypeId=""/>
>>> +    <GeoType description="Province" geoTypeId="PROVINCE" hasTable="N"
>>> parentTypeId=""/>
>>> +    <GeoType description="Region" geoTypeId="REGION" hasTable="N"
>>> parentTypeId=""/>
>>> +    <GeoType description="Territory" geoTypeId="TERRITORY" hasTable="N"
>>> parentTypeId=""/>
>>> +    <GeoType description="Sales Territory" geoTypeId="SALES_TERRITORY"
>>> hasTable="N" parentTypeId="TERRITORY"/>
>>> +    <GeoType description="Service Territory"
>>> geoTypeId="SERVICE_TERRITORY" hasTable="N" parentTypeId="TERRITORY"/>
>>> +
>>> +    <GeoAssocType geoAssocTypeId="GROUP_MEMBER" description="Geo Group
>>> Member"/>
>>> +    <GeoAssocType geoAssocTypeId="REGIONS" description="For a region of a
>>> larger Geo, i.e. states, counties, provinces..."/>
>>> +    <GeoAssocType geoAssocTypeId="COUNTY_CITY" description="City in a
>>> county"/>
>>> +    <GeoAssocType geoAssocTypeId="COUNTY_SEAT"
>>> description="Administrative Main City of a County"/>
>>> +    <GeoAssocType geoAssocTypeId="POSTAL_CODE" description="Postal code
>>> associated to a GeoType"/>
>>> +
>>>       <!--
>>>           Based on: ISO 3166  https://www.iso.org/obp/ui/#search
>>>                     and
>>> http://www.iso.org/iso/home/standards/country_codes/country_names_and_code_elements.htm
>>> .

Re: svn commit: r1526296 - in /ofbiz/trunk/framework/common/data: CommonTypeData.xml GeoData.xml

Posted by Pierre Smits <pi...@gmail.com>.
Haha,

No problem. I need to curb that aspect of my character also in order to
stay focused on the subject at hand.

Pierre Smits

*ORRTIZ.COM <http://www.orrtiz.com>*
Services & Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail & Trade
http://www.orrtiz.com

Re: svn commit: r1526296 - in /ofbiz/trunk/framework/common/data: CommonTypeData.xml GeoData.xml

Posted by Adrian Crum <ad...@sandglass-software.com>.
You are correct - we started off talking about the data, then I included 
the whole set of artifacts.

Sometimes my replies go that way. "While we're fixing the flat tire, 
let's replace all the tires so we will have fewer tire-related problems 
in the future..."

Adrian Crum
Sandglass Software
www.sandglass-software.com

On 9/26/2013 7:26 AM, Pierre Smits wrote:
> I thought we were talking about the data and its location.
>
> My reference to the document by David was merely to point out his view
> point on what should go where can also be applied to the location of data
> files. I regard GEO data (and CountryType data) as commonly as UoM
> definitions and such.
>
> It all has to do with (cost of) maintaince. There are merits in
> concentration and in dispersement.
>
> Anyway, harmonization of GEO related data and entities will lead to less
> maintenance of data and functionalities. And coherent use of said
> functionality.
>
>
>
> Pierre Smits
>
> *ORRTIZ.COM <http://www.orrtiz.com>*
> Services & Solutions for Cloud-
> Based Manufacturing, Professional
> Services and Retail & Trade
> http://www.orrtiz.com
>

Re: svn commit: r1526296 - in /ofbiz/trunk/framework/common/data: CommonTypeData.xml GeoData.xml

Posted by Pierre Smits <pi...@gmail.com>.
I thought we were talking about the data and its location.

My reference to the document by David was merely to point out his view
point on what should go where can also be applied to the location of data
files. I regard GEO data (and CountryType data) as commonly as UoM
definitions and such.

It all has to do with (cost of) maintaince. There are merits in
concentration and in dispersement.

Anyway, harmonization of GEO related data and entities will lead to less
maintenance of data and functionalities. And coherent use of said
functionality.



Pierre Smits

*ORRTIZ.COM <http://www.orrtiz.com>*
Services & Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail & Trade
http://www.orrtiz.com

Re: svn commit: r1526296 - in /ofbiz/trunk/framework/common/data: CommonTypeData.xml GeoData.xml

Posted by Adrian Crum <ad...@sandglass-software.com>.
The same could be said for contact mechanisms. So why don't we put those 
in the framework too? Parties are used by many components, so those 
artifacts should be moved to the framework as well. Using that logic, I 
could make a case for putting most of the applications folder in the 
framework.

 From my perspective, the framework is a tool to write applications. 
Geographic information is an application, so it belongs in the 
applications folder. Of course, everyone has their own view of what a 
framework should be and what it should include, as we have discussed in 
the past (at great length). I'm sure there will disagreement in this 
discussion as well.

Adrian Crum
Sandglass Software
www.sandglass-software.com

On 9/26/2013 6:48 AM, Pierre Smits wrote:
> First of all, I don't object to the change.
>
> Secondly, the statement that it doesn't belong in the framework is a
> viewpoint that I find shortsighted. Though the use of GEO data is heavily
> focused around contact mechs, it is also - but not necessarily so here -
> used in relation to products (e.g. country of origin, country of
> provenance), contracts (e.g. applicability of terms) and more.
>
> I recall to have read a document by David (Jones) regarding placement of
> functionality and what I understood was that if functionality is used by
> more than one component it should move up to the higher level. Having this
> in framework sounds still right to me.
>
> Pierre Smits
>
> *ORRTIZ.COM <http://www.orrtiz.com>*
> Services & Solutions for Cloud-
> Based Manufacturing, Professional
> Services and Retail & Trade
> http://www.orrtiz.com
>
>
> On Thu, Sep 26, 2013 at 3:29 PM, Adrian Crum <
> adrian.crum@sandglass-software.com> wrote:
>
>> I agree there is a lot of overlap in the data and in the geo data model.
>>
>> The Geo data model is a denormalized, disorganized mess. That was the
>> reason for my changes - so I can comment all of it out and replace it with
>> a better model on my local copy.
>>
>> Yes, it needs to be fixed - but there seems to be a problem finding
>> agreement on what the model should look like.
>>
>> Conceptually, geo data is location data - just like contact mechanisms.
>>  From my perspective, the geo artifacts should be in the same component as
>> the contact mechanism artifacts. It doesn't belong in the framework.
>>
>> Adrian Crum
>> Sandglass Software
>> www.sandglass-software.com
>>
>>
>> On 9/26/2013 12:33 AM, Pierre Smits wrote:
>>
>>> It seems that there is a significant overlap between the data in
>>> CountryCodeData.xml and GeoData.xml.
>>>
>>> Would it not - in the spirit of slimdown - wise to merge the two sets (and
>>> possible others related to Country and GEO data)?
>>>
>>> Regards,
>>>
>>> Pierre Smits
>>>
>>> *ORRTIZ.COM <http://www.orrtiz.com>*
>>>
>>> Services & Solutions for Cloud-
>>> Based Manufacturing, Professional
>>> Services and Retail & Trade
>>> http://www.orrtiz.com
>>>
>>>
>>> On Wed, Sep 25, 2013 at 10:46 PM, <ad...@apache.org> wrote:
>>>
>>>   Author: adrianc
>>>> Date: Wed Sep 25 20:46:40 2013
>>>> New Revision: 1526296
>>>>
>>>> URL: http://svn.apache.org/r1526296
>>>> Log:
>>>> Move geo-related seed data to the GeoData.xml file. No functional change.
>>>>
>>>> Modified:
>>>>       ofbiz/trunk/framework/common/**data/CommonTypeData.xml
>>>>       ofbiz/trunk/framework/common/**data/GeoData.xml
>>>>
>>>> Modified: ofbiz/trunk/framework/common/**data/CommonTypeData.xml
>>>> URL:
>>>> http://svn.apache.org/viewvc/**ofbiz/trunk/framework/common/**
>>>> data/CommonTypeData.xml?rev=**1526296&r1=1526295&r2=1526296&**view=diff<http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/data/CommonTypeData.xml?rev=1526296&r1=1526295&r2=1526296&view=diff>
>>>>
>>>> ==============================**==============================**
>>>> ==================
>>>> --- ofbiz/trunk/framework/common/**data/CommonTypeData.xml (original)
>>>> +++ ofbiz/trunk/framework/common/**data/CommonTypeData.xml Wed Sep 25
>>>> 20:46:40 2013
>>>> @@ -64,26 +64,6 @@ under the License.
>>>>        <Enumeration description="Lang: Spanish" enumCode="LANG_SP"
>>>> enumId="KWTR_LANG_SP" sequenceId="21" enumTypeId="KW_THES_REL"/>
>>>>        <Enumeration description="Lang: French" enumCode="LANG_FR"
>>>> enumId="KWTR_LANG_FR" sequenceId="22" enumTypeId="KW_THES_REL"/>
>>>>
>>>> -    <GeoType description="City" geoTypeId="CITY" hasTable="N"
>>>> parentTypeId=""/>
>>>> -    <GeoType description="Group" geoTypeId="GROUP" hasTable="N"
>>>> parentTypeId=""/>
>>>> -    <GeoType description="State" geoTypeId="STATE" hasTable="N"
>>>> parentTypeId=""/>
>>>> -    <GeoType description="Postal Code" geoTypeId="POSTAL_CODE"
>>>> hasTable="N" parentTypeId=""/>
>>>> -    <GeoType description="Country" geoTypeId="COUNTRY" hasTable="N"
>>>> parentTypeId=""/>
>>>> -    <GeoType description="County" geoTypeId="COUNTY" hasTable="N"
>>>> parentTypeId=""/>
>>>> -    <GeoType description="County-City" geoTypeId="COUNTY_CITY"
>>>> hasTable="N" parentTypeId=""/>
>>>> -    <GeoType description="Municipality" geoTypeId="MUNICIPALITY"
>>>> hasTable="N" parentTypeId=""/>
>>>> -    <GeoType description="Province" geoTypeId="PROVINCE" hasTable="N"
>>>> parentTypeId=""/>
>>>> -    <GeoType description="Region" geoTypeId="REGION" hasTable="N"
>>>> parentTypeId=""/>
>>>> -    <GeoType description="Territory" geoTypeId="TERRITORY" hasTable="N"
>>>> parentTypeId=""/>
>>>> -    <GeoType description="Sales Territory" geoTypeId="SALES_TERRITORY"
>>>> hasTable="N" parentTypeId="TERRITORY"/>
>>>> -    <GeoType description="Service Territory"
>>>> geoTypeId="SERVICE_TERRITORY" hasTable="N" parentTypeId="TERRITORY"/>
>>>> -
>>>> -    <GeoAssocType geoAssocTypeId="GROUP_MEMBER" description="Geo Group
>>>> Member"/>
>>>> -    <GeoAssocType geoAssocTypeId="REGIONS" description="For a region of
>>>> a
>>>> larger Geo, i.e. states, counties, provinces..."/>
>>>> -    <GeoAssocType geoAssocTypeId="COUNTY_CITY" description="City in a
>>>> county"/>
>>>> -    <GeoAssocType geoAssocTypeId="COUNTY_SEAT"
>>>> description="Administrative Main City of a County"/>
>>>> -    <GeoAssocType geoAssocTypeId="POSTAL_CODE" description="Postal code
>>>> associated to a GeoType"/>
>>>> -
>>>>        <!-- sync status -->
>>>>        <StatusType description="Synchronize" hasTable="N" parentTypeId=""
>>>> statusTypeId="SYNCHRONIZE_**STATUS"/>
>>>>        <StatusItem description="Not-Synchronized" sequenceId="01"
>>>> statusCode="NOT_SYNCHRONIZED" statusId="NOT_SYNCHRONIZED"
>>>> statusTypeId="SYNCHRONIZE_**STATUS"/>
>>>>
>>>> Modified: ofbiz/trunk/framework/common/**data/GeoData.xml
>>>> URL:
>>>> http://svn.apache.org/viewvc/**ofbiz/trunk/framework/common/**
>>>> data/GeoData.xml?rev=1526296&**r1=1526295&r2=1526296&view=**diff<http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/data/GeoData.xml?rev=1526296&r1=1526295&r2=1526296&view=diff>
>>>>
>>>> ==============================**==============================**
>>>> ==================
>>>> --- ofbiz/trunk/framework/common/**data/GeoData.xml (original)
>>>> +++ ofbiz/trunk/framework/common/**data/GeoData.xml Wed Sep 25 20:46:40
>>>> 2013
>>>> @@ -19,6 +19,27 @@ under the License.
>>>>    -->
>>>>
>>>>    <entity-engine-xml>
>>>> +
>>>> +    <GeoType description="City" geoTypeId="CITY" hasTable="N"
>>>> parentTypeId=""/>
>>>> +    <GeoType description="Group" geoTypeId="GROUP" hasTable="N"
>>>> parentTypeId=""/>
>>>> +    <GeoType description="State" geoTypeId="STATE" hasTable="N"
>>>> parentTypeId=""/>
>>>> +    <GeoType description="Postal Code" geoTypeId="POSTAL_CODE"
>>>> hasTable="N" parentTypeId=""/>
>>>> +    <GeoType description="Country" geoTypeId="COUNTRY" hasTable="N"
>>>> parentTypeId=""/>
>>>> +    <GeoType description="County" geoTypeId="COUNTY" hasTable="N"
>>>> parentTypeId=""/>
>>>> +    <GeoType description="County-City" geoTypeId="COUNTY_CITY"
>>>> hasTable="N" parentTypeId=""/>
>>>> +    <GeoType description="Municipality" geoTypeId="MUNICIPALITY"
>>>> hasTable="N" parentTypeId=""/>
>>>> +    <GeoType description="Province" geoTypeId="PROVINCE" hasTable="N"
>>>> parentTypeId=""/>
>>>> +    <GeoType description="Region" geoTypeId="REGION" hasTable="N"
>>>> parentTypeId=""/>
>>>> +    <GeoType description="Territory" geoTypeId="TERRITORY" hasTable="N"
>>>> parentTypeId=""/>
>>>> +    <GeoType description="Sales Territory" geoTypeId="SALES_TERRITORY"
>>>> hasTable="N" parentTypeId="TERRITORY"/>
>>>> +    <GeoType description="Service Territory"
>>>> geoTypeId="SERVICE_TERRITORY" hasTable="N" parentTypeId="TERRITORY"/>
>>>> +
>>>> +    <GeoAssocType geoAssocTypeId="GROUP_MEMBER" description="Geo Group
>>>> Member"/>
>>>> +    <GeoAssocType geoAssocTypeId="REGIONS" description="For a region of
>>>> a
>>>> larger Geo, i.e. states, counties, provinces..."/>
>>>> +    <GeoAssocType geoAssocTypeId="COUNTY_CITY" description="City in a
>>>> county"/>
>>>> +    <GeoAssocType geoAssocTypeId="COUNTY_SEAT"
>>>> description="Administrative Main City of a County"/>
>>>> +    <GeoAssocType geoAssocTypeId="POSTAL_CODE" description="Postal code
>>>> associated to a GeoType"/>
>>>> +
>>>>        <!--
>>>>            Based on: ISO 3166  https://www.iso.org/obp/ui/#**search<https://www.iso.org/obp/ui/#search>
>>>>                      and
>>>> http://www.iso.org/iso/home/**standards/country_codes/**
>>>> country_names_and_code_**elements.htm<http://www.iso.org/iso/home/standards/country_codes/country_names_and_code_elements.htm>
>>>> .
>>>>
>>>>
>>>>
>>>>
>>>
>

Re: svn commit: r1526296 - in /ofbiz/trunk/framework/common/data: CommonTypeData.xml GeoData.xml

Posted by Pierre Smits <pi...@gmail.com>.
First of all, I don't object to the change.

Secondly, the statement that it doesn't belong in the framework is a
viewpoint that I find shortsighted. Though the use of GEO data is heavily
focused around contact mechs, it is also - but not necessarily so here -
used in relation to products (e.g. country of origin, country of
provenance), contracts (e.g. applicability of terms) and more.

I recall to have read a document by David (Jones) regarding placement of
functionality and what I understood was that if functionality is used by
more than one component it should move up to the higher level. Having this
in framework sounds still right to me.

Pierre Smits

*ORRTIZ.COM <http://www.orrtiz.com>*
Services & Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail & Trade
http://www.orrtiz.com


On Thu, Sep 26, 2013 at 3:29 PM, Adrian Crum <
adrian.crum@sandglass-software.com> wrote:

> I agree there is a lot of overlap in the data and in the geo data model.
>
> The Geo data model is a denormalized, disorganized mess. That was the
> reason for my changes - so I can comment all of it out and replace it with
> a better model on my local copy.
>
> Yes, it needs to be fixed - but there seems to be a problem finding
> agreement on what the model should look like.
>
> Conceptually, geo data is location data - just like contact mechanisms.
> From my perspective, the geo artifacts should be in the same component as
> the contact mechanism artifacts. It doesn't belong in the framework.
>
> Adrian Crum
> Sandglass Software
> www.sandglass-software.com
>
>
> On 9/26/2013 12:33 AM, Pierre Smits wrote:
>
>> It seems that there is a significant overlap between the data in
>> CountryCodeData.xml and GeoData.xml.
>>
>> Would it not - in the spirit of slimdown - wise to merge the two sets (and
>> possible others related to Country and GEO data)?
>>
>> Regards,
>>
>> Pierre Smits
>>
>> *ORRTIZ.COM <http://www.orrtiz.com>*
>>
>> Services & Solutions for Cloud-
>> Based Manufacturing, Professional
>> Services and Retail & Trade
>> http://www.orrtiz.com
>>
>>
>> On Wed, Sep 25, 2013 at 10:46 PM, <ad...@apache.org> wrote:
>>
>>  Author: adrianc
>>> Date: Wed Sep 25 20:46:40 2013
>>> New Revision: 1526296
>>>
>>> URL: http://svn.apache.org/r1526296
>>> Log:
>>> Move geo-related seed data to the GeoData.xml file. No functional change.
>>>
>>> Modified:
>>>      ofbiz/trunk/framework/common/**data/CommonTypeData.xml
>>>      ofbiz/trunk/framework/common/**data/GeoData.xml
>>>
>>> Modified: ofbiz/trunk/framework/common/**data/CommonTypeData.xml
>>> URL:
>>> http://svn.apache.org/viewvc/**ofbiz/trunk/framework/common/**
>>> data/CommonTypeData.xml?rev=**1526296&r1=1526295&r2=1526296&**view=diff<http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/data/CommonTypeData.xml?rev=1526296&r1=1526295&r2=1526296&view=diff>
>>>
>>> ==============================**==============================**
>>> ==================
>>> --- ofbiz/trunk/framework/common/**data/CommonTypeData.xml (original)
>>> +++ ofbiz/trunk/framework/common/**data/CommonTypeData.xml Wed Sep 25
>>> 20:46:40 2013
>>> @@ -64,26 +64,6 @@ under the License.
>>>       <Enumeration description="Lang: Spanish" enumCode="LANG_SP"
>>> enumId="KWTR_LANG_SP" sequenceId="21" enumTypeId="KW_THES_REL"/>
>>>       <Enumeration description="Lang: French" enumCode="LANG_FR"
>>> enumId="KWTR_LANG_FR" sequenceId="22" enumTypeId="KW_THES_REL"/>
>>>
>>> -    <GeoType description="City" geoTypeId="CITY" hasTable="N"
>>> parentTypeId=""/>
>>> -    <GeoType description="Group" geoTypeId="GROUP" hasTable="N"
>>> parentTypeId=""/>
>>> -    <GeoType description="State" geoTypeId="STATE" hasTable="N"
>>> parentTypeId=""/>
>>> -    <GeoType description="Postal Code" geoTypeId="POSTAL_CODE"
>>> hasTable="N" parentTypeId=""/>
>>> -    <GeoType description="Country" geoTypeId="COUNTRY" hasTable="N"
>>> parentTypeId=""/>
>>> -    <GeoType description="County" geoTypeId="COUNTY" hasTable="N"
>>> parentTypeId=""/>
>>> -    <GeoType description="County-City" geoTypeId="COUNTY_CITY"
>>> hasTable="N" parentTypeId=""/>
>>> -    <GeoType description="Municipality" geoTypeId="MUNICIPALITY"
>>> hasTable="N" parentTypeId=""/>
>>> -    <GeoType description="Province" geoTypeId="PROVINCE" hasTable="N"
>>> parentTypeId=""/>
>>> -    <GeoType description="Region" geoTypeId="REGION" hasTable="N"
>>> parentTypeId=""/>
>>> -    <GeoType description="Territory" geoTypeId="TERRITORY" hasTable="N"
>>> parentTypeId=""/>
>>> -    <GeoType description="Sales Territory" geoTypeId="SALES_TERRITORY"
>>> hasTable="N" parentTypeId="TERRITORY"/>
>>> -    <GeoType description="Service Territory"
>>> geoTypeId="SERVICE_TERRITORY" hasTable="N" parentTypeId="TERRITORY"/>
>>> -
>>> -    <GeoAssocType geoAssocTypeId="GROUP_MEMBER" description="Geo Group
>>> Member"/>
>>> -    <GeoAssocType geoAssocTypeId="REGIONS" description="For a region of
>>> a
>>> larger Geo, i.e. states, counties, provinces..."/>
>>> -    <GeoAssocType geoAssocTypeId="COUNTY_CITY" description="City in a
>>> county"/>
>>> -    <GeoAssocType geoAssocTypeId="COUNTY_SEAT"
>>> description="Administrative Main City of a County"/>
>>> -    <GeoAssocType geoAssocTypeId="POSTAL_CODE" description="Postal code
>>> associated to a GeoType"/>
>>> -
>>>       <!-- sync status -->
>>>       <StatusType description="Synchronize" hasTable="N" parentTypeId=""
>>> statusTypeId="SYNCHRONIZE_**STATUS"/>
>>>       <StatusItem description="Not-Synchronized" sequenceId="01"
>>> statusCode="NOT_SYNCHRONIZED" statusId="NOT_SYNCHRONIZED"
>>> statusTypeId="SYNCHRONIZE_**STATUS"/>
>>>
>>> Modified: ofbiz/trunk/framework/common/**data/GeoData.xml
>>> URL:
>>> http://svn.apache.org/viewvc/**ofbiz/trunk/framework/common/**
>>> data/GeoData.xml?rev=1526296&**r1=1526295&r2=1526296&view=**diff<http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/data/GeoData.xml?rev=1526296&r1=1526295&r2=1526296&view=diff>
>>>
>>> ==============================**==============================**
>>> ==================
>>> --- ofbiz/trunk/framework/common/**data/GeoData.xml (original)
>>> +++ ofbiz/trunk/framework/common/**data/GeoData.xml Wed Sep 25 20:46:40
>>> 2013
>>> @@ -19,6 +19,27 @@ under the License.
>>>   -->
>>>
>>>   <entity-engine-xml>
>>> +
>>> +    <GeoType description="City" geoTypeId="CITY" hasTable="N"
>>> parentTypeId=""/>
>>> +    <GeoType description="Group" geoTypeId="GROUP" hasTable="N"
>>> parentTypeId=""/>
>>> +    <GeoType description="State" geoTypeId="STATE" hasTable="N"
>>> parentTypeId=""/>
>>> +    <GeoType description="Postal Code" geoTypeId="POSTAL_CODE"
>>> hasTable="N" parentTypeId=""/>
>>> +    <GeoType description="Country" geoTypeId="COUNTRY" hasTable="N"
>>> parentTypeId=""/>
>>> +    <GeoType description="County" geoTypeId="COUNTY" hasTable="N"
>>> parentTypeId=""/>
>>> +    <GeoType description="County-City" geoTypeId="COUNTY_CITY"
>>> hasTable="N" parentTypeId=""/>
>>> +    <GeoType description="Municipality" geoTypeId="MUNICIPALITY"
>>> hasTable="N" parentTypeId=""/>
>>> +    <GeoType description="Province" geoTypeId="PROVINCE" hasTable="N"
>>> parentTypeId=""/>
>>> +    <GeoType description="Region" geoTypeId="REGION" hasTable="N"
>>> parentTypeId=""/>
>>> +    <GeoType description="Territory" geoTypeId="TERRITORY" hasTable="N"
>>> parentTypeId=""/>
>>> +    <GeoType description="Sales Territory" geoTypeId="SALES_TERRITORY"
>>> hasTable="N" parentTypeId="TERRITORY"/>
>>> +    <GeoType description="Service Territory"
>>> geoTypeId="SERVICE_TERRITORY" hasTable="N" parentTypeId="TERRITORY"/>
>>> +
>>> +    <GeoAssocType geoAssocTypeId="GROUP_MEMBER" description="Geo Group
>>> Member"/>
>>> +    <GeoAssocType geoAssocTypeId="REGIONS" description="For a region of
>>> a
>>> larger Geo, i.e. states, counties, provinces..."/>
>>> +    <GeoAssocType geoAssocTypeId="COUNTY_CITY" description="City in a
>>> county"/>
>>> +    <GeoAssocType geoAssocTypeId="COUNTY_SEAT"
>>> description="Administrative Main City of a County"/>
>>> +    <GeoAssocType geoAssocTypeId="POSTAL_CODE" description="Postal code
>>> associated to a GeoType"/>
>>> +
>>>       <!--
>>>           Based on: ISO 3166  https://www.iso.org/obp/ui/#**search<https://www.iso.org/obp/ui/#search>
>>>                     and
>>> http://www.iso.org/iso/home/**standards/country_codes/**
>>> country_names_and_code_**elements.htm<http://www.iso.org/iso/home/standards/country_codes/country_names_and_code_elements.htm>
>>> .
>>>
>>>
>>>
>>>
>>

Re: svn commit: r1526296 - in /ofbiz/trunk/framework/common/data: CommonTypeData.xml GeoData.xml

Posted by Jacopo Cappellato <ja...@hotwaxmedia.com>.
On Sep 26, 2013, at 3:29 PM, Adrian Crum <ad...@sandglass-software.com> wrote:

> Conceptually, geo data is location data - just like contact mechanisms. From my perspective, the geo artifacts should be in the same component as the contact mechanism artifacts. It doesn't belong in the framework.

applications/commonext may be a good candidate component for these artifacts.

Jacopo


Re: svn commit: r1526296 - in /ofbiz/trunk/framework/common/data: CommonTypeData.xml GeoData.xml

Posted by Adrian Crum <ad...@sandglass-software.com>.
I agree there is a lot of overlap in the data and in the geo data model.

The Geo data model is a denormalized, disorganized mess. That was the 
reason for my changes - so I can comment all of it out and replace it 
with a better model on my local copy.

Yes, it needs to be fixed - but there seems to be a problem finding 
agreement on what the model should look like.

Conceptually, geo data is location data - just like contact mechanisms. 
 From my perspective, the geo artifacts should be in the same component 
as the contact mechanism artifacts. It doesn't belong in the framework.

Adrian Crum
Sandglass Software
www.sandglass-software.com

On 9/26/2013 12:33 AM, Pierre Smits wrote:
> It seems that there is a significant overlap between the data in
> CountryCodeData.xml and GeoData.xml.
>
> Would it not - in the spirit of slimdown - wise to merge the two sets (and
> possible others related to Country and GEO data)?
>
> Regards,
>
> Pierre Smits
>
> *ORRTIZ.COM <http://www.orrtiz.com>*
> Services & Solutions for Cloud-
> Based Manufacturing, Professional
> Services and Retail & Trade
> http://www.orrtiz.com
>
>
> On Wed, Sep 25, 2013 at 10:46 PM, <ad...@apache.org> wrote:
>
>> Author: adrianc
>> Date: Wed Sep 25 20:46:40 2013
>> New Revision: 1526296
>>
>> URL: http://svn.apache.org/r1526296
>> Log:
>> Move geo-related seed data to the GeoData.xml file. No functional change.
>>
>> Modified:
>>      ofbiz/trunk/framework/common/data/CommonTypeData.xml
>>      ofbiz/trunk/framework/common/data/GeoData.xml
>>
>> Modified: ofbiz/trunk/framework/common/data/CommonTypeData.xml
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/data/CommonTypeData.xml?rev=1526296&r1=1526295&r2=1526296&view=diff
>>
>> ==============================================================================
>> --- ofbiz/trunk/framework/common/data/CommonTypeData.xml (original)
>> +++ ofbiz/trunk/framework/common/data/CommonTypeData.xml Wed Sep 25
>> 20:46:40 2013
>> @@ -64,26 +64,6 @@ under the License.
>>       <Enumeration description="Lang: Spanish" enumCode="LANG_SP"
>> enumId="KWTR_LANG_SP" sequenceId="21" enumTypeId="KW_THES_REL"/>
>>       <Enumeration description="Lang: French" enumCode="LANG_FR"
>> enumId="KWTR_LANG_FR" sequenceId="22" enumTypeId="KW_THES_REL"/>
>>
>> -    <GeoType description="City" geoTypeId="CITY" hasTable="N"
>> parentTypeId=""/>
>> -    <GeoType description="Group" geoTypeId="GROUP" hasTable="N"
>> parentTypeId=""/>
>> -    <GeoType description="State" geoTypeId="STATE" hasTable="N"
>> parentTypeId=""/>
>> -    <GeoType description="Postal Code" geoTypeId="POSTAL_CODE"
>> hasTable="N" parentTypeId=""/>
>> -    <GeoType description="Country" geoTypeId="COUNTRY" hasTable="N"
>> parentTypeId=""/>
>> -    <GeoType description="County" geoTypeId="COUNTY" hasTable="N"
>> parentTypeId=""/>
>> -    <GeoType description="County-City" geoTypeId="COUNTY_CITY"
>> hasTable="N" parentTypeId=""/>
>> -    <GeoType description="Municipality" geoTypeId="MUNICIPALITY"
>> hasTable="N" parentTypeId=""/>
>> -    <GeoType description="Province" geoTypeId="PROVINCE" hasTable="N"
>> parentTypeId=""/>
>> -    <GeoType description="Region" geoTypeId="REGION" hasTable="N"
>> parentTypeId=""/>
>> -    <GeoType description="Territory" geoTypeId="TERRITORY" hasTable="N"
>> parentTypeId=""/>
>> -    <GeoType description="Sales Territory" geoTypeId="SALES_TERRITORY"
>> hasTable="N" parentTypeId="TERRITORY"/>
>> -    <GeoType description="Service Territory"
>> geoTypeId="SERVICE_TERRITORY" hasTable="N" parentTypeId="TERRITORY"/>
>> -
>> -    <GeoAssocType geoAssocTypeId="GROUP_MEMBER" description="Geo Group
>> Member"/>
>> -    <GeoAssocType geoAssocTypeId="REGIONS" description="For a region of a
>> larger Geo, i.e. states, counties, provinces..."/>
>> -    <GeoAssocType geoAssocTypeId="COUNTY_CITY" description="City in a
>> county"/>
>> -    <GeoAssocType geoAssocTypeId="COUNTY_SEAT"
>> description="Administrative Main City of a County"/>
>> -    <GeoAssocType geoAssocTypeId="POSTAL_CODE" description="Postal code
>> associated to a GeoType"/>
>> -
>>       <!-- sync status -->
>>       <StatusType description="Synchronize" hasTable="N" parentTypeId=""
>> statusTypeId="SYNCHRONIZE_STATUS"/>
>>       <StatusItem description="Not-Synchronized" sequenceId="01"
>> statusCode="NOT_SYNCHRONIZED" statusId="NOT_SYNCHRONIZED"
>> statusTypeId="SYNCHRONIZE_STATUS"/>
>>
>> Modified: ofbiz/trunk/framework/common/data/GeoData.xml
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/data/GeoData.xml?rev=1526296&r1=1526295&r2=1526296&view=diff
>>
>> ==============================================================================
>> --- ofbiz/trunk/framework/common/data/GeoData.xml (original)
>> +++ ofbiz/trunk/framework/common/data/GeoData.xml Wed Sep 25 20:46:40 2013
>> @@ -19,6 +19,27 @@ under the License.
>>   -->
>>
>>   <entity-engine-xml>
>> +
>> +    <GeoType description="City" geoTypeId="CITY" hasTable="N"
>> parentTypeId=""/>
>> +    <GeoType description="Group" geoTypeId="GROUP" hasTable="N"
>> parentTypeId=""/>
>> +    <GeoType description="State" geoTypeId="STATE" hasTable="N"
>> parentTypeId=""/>
>> +    <GeoType description="Postal Code" geoTypeId="POSTAL_CODE"
>> hasTable="N" parentTypeId=""/>
>> +    <GeoType description="Country" geoTypeId="COUNTRY" hasTable="N"
>> parentTypeId=""/>
>> +    <GeoType description="County" geoTypeId="COUNTY" hasTable="N"
>> parentTypeId=""/>
>> +    <GeoType description="County-City" geoTypeId="COUNTY_CITY"
>> hasTable="N" parentTypeId=""/>
>> +    <GeoType description="Municipality" geoTypeId="MUNICIPALITY"
>> hasTable="N" parentTypeId=""/>
>> +    <GeoType description="Province" geoTypeId="PROVINCE" hasTable="N"
>> parentTypeId=""/>
>> +    <GeoType description="Region" geoTypeId="REGION" hasTable="N"
>> parentTypeId=""/>
>> +    <GeoType description="Territory" geoTypeId="TERRITORY" hasTable="N"
>> parentTypeId=""/>
>> +    <GeoType description="Sales Territory" geoTypeId="SALES_TERRITORY"
>> hasTable="N" parentTypeId="TERRITORY"/>
>> +    <GeoType description="Service Territory"
>> geoTypeId="SERVICE_TERRITORY" hasTable="N" parentTypeId="TERRITORY"/>
>> +
>> +    <GeoAssocType geoAssocTypeId="GROUP_MEMBER" description="Geo Group
>> Member"/>
>> +    <GeoAssocType geoAssocTypeId="REGIONS" description="For a region of a
>> larger Geo, i.e. states, counties, provinces..."/>
>> +    <GeoAssocType geoAssocTypeId="COUNTY_CITY" description="City in a
>> county"/>
>> +    <GeoAssocType geoAssocTypeId="COUNTY_SEAT"
>> description="Administrative Main City of a County"/>
>> +    <GeoAssocType geoAssocTypeId="POSTAL_CODE" description="Postal code
>> associated to a GeoType"/>
>> +
>>       <!--
>>           Based on: ISO 3166  https://www.iso.org/obp/ui/#search
>>                     and
>> http://www.iso.org/iso/home/standards/country_codes/country_names_and_code_elements.htm
>> .
>>
>>
>>
>

Re: svn commit: r1526296 - in /ofbiz/trunk/framework/common/data: CommonTypeData.xml GeoData.xml

Posted by Pierre Smits <pi...@gmail.com>.
It seems that there is a significant overlap between the data in
CountryCodeData.xml and GeoData.xml.

Would it not - in the spirit of slimdown - wise to merge the two sets (and
possible others related to Country and GEO data)?

Regards,

Pierre Smits

*ORRTIZ.COM <http://www.orrtiz.com>*
Services & Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail & Trade
http://www.orrtiz.com


On Wed, Sep 25, 2013 at 10:46 PM, <ad...@apache.org> wrote:

> Author: adrianc
> Date: Wed Sep 25 20:46:40 2013
> New Revision: 1526296
>
> URL: http://svn.apache.org/r1526296
> Log:
> Move geo-related seed data to the GeoData.xml file. No functional change.
>
> Modified:
>     ofbiz/trunk/framework/common/data/CommonTypeData.xml
>     ofbiz/trunk/framework/common/data/GeoData.xml
>
> Modified: ofbiz/trunk/framework/common/data/CommonTypeData.xml
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/data/CommonTypeData.xml?rev=1526296&r1=1526295&r2=1526296&view=diff
>
> ==============================================================================
> --- ofbiz/trunk/framework/common/data/CommonTypeData.xml (original)
> +++ ofbiz/trunk/framework/common/data/CommonTypeData.xml Wed Sep 25
> 20:46:40 2013
> @@ -64,26 +64,6 @@ under the License.
>      <Enumeration description="Lang: Spanish" enumCode="LANG_SP"
> enumId="KWTR_LANG_SP" sequenceId="21" enumTypeId="KW_THES_REL"/>
>      <Enumeration description="Lang: French" enumCode="LANG_FR"
> enumId="KWTR_LANG_FR" sequenceId="22" enumTypeId="KW_THES_REL"/>
>
> -    <GeoType description="City" geoTypeId="CITY" hasTable="N"
> parentTypeId=""/>
> -    <GeoType description="Group" geoTypeId="GROUP" hasTable="N"
> parentTypeId=""/>
> -    <GeoType description="State" geoTypeId="STATE" hasTable="N"
> parentTypeId=""/>
> -    <GeoType description="Postal Code" geoTypeId="POSTAL_CODE"
> hasTable="N" parentTypeId=""/>
> -    <GeoType description="Country" geoTypeId="COUNTRY" hasTable="N"
> parentTypeId=""/>
> -    <GeoType description="County" geoTypeId="COUNTY" hasTable="N"
> parentTypeId=""/>
> -    <GeoType description="County-City" geoTypeId="COUNTY_CITY"
> hasTable="N" parentTypeId=""/>
> -    <GeoType description="Municipality" geoTypeId="MUNICIPALITY"
> hasTable="N" parentTypeId=""/>
> -    <GeoType description="Province" geoTypeId="PROVINCE" hasTable="N"
> parentTypeId=""/>
> -    <GeoType description="Region" geoTypeId="REGION" hasTable="N"
> parentTypeId=""/>
> -    <GeoType description="Territory" geoTypeId="TERRITORY" hasTable="N"
> parentTypeId=""/>
> -    <GeoType description="Sales Territory" geoTypeId="SALES_TERRITORY"
> hasTable="N" parentTypeId="TERRITORY"/>
> -    <GeoType description="Service Territory"
> geoTypeId="SERVICE_TERRITORY" hasTable="N" parentTypeId="TERRITORY"/>
> -
> -    <GeoAssocType geoAssocTypeId="GROUP_MEMBER" description="Geo Group
> Member"/>
> -    <GeoAssocType geoAssocTypeId="REGIONS" description="For a region of a
> larger Geo, i.e. states, counties, provinces..."/>
> -    <GeoAssocType geoAssocTypeId="COUNTY_CITY" description="City in a
> county"/>
> -    <GeoAssocType geoAssocTypeId="COUNTY_SEAT"
> description="Administrative Main City of a County"/>
> -    <GeoAssocType geoAssocTypeId="POSTAL_CODE" description="Postal code
> associated to a GeoType"/>
> -
>      <!-- sync status -->
>      <StatusType description="Synchronize" hasTable="N" parentTypeId=""
> statusTypeId="SYNCHRONIZE_STATUS"/>
>      <StatusItem description="Not-Synchronized" sequenceId="01"
> statusCode="NOT_SYNCHRONIZED" statusId="NOT_SYNCHRONIZED"
> statusTypeId="SYNCHRONIZE_STATUS"/>
>
> Modified: ofbiz/trunk/framework/common/data/GeoData.xml
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/data/GeoData.xml?rev=1526296&r1=1526295&r2=1526296&view=diff
>
> ==============================================================================
> --- ofbiz/trunk/framework/common/data/GeoData.xml (original)
> +++ ofbiz/trunk/framework/common/data/GeoData.xml Wed Sep 25 20:46:40 2013
> @@ -19,6 +19,27 @@ under the License.
>  -->
>
>  <entity-engine-xml>
> +
> +    <GeoType description="City" geoTypeId="CITY" hasTable="N"
> parentTypeId=""/>
> +    <GeoType description="Group" geoTypeId="GROUP" hasTable="N"
> parentTypeId=""/>
> +    <GeoType description="State" geoTypeId="STATE" hasTable="N"
> parentTypeId=""/>
> +    <GeoType description="Postal Code" geoTypeId="POSTAL_CODE"
> hasTable="N" parentTypeId=""/>
> +    <GeoType description="Country" geoTypeId="COUNTRY" hasTable="N"
> parentTypeId=""/>
> +    <GeoType description="County" geoTypeId="COUNTY" hasTable="N"
> parentTypeId=""/>
> +    <GeoType description="County-City" geoTypeId="COUNTY_CITY"
> hasTable="N" parentTypeId=""/>
> +    <GeoType description="Municipality" geoTypeId="MUNICIPALITY"
> hasTable="N" parentTypeId=""/>
> +    <GeoType description="Province" geoTypeId="PROVINCE" hasTable="N"
> parentTypeId=""/>
> +    <GeoType description="Region" geoTypeId="REGION" hasTable="N"
> parentTypeId=""/>
> +    <GeoType description="Territory" geoTypeId="TERRITORY" hasTable="N"
> parentTypeId=""/>
> +    <GeoType description="Sales Territory" geoTypeId="SALES_TERRITORY"
> hasTable="N" parentTypeId="TERRITORY"/>
> +    <GeoType description="Service Territory"
> geoTypeId="SERVICE_TERRITORY" hasTable="N" parentTypeId="TERRITORY"/>
> +
> +    <GeoAssocType geoAssocTypeId="GROUP_MEMBER" description="Geo Group
> Member"/>
> +    <GeoAssocType geoAssocTypeId="REGIONS" description="For a region of a
> larger Geo, i.e. states, counties, provinces..."/>
> +    <GeoAssocType geoAssocTypeId="COUNTY_CITY" description="City in a
> county"/>
> +    <GeoAssocType geoAssocTypeId="COUNTY_SEAT"
> description="Administrative Main City of a County"/>
> +    <GeoAssocType geoAssocTypeId="POSTAL_CODE" description="Postal code
> associated to a GeoType"/>
> +
>      <!--
>          Based on: ISO 3166  https://www.iso.org/obp/ui/#search
>                    and
> http://www.iso.org/iso/home/standards/country_codes/country_names_and_code_elements.htm
> .
>
>
>