You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "snuyanzin (via GitHub)" <gi...@apache.org> on 2024/01/18 22:05:04 UTC
[PR] [hotfix] Add jakarta.activation required after changes in Flink main repo [flink-connector-jdbc]
snuyanzin opened a new pull request, #93:
URL: https://github.com/apache/flink-connector-jdbc/pull/93
The reason is this line https://github.com/apache/flink/blame/a41229b24d82e8c561350c42d8a98dfb865c3f69/flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/netty/TestingTierConsumerAgent.java#L28
added within https://github.com/apache/flink/pull/23927
now we need to have this dependency for tests to continue build it with jdk17+
P.S. to reproduce problem locally
```
mvn clean install -Dflink.version=1.19-SNAPSHOT
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] Add jakarta.activation required after changes in Flink main repo [flink-connector-jdbc]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on PR #93:
URL: https://github.com/apache/flink-connector-jdbc/pull/93#issuecomment-1912104156
closing since the issue was fixed in upstream
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] Add jakarta.activation required after changes in Flink main repo [flink-connector-jdbc]
Posted by "BlackPigHe (via GitHub)" <gi...@apache.org>.
BlackPigHe commented on PR #93:
URL: https://github.com/apache/flink-connector-jdbc/pull/93#issuecomment-1899867428
I also found this problem, and found that the work flow kept failing when mr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] Add jakarta.activation required after changes in Flink main repo [flink-connector-jdbc]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on PR #93:
URL: https://github.com/apache/flink-connector-jdbc/pull/93#issuecomment-1899894520
@BlackPigHe i didn't get your comment
have you seen the changes proposed within this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] Add jakarta.activation required after changes in Flink main repo [flink-connector-jdbc]
Posted by "BlackPigHe (via GitHub)" <gi...@apache.org>.
BlackPigHe commented on PR #93:
URL: https://github.com/apache/flink-connector-jdbc/pull/93#issuecomment-1899866113
<!-- For dependency jdk21 lost package -->
<dependency>
<groupId>javax.activation</groupId>
<artifactId>activation</artifactId>
<version>1.1.1</version>
<scope>test</scope>
</dependency>
增加这个包就可以啦
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] Add jakarta.activation required after changes in Flink main repo [flink-connector-jdbc]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin closed pull request #93: [hotfix] Add jakarta.activation required after changes in Flink main repo
URL: https://github.com/apache/flink-connector-jdbc/pull/93
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] Add jakarta.activation required after changes in Flink main repo [flink-connector-jdbc]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on PR #93:
URL: https://github.com/apache/flink-connector-jdbc/pull/93#issuecomment-1899938305
Thanks, for having a look
however i'm now wondering whether we can just wait and close it later since it's going to be fixed in Flink itself
https://github.com/apache/flink/pull/24147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org