[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #2015: add profile for segment v2

[GitBox <gi...@apache.org>]

kangpinghuang commented on a change in pull request #2015: add profile for segment v2
URL: https://github.com/apache/incubator-doris/pull/2015#discussion_r336826353
 
 

 ##########
 File path: be/src/olap/rowset/segment_v2/column_reader.cpp
 ##########
 @@ -196,20 +206,27 @@ void ColumnReader::_get_filtered_pages(CondColumn* cond_column,
                 max_value->set_null();
             }
         }
-        bool should_read = false;
         if (cond_column == nullptr || cond_column->eval({min_value.get(), max_value.get()})) {
-            should_read = true;
-        }
-        if (should_read) {
+            bool should_read = true;
             for (auto& col_cond : delete_conditions) {
                 if (col_cond->del_eval({min_value.get(), max_value.get()}) == DEL_SATISFIED) {
                     should_read = false;
+                    rowid_t page_first_id = _ordinal_index->get_first_row_id(i);
+                    rowid_t page_last_id = _ordinal_index->get_last_row_id(i);
+                    stats->rows_del_filtered =+ page_last_id - page_first_id + 1;
+                    LOG(INFO) << "delete index:" << i;
                     break;
                 }
             }
-        }
-        if (should_read) {
-            page_indexes->push_back(i);
+            if (should_read) {
+                page_indexes->push_back(i);
+            }
+            LOG(INFO) << "get index:" << i;
 
 Review comment:
   it is for debug, I will delete it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org