You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/01/29 06:54:32 UTC

[GitHub] [kafka] hachikuji commented on a change in pull request #10001: MINOR: AbstractCoordinatorTest should close coordinator explicitly

hachikuji commented on a change in pull request #10001:
URL: https://github.com/apache/kafka/pull/10001#discussion_r566613107



##########
File path: clients/src/test/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinatorTest.java
##########
@@ -102,6 +104,11 @@
     private final String leaderId = "leaderId";
     private final int defaultGeneration = -1;
 
+    @AfterEach
+    public void closeCoordinator() {
+        Utils.closeQuietly(coordinator, "close coordinator");

Review comment:
       While we're at it, shall we close `consumerClient`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org