[GitHub] [doris] wangshuo128 commented on a diff in pull request #13434: [feature](nereids) Support authentication

[GitBox <gi...@apache.org>]

wangshuo128 commented on code in PR #13434:
URL: https://github.com/apache/doris/pull/13434#discussion_r997804395


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/RuleType.java:
##########
@@ -51,6 +51,8 @@ public enum RuleType {
     RESOLVE_AGGREGATE_ALIAS(RuleTypeClass.REWRITE),
     PROJECT_TO_GLOBAL_AGGREGATE(RuleTypeClass.REWRITE),
 
+    RELATION_AUTHENTICATION(RuleTypeClass.CHECK),

Review Comment:
   To clearify: `RuleTypeClass.CHECK` was introduced by the unit test to compare the expected and actual plan. Maybe it's not a suitable name now. 
   I suggest distinguishing the type name between unit test plan check and plan checking in the analysis phase. :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org