You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Alexei Zakharov (JIRA)" <ji...@apache.org> on 2006/08/03 19:23:13 UTC
[jira] Created: (HARMONY-1061) [classlib][beans] tests from
ExpressionTest fail on RI
[classlib][beans] tests from ExpressionTest fail on RI
------------------------------------------------------
Key: HARMONY-1061
URL: http://issues.apache.org/jira/browse/HARMONY-1061
Project: Harmony
Issue Type: Improvement
Components: Classlib
Environment: winXP
Reporter: Alexei Zakharov
Attachments: ExpressionTest3.patch
Currently all tests from org.apache.harmony.beans.tests.java.beans.ExpressionTest pass on our implementation of beans. But I have realized that 9 of these tests still fail on RI. This happened because one of my previous patches for java.beans.Expression class (HARMONY-924) contained errors. The fix for the toString() method introduced by this patch was invalid indeed. I really sorry for that. The attached patch should resolve the situation. With this patch only one test fails on RI.
testConstructor_Normal
testConstructor_ArrayTarget
testConstructor_NewMethodName
testConstructor_NullArguments
testConstructor_NullArgument
testConstructor_Value_NullValue
toString() compatibility issues. I have updated the tests to let it follow the real RI format of toString(). I have also made some corrections to harmony code to reflect these changes in tests.
testGetValue_EqualSpecificMethods
testGetValue_EqualSpecificMethodsException
Commented out since they actually test the order of elements returned by Class.getMethods() / Class.getDeclaredMethods() (see HARMONY-953). Such order differs from VM to VM and this checking IMO should not be placed in tests for java.beans package.
testGetValue_UnboundedPrimitiveVSWrapper
I commented out one of ambiguous overloaded methods of MockObject since the result of the previous version of the test depended (again the same problem) on the order of elements returned by Class.getMethods()
testGetValue_UnboundedOverloadedConstructors
Currently fails on RI because RI violates the spec for Statement#execute() method. I didn't touch anything in this test, so it fails (as it did before).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-1061) [classlib][beans] tests from
ExpressionTest fail on RI
Posted by "Mikhail Loenko (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1061?page=all ]
Mikhail Loenko reassigned HARMONY-1061:
---------------------------------------
Assignee: Mikhail Loenko
> [classlib][beans] tests from ExpressionTest fail on RI
> ------------------------------------------------------
>
> Key: HARMONY-1061
> URL: http://issues.apache.org/jira/browse/HARMONY-1061
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Environment: winXP
> Reporter: Alexei Zakharov
> Assigned To: Mikhail Loenko
> Attachments: ExpressionTest3.patch
>
>
> Currently all tests from org.apache.harmony.beans.tests.java.beans.ExpressionTest pass on our implementation of beans. But I have realized that 9 of these tests still fail on RI. This happened because one of my previous patches for java.beans.Expression class (HARMONY-924) contained errors. The fix for the toString() method introduced by this patch was invalid indeed. I really sorry for that. The attached patch should resolve the situation. With this patch only one test fails on RI.
> testConstructor_Normal
> testConstructor_ArrayTarget
> testConstructor_NewMethodName
> testConstructor_NullArguments
> testConstructor_NullArgument
> testConstructor_Value_NullValue
> toString() compatibility issues. I have updated the tests to let it follow the real RI format of toString(). I have also made some corrections to harmony code to reflect these changes in tests.
> testGetValue_EqualSpecificMethods
> testGetValue_EqualSpecificMethodsException
> Commented out since they actually test the order of elements returned by Class.getMethods() / Class.getDeclaredMethods() (see HARMONY-953). Such order differs from VM to VM and this checking IMO should not be placed in tests for java.beans package.
> testGetValue_UnboundedPrimitiveVSWrapper
> I commented out one of ambiguous overloaded methods of MockObject since the result of the previous version of the test depended (again the same problem) on the order of elements returned by Class.getMethods()
> testGetValue_UnboundedOverloadedConstructors
> Currently fails on RI because RI violates the spec for Statement#execute() method. I didn't touch anything in this test, so it fails (as it did before).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-1061) [classlib][beans] tests from
ExpressionTest fail on RI
Posted by "Mikhail Loenko (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1061?page=all ]
Mikhail Loenko closed HARMONY-1061.
-----------------------------------
> [classlib][beans] tests from ExpressionTest fail on RI
> ------------------------------------------------------
>
> Key: HARMONY-1061
> URL: http://issues.apache.org/jira/browse/HARMONY-1061
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Environment: winXP
> Reporter: Alexei Zakharov
> Assigned To: Mikhail Loenko
> Attachments: ExpressionTest3.patch
>
>
> Currently all tests from org.apache.harmony.beans.tests.java.beans.ExpressionTest pass on our implementation of beans. But I have realized that 9 of these tests still fail on RI. This happened because one of my previous patches for java.beans.Expression class (HARMONY-924) contained errors. The fix for the toString() method introduced by this patch was invalid indeed. I really sorry for that. The attached patch should resolve the situation. With this patch only one test fails on RI.
> testConstructor_Normal
> testConstructor_ArrayTarget
> testConstructor_NewMethodName
> testConstructor_NullArguments
> testConstructor_NullArgument
> testConstructor_Value_NullValue
> toString() compatibility issues. I have updated the tests to let it follow the real RI format of toString(). I have also made some corrections to harmony code to reflect these changes in tests.
> testGetValue_EqualSpecificMethods
> testGetValue_EqualSpecificMethodsException
> Commented out since they actually test the order of elements returned by Class.getMethods() / Class.getDeclaredMethods() (see HARMONY-953). Such order differs from VM to VM and this checking IMO should not be placed in tests for java.beans package.
> testGetValue_UnboundedPrimitiveVSWrapper
> I commented out one of ambiguous overloaded methods of MockObject since the result of the previous version of the test depended (again the same problem) on the order of elements returned by Class.getMethods()
> testGetValue_UnboundedOverloadedConstructors
> Currently fails on RI because RI violates the spec for Statement#execute() method. I didn't touch anything in this test, so it fails (as it did before).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-1061) [classlib][beans] tests from
ExpressionTest fail on RI
Posted by "Mikhail Loenko (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1061?page=all ]
Mikhail Loenko resolved HARMONY-1061.
-------------------------------------
Resolution: Fixed
thanks for the patch!
applied in revision 428668
now it test passes on both Harmony and RI. Alexey, please confirm it's ok
> [classlib][beans] tests from ExpressionTest fail on RI
> ------------------------------------------------------
>
> Key: HARMONY-1061
> URL: http://issues.apache.org/jira/browse/HARMONY-1061
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Environment: winXP
> Reporter: Alexei Zakharov
> Assigned To: Mikhail Loenko
> Attachments: ExpressionTest3.patch
>
>
> Currently all tests from org.apache.harmony.beans.tests.java.beans.ExpressionTest pass on our implementation of beans. But I have realized that 9 of these tests still fail on RI. This happened because one of my previous patches for java.beans.Expression class (HARMONY-924) contained errors. The fix for the toString() method introduced by this patch was invalid indeed. I really sorry for that. The attached patch should resolve the situation. With this patch only one test fails on RI.
> testConstructor_Normal
> testConstructor_ArrayTarget
> testConstructor_NewMethodName
> testConstructor_NullArguments
> testConstructor_NullArgument
> testConstructor_Value_NullValue
> toString() compatibility issues. I have updated the tests to let it follow the real RI format of toString(). I have also made some corrections to harmony code to reflect these changes in tests.
> testGetValue_EqualSpecificMethods
> testGetValue_EqualSpecificMethodsException
> Commented out since they actually test the order of elements returned by Class.getMethods() / Class.getDeclaredMethods() (see HARMONY-953). Such order differs from VM to VM and this checking IMO should not be placed in tests for java.beans package.
> testGetValue_UnboundedPrimitiveVSWrapper
> I commented out one of ambiguous overloaded methods of MockObject since the result of the previous version of the test depended (again the same problem) on the order of elements returned by Class.getMethods()
> testGetValue_UnboundedOverloadedConstructors
> Currently fails on RI because RI violates the spec for Statement#execute() method. I didn't touch anything in this test, so it fails (as it did before).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1061) [classlib][beans] tests from
ExpressionTest fail on RI
Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1061?page=comments#action_12426265 ]
Alexei Zakharov commented on HARMONY-1061:
------------------------------------------
Mikhail, thanks! Everything is ok.
> [classlib][beans] tests from ExpressionTest fail on RI
> ------------------------------------------------------
>
> Key: HARMONY-1061
> URL: http://issues.apache.org/jira/browse/HARMONY-1061
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Environment: winXP
> Reporter: Alexei Zakharov
> Assigned To: Mikhail Loenko
> Attachments: ExpressionTest3.patch
>
>
> Currently all tests from org.apache.harmony.beans.tests.java.beans.ExpressionTest pass on our implementation of beans. But I have realized that 9 of these tests still fail on RI. This happened because one of my previous patches for java.beans.Expression class (HARMONY-924) contained errors. The fix for the toString() method introduced by this patch was invalid indeed. I really sorry for that. The attached patch should resolve the situation. With this patch only one test fails on RI.
> testConstructor_Normal
> testConstructor_ArrayTarget
> testConstructor_NewMethodName
> testConstructor_NullArguments
> testConstructor_NullArgument
> testConstructor_Value_NullValue
> toString() compatibility issues. I have updated the tests to let it follow the real RI format of toString(). I have also made some corrections to harmony code to reflect these changes in tests.
> testGetValue_EqualSpecificMethods
> testGetValue_EqualSpecificMethodsException
> Commented out since they actually test the order of elements returned by Class.getMethods() / Class.getDeclaredMethods() (see HARMONY-953). Such order differs from VM to VM and this checking IMO should not be placed in tests for java.beans package.
> testGetValue_UnboundedPrimitiveVSWrapper
> I commented out one of ambiguous overloaded methods of MockObject since the result of the previous version of the test depended (again the same problem) on the order of elements returned by Class.getMethods()
> testGetValue_UnboundedOverloadedConstructors
> Currently fails on RI because RI violates the spec for Statement#execute() method. I didn't touch anything in this test, so it fails (as it did before).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-1061) [classlib][beans] tests from
ExpressionTest fail on RI
Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1061?page=all ]
Alexei Zakharov updated HARMONY-1061:
-------------------------------------
Attachment: ExpressionTest3.patch
> [classlib][beans] tests from ExpressionTest fail on RI
> ------------------------------------------------------
>
> Key: HARMONY-1061
> URL: http://issues.apache.org/jira/browse/HARMONY-1061
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Environment: winXP
> Reporter: Alexei Zakharov
> Attachments: ExpressionTest3.patch
>
>
> Currently all tests from org.apache.harmony.beans.tests.java.beans.ExpressionTest pass on our implementation of beans. But I have realized that 9 of these tests still fail on RI. This happened because one of my previous patches for java.beans.Expression class (HARMONY-924) contained errors. The fix for the toString() method introduced by this patch was invalid indeed. I really sorry for that. The attached patch should resolve the situation. With this patch only one test fails on RI.
> testConstructor_Normal
> testConstructor_ArrayTarget
> testConstructor_NewMethodName
> testConstructor_NullArguments
> testConstructor_NullArgument
> testConstructor_Value_NullValue
> toString() compatibility issues. I have updated the tests to let it follow the real RI format of toString(). I have also made some corrections to harmony code to reflect these changes in tests.
> testGetValue_EqualSpecificMethods
> testGetValue_EqualSpecificMethodsException
> Commented out since they actually test the order of elements returned by Class.getMethods() / Class.getDeclaredMethods() (see HARMONY-953). Such order differs from VM to VM and this checking IMO should not be placed in tests for java.beans package.
> testGetValue_UnboundedPrimitiveVSWrapper
> I commented out one of ambiguous overloaded methods of MockObject since the result of the previous version of the test depended (again the same problem) on the order of elements returned by Class.getMethods()
> testGetValue_UnboundedOverloadedConstructors
> Currently fails on RI because RI violates the spec for Statement#execute() method. I didn't touch anything in this test, so it fails (as it did before).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira