[jira] [Updated] (HBASE-14127) Refactor AssignmentManager.unassign() function which has lots of return statements

["Apekshit Sharma (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HBASE-14127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Apekshit Sharma updated HBASE-14127:
------------------------------------
    Attachment: HBASE-14127-master.patch

should be fine to do this refactoring only in master branch since branch-1 has zk based assignment manager and is already significantly different.

> Refactor AssignmentManager.unassign() function which has lots of return statements
> ----------------------------------------------------------------------------------
>
>                 Key: HBASE-14127
>                 URL: https://issues.apache.org/jira/browse/HBASE-14127
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Apekshit Sharma
>            Assignee: Apekshit Sharma
>            Priority: Minor
>         Attachments: HBASE-14127-master.patch
>
>
> In AssignmentManager.unassign()
> * there are lots of return points
> * if condition is very non-trivial to understand
> * reuse of 'state' for different purpose makes things confusing
> A simple unfold of if-else with with better variable names should be sufficient.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)