You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/08/31 14:19:15 UTC
[GitHub] [tvm] leandron opened a new pull request, #12660: [Torch][AArch64] Skip test_load_model___wrong_language__to_pytorch
leandron opened a new pull request, #12660:
URL: https://github.com/apache/tvm/pull/12660
This patch makes test_load_model___wrong_language__to_pytorch to be
skipped in AArch64 due to a bug that can be reproduced when enabling
Integration Tests in machines with Torch installed in TVM.
```
The error message seen is:
OSError: /usr/local/lib/python3.7/dist-packages/torch/lib/
libgomp-d22c30c5.so.1: cannot allocate memory in static TLS block
```
While the test needs further investigation, it is being set as
skipped so other tests can be enabled and not to regress and allow
time for the investigation to be made.
This relates to the issue described in #10673.
cc @Mousius @driazati @NicolaLancellotti @ashutosh-arm @areusch @gromero
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] leandron commented on a diff in pull request #12660: [Torch][AArch64] Skip test_load_model___wrong_language__to_pytorch
Posted by GitBox <gi...@apache.org>.
leandron commented on code in PR #12660:
URL: https://github.com/apache/tvm/pull/12660#discussion_r959755851
##########
tests/python/driver/tvmc/test_frontends.py:
##########
@@ -269,6 +269,10 @@ def test_load_quantized_model__pth(pytorch_mobilenetv2_quantized):
assert p.dtype in ["int8", "uint8", "int32"] # int32 for bias
+@pytest.mark.skipif(
+ platform.machine() == "aarch64",
+ reason="Currently failing on AArch64 - see https://github.com/apache/tvm/issues/10673",
Review Comment:
Done now. thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] leandron commented on pull request #12660: [Torch][AArch64] Skip test_load_model___wrong_language__to_pytorch
Posted by GitBox <gi...@apache.org>.
leandron commented on PR #12660:
URL: https://github.com/apache/tvm/pull/12660#issuecomment-1233339364
It seems CI is happy now fyi @driazati @areusch @Mousius
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] driazati commented on a diff in pull request #12660: [Torch][AArch64] Skip test_load_model___wrong_language__to_pytorch
Posted by GitBox <gi...@apache.org>.
driazati commented on code in PR #12660:
URL: https://github.com/apache/tvm/pull/12660#discussion_r959718855
##########
tests/python/driver/tvmc/test_frontends.py:
##########
@@ -269,6 +269,10 @@ def test_load_quantized_model__pth(pytorch_mobilenetv2_quantized):
assert p.dtype in ["int8", "uint8", "int32"] # int32 for bias
+@pytest.mark.skipif(
+ platform.machine() == "aarch64",
+ reason="Currently failing on AArch64 - see https://github.com/apache/tvm/issues/10673",
Review Comment:
this test isnt explicitly mentioned in this issue, can you add it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] leandron commented on pull request #12660: [Torch][AArch64] Skip test_load_model___wrong_language__to_pytorch
Posted by GitBox <gi...@apache.org>.
leandron commented on PR #12660:
URL: https://github.com/apache/tvm/pull/12660#issuecomment-1233122715
> Just curious why does CI not show this failure if it's running `pytest tests/python/driver` on aarch64 after #10677?
This is actually something I've reported in https://github.com/apache/tvm/issues/12529 and exactly what is blocking us to update the AArch64 images with updates for ONNX/Torch and TF for better coverage.
#10677 is merged, but the production images are not reflecting that yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] leandron commented on pull request #12660: [Torch][AArch64] Skip test_load_model___wrong_language__to_pytorch
Posted by GitBox <gi...@apache.org>.
leandron commented on PR #12660:
URL: https://github.com/apache/tvm/pull/12660#issuecomment-1233022436
Once this is merged, we can then proceed and:
1. Merge https://github.com/apache/tvm/pull/12131
2. generate/update Docker images
3. Merge https://github.com/apache/tvm/pull/11519
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] driazati merged pull request #12660: [Torch][AArch64] Skip test_load_model___wrong_language__to_pytorch
Posted by GitBox <gi...@apache.org>.
driazati merged PR #12660:
URL: https://github.com/apache/tvm/pull/12660
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org