You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Alan Conway <ac...@redhat.com> on 2013/04/18 01:47:40 UTC

Review Request: QPID-4748: Consistent handling of durations in broker configuration, allowing sub-second intervals.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10595/
-----------------------------------------------------------

Review request for qpid, Andrew Stitcher and Gordon Sim.


Description
-------

QPID-4748: Consistent handling of durations in broker configuration, allowing sub-second intervals.

Allow intervals to be expressed as:

10 - value in seconds, backward compatible.
10s - value in seconds
10ms - value in milliseconds
10us - value in microseconds
10ns - value in nanoseconds


This addresses bug QPID-4748.
    https://issues.apache.org/jira/browse/QPID-4748


Diffs
-----

  /trunk/qpid/cpp/include/qpid/sys/Time.h 1468953 
  /trunk/qpid/cpp/src/qpid/broker/Broker.h 1468953 
  /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1468953 
  /trunk/qpid/cpp/src/qpid/broker/ConnectionHandler.cpp 1468953 
  /trunk/qpid/cpp/src/qpid/ha/StatusCheck.h 1468953 
  /trunk/qpid/cpp/src/qpid/ha/StatusCheck.cpp 1468953 
  /trunk/qpid/cpp/src/qpid/sys/posix/Time.cpp 1468953 
  /trunk/qpid/cpp/src/tests/TimerTest.cpp 1468953 

Diff: https://reviews.apache.org/r/10595/diff/


Testing
-------


Thanks,

Alan Conway


Re: Review Request: QPID-4748: Consistent handling of durations in broker configuration, allowing sub-second intervals.

Posted by Andrew Stitcher <as...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10595/#review19393
-----------------------------------------------------------

Ship it!


Except for removing the declaration of toTimeval() from PrivatePosix.h I think this is good to go.


/trunk/qpid/cpp/src/qpid/sys/posix/Time.cpp
<https://reviews.apache.org/r/10595/#comment40100>

    Can get rid of the definition in PrivatePosix.h too.


- Andrew Stitcher


On April 18, 2013, 4:14 p.m., Alan Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10595/
> -----------------------------------------------------------
> 
> (Updated April 18, 2013, 4:14 p.m.)
> 
> 
> Review request for qpid, Andrew Stitcher and Gordon Sim.
> 
> 
> Description
> -------
> 
> QPID-4748: Consistent handling of durations in broker configuration, allowing sub-second intervals.
> 
> Allow intervals to be expressed as:
> 
> 10 - value in seconds, backward compatible.
> 10s - value in seconds
> 10ms - value in milliseconds
> 10us - value in microseconds
> 10ns - value in nanoseconds
> 
> 
> This addresses bug QPID-4748.
>     https://issues.apache.org/jira/browse/QPID-4748
> 
> 
> Diffs
> -----
> 
>   /trunk/qpid/cpp/include/qpid/sys/Time.h 1468953 
>   /trunk/qpid/cpp/src/qpid/broker/Broker.h 1468953 
>   /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1468953 
>   /trunk/qpid/cpp/src/qpid/broker/ConnectionHandler.cpp 1468953 
>   /trunk/qpid/cpp/src/qpid/ha/Settings.h 1468953 
>   /trunk/qpid/cpp/src/qpid/ha/StatusCheck.h 1468953 
>   /trunk/qpid/cpp/src/qpid/ha/StatusCheck.cpp 1468953 
>   /trunk/qpid/cpp/src/qpid/sys/posix/Time.cpp 1468953 
>   /trunk/qpid/cpp/src/tests/TimerTest.cpp 1468953 
> 
> Diff: https://reviews.apache.org/r/10595/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alan Conway
> 
>


Re: Review Request: QPID-4748: Consistent handling of durations in broker configuration, allowing sub-second intervals.

Posted by Alan Conway <ac...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10595/
-----------------------------------------------------------

(Updated April 18, 2013, 4:14 p.m.)


Review request for qpid, Andrew Stitcher and Gordon Sim.


Changes
-------

Included points raised by Andrew.


Description
-------

QPID-4748: Consistent handling of durations in broker configuration, allowing sub-second intervals.

Allow intervals to be expressed as:

10 - value in seconds, backward compatible.
10s - value in seconds
10ms - value in milliseconds
10us - value in microseconds
10ns - value in nanoseconds


This addresses bug QPID-4748.
    https://issues.apache.org/jira/browse/QPID-4748


Diffs (updated)
-----

  /trunk/qpid/cpp/include/qpid/sys/Time.h 1468953 
  /trunk/qpid/cpp/src/qpid/broker/Broker.h 1468953 
  /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1468953 
  /trunk/qpid/cpp/src/qpid/broker/ConnectionHandler.cpp 1468953 
  /trunk/qpid/cpp/src/qpid/ha/Settings.h 1468953 
  /trunk/qpid/cpp/src/qpid/ha/StatusCheck.h 1468953 
  /trunk/qpid/cpp/src/qpid/ha/StatusCheck.cpp 1468953 
  /trunk/qpid/cpp/src/qpid/sys/posix/Time.cpp 1468953 
  /trunk/qpid/cpp/src/tests/TimerTest.cpp 1468953 

Diff: https://reviews.apache.org/r/10595/diff/


Testing
-------


Thanks,

Alan Conway


Re: Review Request: QPID-4748: Consistent handling of durations in broker configuration, allowing sub-second intervals.

Posted by Alan Conway <ac...@redhat.com>.

> On April 18, 2013, 2:31 p.m., Andrew Stitcher wrote:
> > I basically like this.
> > 
> > I don't see the point of str() added to Duration though given there's operator<< and operator>>.
> > 
> > I assume that the options parser uses boost::lexical_cast internally so can automatically take advantage of the new Duration::operator<< which is neat.
> > 
> > I'm sure about the introduced new casts perhaps they should be static_cast<>() to make them stand out more?

I've taken on all your suggestions, see next diff.


- Alan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10595/#review19387
-----------------------------------------------------------


On April 17, 2013, 11:47 p.m., Alan Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10595/
> -----------------------------------------------------------
> 
> (Updated April 17, 2013, 11:47 p.m.)
> 
> 
> Review request for qpid, Andrew Stitcher and Gordon Sim.
> 
> 
> Description
> -------
> 
> QPID-4748: Consistent handling of durations in broker configuration, allowing sub-second intervals.
> 
> Allow intervals to be expressed as:
> 
> 10 - value in seconds, backward compatible.
> 10s - value in seconds
> 10ms - value in milliseconds
> 10us - value in microseconds
> 10ns - value in nanoseconds
> 
> 
> This addresses bug QPID-4748.
>     https://issues.apache.org/jira/browse/QPID-4748
> 
> 
> Diffs
> -----
> 
>   /trunk/qpid/cpp/include/qpid/sys/Time.h 1468953 
>   /trunk/qpid/cpp/src/qpid/broker/Broker.h 1468953 
>   /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1468953 
>   /trunk/qpid/cpp/src/qpid/broker/ConnectionHandler.cpp 1468953 
>   /trunk/qpid/cpp/src/qpid/ha/StatusCheck.h 1468953 
>   /trunk/qpid/cpp/src/qpid/ha/StatusCheck.cpp 1468953 
>   /trunk/qpid/cpp/src/qpid/sys/posix/Time.cpp 1468953 
>   /trunk/qpid/cpp/src/tests/TimerTest.cpp 1468953 
> 
> Diff: https://reviews.apache.org/r/10595/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alan Conway
> 
>


Re: Review Request: QPID-4748: Consistent handling of durations in broker configuration, allowing sub-second intervals.

Posted by Andrew Stitcher <as...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10595/#review19387
-----------------------------------------------------------


I basically like this.

I don't see the point of str() added to Duration though given there's operator<< and operator>>.

I assume that the options parser uses boost::lexical_cast internally so can automatically take advantage of the new Duration::operator<< which is neat.

I'm sure about the introduced new casts perhaps they should be static_cast<>() to make them stand out more?


/trunk/qpid/cpp/include/qpid/sys/Time.h
<https://reviews.apache.org/r/10595/#comment40098>

    This isn't used anywhere remove (I don't count testing as somewhere, since it isn't even necessary there)



/trunk/qpid/cpp/src/qpid/sys/posix/Time.cpp
<https://reviews.apache.org/r/10595/#comment40097>

    Remove - only needed for unnecessary str()



/trunk/qpid/cpp/src/qpid/sys/posix/Time.cpp
<https://reviews.apache.org/r/10595/#comment40096>

    This doesn't seem to be used anywhere, remove it.


- Andrew Stitcher


On April 17, 2013, 11:47 p.m., Alan Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10595/
> -----------------------------------------------------------
> 
> (Updated April 17, 2013, 11:47 p.m.)
> 
> 
> Review request for qpid, Andrew Stitcher and Gordon Sim.
> 
> 
> Description
> -------
> 
> QPID-4748: Consistent handling of durations in broker configuration, allowing sub-second intervals.
> 
> Allow intervals to be expressed as:
> 
> 10 - value in seconds, backward compatible.
> 10s - value in seconds
> 10ms - value in milliseconds
> 10us - value in microseconds
> 10ns - value in nanoseconds
> 
> 
> This addresses bug QPID-4748.
>     https://issues.apache.org/jira/browse/QPID-4748
> 
> 
> Diffs
> -----
> 
>   /trunk/qpid/cpp/include/qpid/sys/Time.h 1468953 
>   /trunk/qpid/cpp/src/qpid/broker/Broker.h 1468953 
>   /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1468953 
>   /trunk/qpid/cpp/src/qpid/broker/ConnectionHandler.cpp 1468953 
>   /trunk/qpid/cpp/src/qpid/ha/StatusCheck.h 1468953 
>   /trunk/qpid/cpp/src/qpid/ha/StatusCheck.cpp 1468953 
>   /trunk/qpid/cpp/src/qpid/sys/posix/Time.cpp 1468953 
>   /trunk/qpid/cpp/src/tests/TimerTest.cpp 1468953 
> 
> Diff: https://reviews.apache.org/r/10595/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alan Conway
> 
>