You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by zhuoliu <gi...@git.apache.org> on 2015/10/14 23:32:22 UTC
[GitHub] storm pull request: [STORM-1112] add executor-id to executor threa...
GitHub user zhuoliu opened a pull request:
https://github.com/apache/storm/pull/800
[STORM-1112] add executor-id to executor thread name
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhuoliu/storm 1112
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/800.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #800
----
commit ee1bc8a9d4fc0796e897c3b0082d35170bbca05e
Author: zhuol <zh...@yahoo-inc.com>
Date: 2015-10-14T21:32:44Z
[STORM-1112] add executor-id to executor thread name
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1112] add executor-id to executor threa...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/800#discussion_r42064526
--- Diff: storm-core/src/clj/backtype/storm/daemon/executor.clj ---
@@ -685,7 +685,7 @@
0))
:kill-fn (:report-error-and-die executor-data)
:factory? true
- :thread-name component-id)]))
+ :thread-name (str component-id "-executor" (:executor-id executor-data)))]))
--- End diff --
@zhuoliu Ah, OK. I prefer current formatting. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1112] add executor-id to executor threa...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/800#issuecomment-148224367
@zhuoliu
Great work, +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1112] add executor-id to executor threa...
Posted by zhuoliu <gi...@git.apache.org>.
Github user zhuoliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/800#discussion_r42064214
--- Diff: storm-core/src/clj/backtype/storm/daemon/executor.clj ---
@@ -685,7 +685,7 @@
0))
:kill-fn (:report-error-and-die executor-data)
:factory? true
- :thread-name component-id)]))
+ :thread-name (str component-id "-executor" (:executor-id executor-data)))]))
--- End diff --
Thanks @HeartSaVioR
Currently the executor send queue thread has name like this:
"Thread-25-disruptor-executor[25 25]-send-queue"
I take similar format to above to be consistent, now we will have executor thread name as:
"Thread-26-spout-executor[25 25]"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1112] add executor-id to executor threa...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/800#issuecomment-148422429
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1112] add executor-id to executor threa...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/800#discussion_r42063657
--- Diff: storm-core/src/clj/backtype/storm/daemon/executor.clj ---
@@ -685,7 +685,7 @@
0))
:kill-fn (:report-error-and-die executor-data)
:factory? true
- :thread-name component-id)]))
+ :thread-name (str component-id "-executor" (:executor-id executor-data)))]))
--- End diff --
@zhuoliu
nit: I'd like to add a "-" between "-executor" and executor-id, but it's related to personal style, and really minor.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1112] add executor-id to executor threa...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/800
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---