You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pinot.apache.org by GitBox <gi...@apache.org> on 2019/02/14 08:14:15 UTC

[GitHub] codecov-io commented on issue #3836: Clarify all methods in PinotFS

codecov-io commented on issue #3836: Clarify all methods in PinotFS
URL: https://github.com/apache/incubator-pinot/pull/3836#issuecomment-463533303
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3836?src=pr&el=h1) Report
   > Merging [#3836](https://codecov.io/gh/apache/incubator-pinot/pull/3836?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/3217d805b50e247464c094c4d9736d9273c3796c?src=pr&el=desc) will **decrease** coverage by `16.34%`.
   > The diff coverage is `75%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/3836/graphs/tree.svg?width=650&token=4ibza2ugkz&height=150&src=pr)](https://codecov.io/gh/apache/incubator-pinot/pull/3836?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #3836       +/-   ##
   =============================================
   - Coverage     67.02%   50.68%   -16.35%     
     Complexity        4        4               
   =============================================
     Files          1029     1150      +121     
     Lines         50785    57721     +6936     
     Branches       7095     7996      +901     
   =============================================
   - Hits          34040    29253     -4787     
   - Misses        14419    26300    +11881     
   + Partials       2326     2168      -158
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/3836?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...main/java/org/apache/pinot/filesystem/PinotFS.java](https://codecov.io/gh/apache/incubator-pinot/pull/3836/diff?src=pr&el=tree#diff-cGlub3QtZmlsZXN5c3RlbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvZmlsZXN5c3RlbS9QaW5vdEZTLmphdmE=) | `100% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [.../controller/helix/core/SegmentDeletionManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3836/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL1NlZ21lbnREZWxldGlvbk1hbmFnZXIuamF2YQ==) | `73.98% <75%> (-5.7%)` | `0 <0> (ø)` | |
   | [...e/pinot/core/operator/blocks/EmptyFilterBlock.java](https://codecov.io/gh/apache/incubator-pinot/pull/3836/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9ibG9ja3MvRW1wdHlGaWx0ZXJCbG9jay5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
   | [...lection/iterator/FloatSelectionColumnIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3836/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9zZWxlY3Rpb24vaXRlcmF0b3IvRmxvYXRTZWxlY3Rpb25Db2x1bW5JdGVyYXRvci5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
   | [...ot/minion/events/EventObserverFactoryRegistry.java](https://codecov.io/gh/apache/incubator-pinot/pull/3836/diff?src=pr&el=tree#diff-cGlub3QtbWluaW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9taW5pb24vZXZlbnRzL0V2ZW50T2JzZXJ2ZXJGYWN0b3J5UmVnaXN0cnkuamF2YQ==) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
   | [...minion/executor/ConvertToRawIndexTaskExecutor.java](https://codecov.io/gh/apache/incubator-pinot/pull/3836/diff?src=pr&el=tree#diff-cGlub3QtbWluaW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9taW5pb24vZXhlY3V0b3IvQ29udmVydFRvUmF3SW5kZXhUYXNrRXhlY3V0b3IuamF2YQ==) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
   | [...on/iterator/FloatArraySelectionColumnIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3836/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9zZWxlY3Rpb24vaXRlcmF0b3IvRmxvYXRBcnJheVNlbGVjdGlvbkNvbHVtbkl0ZXJhdG9yLmphdmE=) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
   | [...a/org/apache/pinot/minion/metrics/MinionMeter.java](https://codecov.io/gh/apache/incubator-pinot/pull/3836/diff?src=pr&el=tree#diff-cGlub3QtbWluaW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9taW5pb24vbWV0cmljcy9NaW5pb25NZXRlci5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
   | [.../apache/pinot/minion/metrics/MinionQueryPhase.java](https://codecov.io/gh/apache/incubator-pinot/pull/3836/diff?src=pr&el=tree#diff-cGlub3QtbWluaW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9taW5pb24vbWV0cmljcy9NaW5pb25RdWVyeVBoYXNlLmphdmE=) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
   | [...selection/iterator/IntSelectionColumnIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3836/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9zZWxlY3Rpb24vaXRlcmF0b3IvSW50U2VsZWN0aW9uQ29sdW1uSXRlcmF0b3IuamF2YQ==) | `0% <0%> (-100%)` | `0% <0%> (ø)` | |
   | ... and [449 more](https://codecov.io/gh/apache/incubator-pinot/pull/3836/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3836?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3836?src=pr&el=footer). Last update [3217d80...b63ca13](https://codecov.io/gh/apache/incubator-pinot/pull/3836?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pinot.apache.org
For additional commands, e-mail: dev-help@pinot.apache.org