[GitHub] [kafka] junrao commented on a change in pull request #8857: KAFKA-10157: Fix broken tests due to InterruptedException from FinalizedFeatureChangeListener

[GitBox <gi...@apache.org>]

junrao commented on a change in pull request #8857:
URL: https://github.com/apache/kafka/pull/8857#discussion_r439460747



##########
File path: core/src/main/scala/kafka/server/FinalizedFeatureChangeListener.scala
##########
@@ -143,10 +142,13 @@ class FinalizedFeatureChangeListener(zkClient: KafkaZkClient) extends Logging {
   private class ChangeNotificationProcessorThread(name: String) extends ShutdownableThread(name = name) {
     override def doWork(): Unit = {
       try {
-        ignoring(classOf[InterruptedException]) {
-          queue.take.updateLatestOrThrow()
-        }
+        queue.take.updateLatestOrThrow()
       } catch {
+        case _: InterruptedException =>
+          // We ignore InterruptedException. While the queue is empty and this thread is blocking on

Review comment:
       I think we can just propagate this exception to ShutdownableThread. It ignores this exception if the thread is stopped. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org