You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/10/26 08:24:26 UTC

[GitHub] [incubator-eventmesh] rinuaby13 opened a new pull request, #1883: [ISSUE #1566]Added logger to record the catched exception

rinuaby13 opened a new pull request, #1883:
URL: https://github.com/apache/incubator-eventmesh/pull/1883

   Fixes #1566 .
   
   ### Motivation
   This method catches an exception, and throws a different exception, without incorporating the original exception. Doing so hides the original source of the exception, making debugging and fixing these problems difficult.
   
   ### Modifications
   Added logger to record raw exception information
   
   ### Documentation
   
   - Does this pull request introduce a new feature? (yes / no)No
   - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)not applicable
   - If a feature is not applicable for documentation, explain why?This is a minor issue that helps in debugging.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] rinuaby13 commented on a diff in pull request #1883: [ISSUE #1566]Added logger to record the catched exception

Posted by GitBox <gi...@apache.org>.
rinuaby13 commented on code in PR #1883:
URL: https://github.com/apache/incubator-eventmesh/pull/1883#discussion_r1005482253


##########
eventmesh-connector-plugin/eventmesh-connector-kafka/src/main/java/org/apache/eventmesh/connector/kafka/consumer/ConsumerImpl.java:
##########
@@ -38,7 +38,12 @@
 import io.cloudevents.CloudEvent;
 import io.cloudevents.kafka.CloudEventDeserializer;
 
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
 public class ConsumerImpl {
+    public Logger logger = LoggerFactory.getLogger(ConsumerImpl.class);

Review Comment:
    Have made the necessary changes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] rinuaby13 closed pull request #1883: [ISSUE #1566]Added logger to record the catched exception

Posted by GitBox <gi...@apache.org>.
rinuaby13 closed pull request #1883: [ISSUE #1566]Added logger to record the catched exception
URL: https://github.com/apache/incubator-eventmesh/pull/1883


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] xwm1992 merged pull request #1883: [ISSUE #1566]Added logger to record the catched exception

Posted by GitBox <gi...@apache.org>.
xwm1992 merged PR #1883:
URL: https://github.com/apache/incubator-eventmesh/pull/1883


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] xwm1992 commented on a diff in pull request #1883: [ISSUE #1566]Added logger to record the catched exception

Posted by GitBox <gi...@apache.org>.
xwm1992 commented on code in PR #1883:
URL: https://github.com/apache/incubator-eventmesh/pull/1883#discussion_r1005401826


##########
eventmesh-connector-plugin/eventmesh-connector-kafka/src/main/java/org/apache/eventmesh/connector/kafka/consumer/ConsumerImpl.java:
##########
@@ -38,7 +38,12 @@
 import io.cloudevents.CloudEvent;
 import io.cloudevents.kafka.CloudEventDeserializer;
 
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
 public class ConsumerImpl {
+    public Logger logger = LoggerFactory.getLogger(ConsumerImpl.class);

Review Comment:
   please add static final



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org