You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/09/20 23:40:58 UTC
[GitHub] [ozone] DaveTeng0 commented on a diff in pull request #3754: HDDS-7199. Implement new mix workload Read/Write Freon command which meets specific test requirements
DaveTeng0 commented on code in PR #3754:
URL: https://github.com/apache/ozone/pull/3754#discussion_r975896165
##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/OzoneClientKeyReadWriteOps.java:
##########
@@ -0,0 +1,258 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations under
+ * the License.
+ */
+package org.apache.hadoop.ozone.freon;
+
+
+import com.codahale.metrics.Timer;
+import org.apache.commons.lang3.RandomUtils;
+import org.apache.hadoop.hdds.cli.HddsVersionProvider;
+import org.apache.hadoop.hdds.conf.OzoneConfiguration;
+import org.apache.hadoop.ozone.client.OzoneBucket;
+import org.apache.hadoop.ozone.client.OzoneClient;
+import org.apache.hadoop.ozone.client.io.OzoneInputStream;
+import org.apache.hadoop.ozone.client.io.OzoneOutputStream;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import picocli.CommandLine;
+
+import java.util.concurrent.Callable;
+import java.util.concurrent.ThreadLocalRandom;
+
+import static org.apache.hadoop.ozone.freon.KeyGeneratorUtil.FILE_DIR_SEPARATOR;
+
+/**
+ * Ozone key generator/reader for performance test.
+ */
+
+@CommandLine.Command(name = "ockrw",
+ aliases = "ozone-client-key-read-write-ops",
+ description = "Read and write keys with the help of the ozone clients.",
+ versionProvider = HddsVersionProvider.class,
+ mixinStandardHelpOptions = true,
+ showDefaultValues = true)
+public class OzoneClientKeyReadWriteOps extends BaseFreonGenerator
+ implements Callable<Void> {
+
+ @CommandLine.Option(names = {"-v", "--volume"},
+ description = "Name of the volume which contains the test data. " +
+ "Will be created if missing.",
+ defaultValue = "vol1")
+ private String volumeName;
+
+ @CommandLine.Option(names = {"-b", "--bucket"},
+ description = "Name of the bucket which contains the test data.",
+ defaultValue = "bucket1")
+ private String bucketName;
+
+ @CommandLine.Option(names = {"-m", "--read-metadata-only"},
+ description = "If only read key's metadata. " +
+ "Supported values are Y, F.",
+ defaultValue = "false")
+ private boolean readMetadataOnly;
+
+ @CommandLine.Option(names = {"-r", "--range-client-read"},
+ description = "range of read operation of each client.",
+ defaultValue = "0")
+ private int readRange;
+
+
+ @CommandLine.Option(names = {"-w", "--range-client-write"},
+ description = "range of write operation of each client.",
+ defaultValue = "0")
+ private int writeRange;
+
+// @CommandLine.Option(names = {"-e", "--end-index-each-client-read"},
+// description = "end-index of each client's read operation.",
+// defaultValue = "0")
+// private int endIndexForRead;
+
+// @CommandLine.Option(names = {"-j", "--end-index-each-client-write"},
+// description = "end-index of each client's write operation.",
+// defaultValue = "0")
+// private int endIndexForWrite;
+
+ @CommandLine.Option(names = {"-g", "--size"},
Review Comment:
yeah, make sense!
##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/OzoneClientKeyReadWriteOps.java:
##########
@@ -0,0 +1,258 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations under
+ * the License.
+ */
+package org.apache.hadoop.ozone.freon;
+
+
+import com.codahale.metrics.Timer;
+import org.apache.commons.lang3.RandomUtils;
+import org.apache.hadoop.hdds.cli.HddsVersionProvider;
+import org.apache.hadoop.hdds.conf.OzoneConfiguration;
+import org.apache.hadoop.ozone.client.OzoneBucket;
+import org.apache.hadoop.ozone.client.OzoneClient;
+import org.apache.hadoop.ozone.client.io.OzoneInputStream;
+import org.apache.hadoop.ozone.client.io.OzoneOutputStream;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import picocli.CommandLine;
+
+import java.util.concurrent.Callable;
+import java.util.concurrent.ThreadLocalRandom;
+
+import static org.apache.hadoop.ozone.freon.KeyGeneratorUtil.FILE_DIR_SEPARATOR;
+
+/**
+ * Ozone key generator/reader for performance test.
+ */
+
+@CommandLine.Command(name = "ockrw",
+ aliases = "ozone-client-key-read-write-ops",
+ description = "Read and write keys with the help of the ozone clients.",
+ versionProvider = HddsVersionProvider.class,
+ mixinStandardHelpOptions = true,
+ showDefaultValues = true)
+public class OzoneClientKeyReadWriteOps extends BaseFreonGenerator
+ implements Callable<Void> {
+
+ @CommandLine.Option(names = {"-v", "--volume"},
+ description = "Name of the volume which contains the test data. " +
+ "Will be created if missing.",
+ defaultValue = "vol1")
+ private String volumeName;
+
+ @CommandLine.Option(names = {"-b", "--bucket"},
+ description = "Name of the bucket which contains the test data.",
+ defaultValue = "bucket1")
+ private String bucketName;
+
+ @CommandLine.Option(names = {"-m", "--read-metadata-only"},
+ description = "If only read key's metadata. " +
+ "Supported values are Y, F.",
+ defaultValue = "false")
+ private boolean readMetadataOnly;
+
+ @CommandLine.Option(names = {"-r", "--range-client-read"},
+ description = "range of read operation of each client.",
+ defaultValue = "0")
+ private int readRange;
+
+
+ @CommandLine.Option(names = {"-w", "--range-client-write"},
+ description = "range of write operation of each client.",
+ defaultValue = "0")
+ private int writeRange;
+
+// @CommandLine.Option(names = {"-e", "--end-index-each-client-read"},
+// description = "end-index of each client's read operation.",
+// defaultValue = "0")
+// private int endIndexForRead;
+
+// @CommandLine.Option(names = {"-j", "--end-index-each-client-write"},
+// description = "end-index of each client's write operation.",
+// defaultValue = "0")
+// private int endIndexForWrite;
+
+ @CommandLine.Option(names = {"-g", "--size"},
+ description = "Generated data size (in bytes) of " +
+ "each key/file to be " +
+ "written.",
+ defaultValue = "256")
+ private int writeSizeInBytes;
+
+ @CommandLine.Option(names = {"-k", "--keySorted"},
Review Comment:
yeah, make sense!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org