You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by ap...@apache.org on 2018/07/28 02:19:16 UTC
[1/4] hbase git commit: HBASE-20895 NPE in RpcServer#readAndProcess
Repository: hbase
Updated Branches:
refs/heads/branch-1 203a3324e -> 2d70120eb
refs/heads/branch-1.2 4f8c13c81 -> b3fd08e39
refs/heads/branch-1.3 fb6b9221b -> 16138513c
refs/heads/branch-1.4 a55bcbd4f -> 3d4c7710a
HBASE-20895 NPE in RpcServer#readAndProcess
Synchronize readAndProcess() on the Connection to avoid MT issues with
data buffer management
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/2d70120e
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/2d70120e
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/2d70120e
Branch: refs/heads/branch-1
Commit: 2d70120eb334419aa3ee91188ec0fa29c1f63e18
Parents: 203a332
Author: Andrew Purtell <ap...@apache.org>
Authored: Fri Jul 27 18:07:58 2018 -0700
Committer: Andrew Purtell <ap...@apache.org>
Committed: Fri Jul 27 18:07:58 2018 -0700
----------------------------------------------------------------------
.../src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/2d70120e/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
index c4c7360..3950939 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
@@ -1635,7 +1635,7 @@ public class RpcServer implements RpcServerInterface, ConfigurationObserver {
* @throws IOException
* @throws InterruptedException
*/
- public int readAndProcess() throws IOException, InterruptedException {
+ public synchronized int readAndProcess() throws IOException, InterruptedException {
// If we have not read the connection setup preamble, look to see if that is on the wire.
if (!connectionPreambleRead) {
int count = readPreamble();
[3/4] hbase git commit: HBASE-20895 NPE in RpcServer#readAndProcess
Posted by ap...@apache.org.
HBASE-20895 NPE in RpcServer#readAndProcess
Synchronize readAndProcess() on the Connection to avoid MT issues with
data buffer management
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/16138513
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/16138513
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/16138513
Branch: refs/heads/branch-1.3
Commit: 16138513cc1bb62f0019613f17e0141582f25fff
Parents: fb6b922
Author: Andrew Purtell <ap...@apache.org>
Authored: Fri Jul 27 18:07:58 2018 -0700
Committer: Andrew Purtell <ap...@apache.org>
Committed: Fri Jul 27 18:08:10 2018 -0700
----------------------------------------------------------------------
.../src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/16138513/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
index e320e74..5742851 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
@@ -1637,7 +1637,7 @@ public class RpcServer implements RpcServerInterface, ConfigurationObserver {
* @throws IOException
* @throws InterruptedException
*/
- public int readAndProcess() throws IOException, InterruptedException {
+ public synchronized int readAndProcess() throws IOException, InterruptedException {
// If we have not read the connection setup preamble, look to see if that is on the wire.
if (!connectionPreambleRead) {
int count = readPreamble();
[4/4] hbase git commit: HBASE-20895 NPE in RpcServer#readAndProcess
Posted by ap...@apache.org.
HBASE-20895 NPE in RpcServer#readAndProcess
Synchronize readAndProcess() on the Connection to avoid MT issues with
data buffer management
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/3d4c7710
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/3d4c7710
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/3d4c7710
Branch: refs/heads/branch-1.4
Commit: 3d4c7710ac21f3e0c3205417764f127fcc16b284
Parents: a55bcbd
Author: Andrew Purtell <ap...@apache.org>
Authored: Fri Jul 27 18:07:58 2018 -0700
Committer: Andrew Purtell <ap...@apache.org>
Committed: Fri Jul 27 18:08:13 2018 -0700
----------------------------------------------------------------------
.../src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/3d4c7710/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
index c4c7360..3950939 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
@@ -1635,7 +1635,7 @@ public class RpcServer implements RpcServerInterface, ConfigurationObserver {
* @throws IOException
* @throws InterruptedException
*/
- public int readAndProcess() throws IOException, InterruptedException {
+ public synchronized int readAndProcess() throws IOException, InterruptedException {
// If we have not read the connection setup preamble, look to see if that is on the wire.
if (!connectionPreambleRead) {
int count = readPreamble();
[2/4] hbase git commit: HBASE-20895 NPE in RpcServer#readAndProcess
Posted by ap...@apache.org.
HBASE-20895 NPE in RpcServer#readAndProcess
Synchronize readAndProcess() on the Connection to avoid MT issues with
data buffer management
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/b3fd08e3
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/b3fd08e3
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/b3fd08e3
Branch: refs/heads/branch-1.2
Commit: b3fd08e39e99703e13e970854eb3c1622b9476ae
Parents: 4f8c13c
Author: Andrew Purtell <ap...@apache.org>
Authored: Fri Jul 27 18:07:58 2018 -0700
Committer: Andrew Purtell <ap...@apache.org>
Committed: Fri Jul 27 18:08:07 2018 -0700
----------------------------------------------------------------------
.../src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/b3fd08e3/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
index 4a973c6..2503204 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
@@ -1557,7 +1557,7 @@ public class RpcServer implements RpcServerInterface, ConfigurationObserver {
* @throws IOException
* @throws InterruptedException
*/
- public int readAndProcess() throws IOException, InterruptedException {
+ public synchronized int readAndProcess() throws IOException, InterruptedException {
// If we have not read the connection setup preamble, look to see if that is on the wire.
if (!connectionPreambleRead) {
int count = readPreamble();