[GitHub] [iceberg] kbendick commented on a diff in pull request #4847: Spark 3.2: Add snapshot-id filter property to AllManifest table

[GitBox <gi...@apache.org>]

kbendick commented on code in PR #4847:
URL: https://github.com/apache/iceberg/pull/4847#discussion_r882993369


##########
core/src/main/java/org/apache/iceberg/util/PropertyUtil.java:
##########
@@ -74,6 +76,19 @@ public static String propertyAsString(Map<String, String> properties,
     return defaultValue;
   }
 
+  public static List<Long> propertyAsLongList(Map<String, String> properties,
+                                              String property) {
+    String value = properties.get(property);
+    if (value == null) {
+      return null;
+    }
+    return Splitter.on(",")

Review Comment:
   Nit: Might be good to declare the splitter one time as a private static field, as opposed to constructing it every time (unless there's some serialization-related reason it has to be reinstantiated).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org