[GitHub] jihoonson commented on a change in pull request #6502: bloom filter sql

[GitBox <gi...@apache.org>]

jihoonson commented on a change in pull request #6502: bloom filter sql
URL: https://github.com/apache/incubator-druid/pull/6502#discussion_r234819477
 
 

 ##########
 File path: sql/src/main/java/org/apache/druid/sql/calcite/expression/Expressions.java
 ##########
 @@ -492,27 +468,29 @@ private static DimFilter toSimpleLeafFilter(
       }
 
       return filter;
-    } else if (kind == SqlKind.LIKE) {
-      final List<RexNode> operands = ((RexCall) rexNode).getOperands();
-      final DruidExpression druidExpression = toDruidExpression(
-          plannerContext,
-          rowSignature,
-          operands.get(0)
-      );
-      if (druidExpression == null || !druidExpression.isSimpleExtraction()) {
+    } else if (rexNode instanceof RexCall) {
+      final SqlOperator operator = ((RexCall) rexNode).getOperator();
+
+      final SqlOperatorConversion conversion =
+          plannerContext.getOperatorTable().lookupOperatorConversion(operator);
 
 Review comment:
   nit: even though this method isn't added in this PR, I was confused this method is to get `LookupOperatorConversion` which is also an implementation of `SqlOperatorConversion`. Can we use another name?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org