You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/04/05 14:41:30 UTC

[GitHub] [spark] vinooganesh opened a new pull request #28128: [SPARK-31354] SparkSession Lifecycle methods to fix memory leak

vinooganesh opened a new pull request #28128: [SPARK-31354] SparkSession Lifecycle methods to fix memory leak
URL: https://github.com/apache/spark/pull/28128
 
 
   
   ## What changes were proposed in this pull request?
   
   This change introduces the new `terminate()` method on a `SparkSession` instance that marks the session as terminated, cleans up the listener state on the `SparkContext`, and marks the session instance as unusable. The purpose of this PR is 2-fold:
   1. Many users have multi-tenant applications which contain multiple `SparkSession` instances. Currently these instances aren't cleaned up and a memory leak exists.
   2. This PR also introduces framework to treat the SparkSessions as they were originally intended - lightweight and shortlived "sessions" that are easy to create and tear down. 
   
   ## How was this patch tested?
   
   * Unit test included as a part of the PR 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28128: [SPARK-31354] SparkSession Lifecycle methods to fix memory leak

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28128: [SPARK-31354] SparkSession Lifecycle methods to fix memory leak
URL: https://github.com/apache/spark/pull/28128#issuecomment-609427703
 
 
   Can one of the admins verify this patch?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28128: [SPARK-31354] SparkSession Lifecycle methods to fix memory leak

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28128: [SPARK-31354] SparkSession Lifecycle methods to fix memory leak
URL: https://github.com/apache/spark/pull/28128#issuecomment-610740323
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25640/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] vinooganesh commented on issue #28128: [SPARK-31354] SparkSession Lifecycle methods to fix memory leak

Posted by GitBox <gi...@apache.org>.
vinooganesh commented on issue #28128: [SPARK-31354] SparkSession Lifecycle methods to fix memory leak
URL: https://github.com/apache/spark/pull/28128#issuecomment-610719071
 
 
   Hey @srowen - could I get an "ok to test" on here? also thoughts on this approach? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28128: [SPARK-31354] SparkSession Lifecycle methods to fix memory leak

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28128: [SPARK-31354] SparkSession Lifecycle methods to fix memory leak
URL: https://github.com/apache/spark/pull/28128#issuecomment-610763658
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120948/
   Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28128: [SPARK-31354] SparkSession Lifecycle methods to fix memory leak

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28128: [SPARK-31354] SparkSession Lifecycle methods to fix memory leak
URL: https://github.com/apache/spark/pull/28128#issuecomment-610740320
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28128: [SPARK-31354] SparkSession Lifecycle methods to fix memory leak

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28128: [SPARK-31354] SparkSession Lifecycle methods to fix memory leak
URL: https://github.com/apache/spark/pull/28128#issuecomment-610763658
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120948/
   Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28128: [SPARK-31354] SparkSession Lifecycle methods to fix memory leak

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28128: [SPARK-31354] SparkSession Lifecycle methods to fix memory leak
URL: https://github.com/apache/spark/pull/28128#issuecomment-610763654
 
 
   Merged build finished. Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28128: [SPARK-31354] SparkSession Lifecycle methods to fix memory leak

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28128: [SPARK-31354] SparkSession Lifecycle methods to fix memory leak
URL: https://github.com/apache/spark/pull/28128#issuecomment-610740320
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] srowen commented on issue #28128: [SPARK-31354] SparkSession Lifecycle methods to fix memory leak

Posted by GitBox <gi...@apache.org>.
srowen commented on issue #28128: [SPARK-31354] SparkSession Lifecycle methods to fix memory leak
URL: https://github.com/apache/spark/pull/28128#issuecomment-610739647
 
 
   Jenkins test this please

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28128: [SPARK-31354] SparkSession Lifecycle methods to fix memory leak

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28128: [SPARK-31354] SparkSession Lifecycle methods to fix memory leak
URL: https://github.com/apache/spark/pull/28128#issuecomment-609427703
 
 
   Can one of the admins verify this patch?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #28128: [SPARK-31354] SparkSession Lifecycle methods to fix memory leak

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28128: [SPARK-31354] SparkSession Lifecycle methods to fix memory leak
URL: https://github.com/apache/spark/pull/28128#issuecomment-610763575
 
 
   **[Test build #120948 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120948/testReport)** for PR 28128 at commit [`99c5f64`](https://github.com/apache/spark/commit/99c5f6428b0322271bc0155ef1c71f37a3ba7ddc).
    * This patch **fails Spark unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #28128: [SPARK-31354] SparkSession Lifecycle methods to fix memory leak

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28128: [SPARK-31354] SparkSession Lifecycle methods to fix memory leak
URL: https://github.com/apache/spark/pull/28128#issuecomment-609427517
 
 
   Can one of the admins verify this patch?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28128: [SPARK-31354] SparkSession Lifecycle methods to fix memory leak

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28128: [SPARK-31354] SparkSession Lifecycle methods to fix memory leak
URL: https://github.com/apache/spark/pull/28128#issuecomment-609427517
 
 
   Can one of the admins verify this patch?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28128: [SPARK-31354] SparkSession Lifecycle methods to fix memory leak

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28128: [SPARK-31354] SparkSession Lifecycle methods to fix memory leak
URL: https://github.com/apache/spark/pull/28128#issuecomment-610763654
 
 
   Merged build finished. Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #28128: [SPARK-31354] SparkSession Lifecycle methods to fix memory leak

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28128: [SPARK-31354] SparkSession Lifecycle methods to fix memory leak
URL: https://github.com/apache/spark/pull/28128#issuecomment-610740323
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25640/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #28128: [SPARK-31354] SparkSession Lifecycle methods to fix memory leak

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28128: [SPARK-31354] SparkSession Lifecycle methods to fix memory leak
URL: https://github.com/apache/spark/pull/28128#issuecomment-610740113
 
 
   **[Test build #120948 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120948/testReport)** for PR 28128 at commit [`99c5f64`](https://github.com/apache/spark/commit/99c5f6428b0322271bc0155ef1c71f37a3ba7ddc).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on issue #28128: [SPARK-31354] SparkSession Lifecycle methods to fix memory leak

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28128: [SPARK-31354] SparkSession Lifecycle methods to fix memory leak
URL: https://github.com/apache/spark/pull/28128#issuecomment-610740113
 
 
   **[Test build #120948 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120948/testReport)** for PR 28128 at commit [`99c5f64`](https://github.com/apache/spark/commit/99c5f6428b0322271bc0155ef1c71f37a3ba7ddc).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org