You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/21 15:13:48 UTC

[GitHub] [airflow] kaxil commented on a change in pull request #22385: Fix "run_id" k8s and elasticsearch compatibility with Airflow 2.1

kaxil commented on a change in pull request #22385:
URL: https://github.com/apache/airflow/pull/22385#discussion_r831221736



##########
File path: airflow/providers/elasticsearch/log/es_task_handler.py
##########
@@ -129,7 +129,7 @@ def _render_log_id(self, ti: TaskInstance, try_number: int) -> str:
         return self.log_id_template.format(
             dag_id=ti.dag_id,
             task_id=ti.task_id,
-            run_id=ti.run_id,
+            run_id=getattr(ti, "run_id", ""),

Review comment:
       Does this work with an empty string?
   
   cc @jedcunningham @uranusjr 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org