You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by rg...@apache.org on 2018/12/01 21:24:34 UTC

[logging-log4j2] branch release-2.x updated: LOG4J2-1906 - close files after reading

This is an automated email from the ASF dual-hosted git repository.

rgoers pushed a commit to branch release-2.x
in repository https://gitbox.apache.org/repos/asf/logging-log4j2.git


The following commit(s) were added to refs/heads/release-2.x by this push:
     new 4e3bc73  LOG4J2-1906 - close files after reading
4e3bc73 is described below

commit 4e3bc73b06cce3881fc7213877d2987972370ad4
Author: Ralph Goers <rg...@apache.org>
AuthorDate: Sat Dec 1 14:24:15 2018 -0700

    LOG4J2-1906 - close files after reading
---
 .../log4j/core/appender/rolling/RollingAppenderDirectWrite1906Test.java  | 1 +
 .../log4j/core/appender/rolling/RollingAppenderDirectWriteTest.java      | 1 +
 2 files changed, 2 insertions(+)

diff --git a/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderDirectWrite1906Test.java b/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderDirectWrite1906Test.java
index 64ab892..c2b7c59 100644
--- a/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderDirectWrite1906Test.java
+++ b/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderDirectWrite1906Test.java
@@ -83,6 +83,7 @@ public class RollingAppenderDirectWrite1906Test {
                 assertEquals("Incorrect file name. Expected: " + expected + " Actual: " + actual, expected, actual);
                 ++found;
             }
+            reader.close();
         }
         assertEquals("Incorrect number of events read. Expected " + count + ", Actual " + found, count, found);
 
diff --git a/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderDirectWriteTest.java b/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderDirectWriteTest.java
index dec87b5..379f083 100644
--- a/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderDirectWriteTest.java
+++ b/log4j-core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderDirectWriteTest.java
@@ -86,6 +86,7 @@ public class RollingAppenderDirectWriteTest {
                     actual.startsWith(expected));
                 ++found;
             }
+            reader.close();
         }
         assertEquals("Incorrect number of events read. Expected " + count + ", Actual " + found, count, found);
     }