You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "nervoussidd (via GitHub)" <gi...@apache.org> on 2023/02/22 05:16:17 UTC
[GitHub] [airflow] nervoussidd opened a new pull request, #29683: this file adds a on_kill method to Dataproc operator.
nervoussidd opened a new pull request, #29683:
URL: https://github.com/apache/airflow/pull/29683
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #29683: this file adds a on_kill method to Dataproc operator.
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on PR #29683:
URL: https://github.com/apache/airflow/pull/29683#issuecomment-1439485650
Start with reading one of the CONTRIBUTION guides listed here: https://github.com/apache/airflow/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #29683: this file adds a on_kill method to Dataproc operator.
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on PR #29683:
URL: https://github.com/apache/airflow/pull/29683#issuecomment-1439463713
This is not valid Python. Did you test it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #29683: this file adds a on_kill method to Dataproc operator.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #29683: this file adds a on_kill method to Dataproc operator.
URL: https://github.com/apache/airflow/pull/29683
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] nervoussidd closed pull request #29683: this file adds a on_kill method to Dataproc operator.
Posted by "nervoussidd (via GitHub)" <gi...@apache.org>.
nervoussidd closed pull request #29683: this file adds a on_kill method to Dataproc operator.
URL: https://github.com/apache/airflow/pull/29683
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] nervoussidd commented on pull request #29683: this file adds a on_kill method to Dataproc operator.
Posted by "nervoussidd (via GitHub)" <gi...@apache.org>.
nervoussidd commented on PR #29683:
URL: https://github.com/apache/airflow/pull/29683#issuecomment-1439473333
Hello Tzu,
No I didn't tested. I was looking for the guidance but I didn't knew whom
to approach so I just learn some basic stuff like about the libraries and
about the methods and wrote this code.
Can u please guide me so that I can work on this and get this merged.
And thank you for the feedback.
Thank you
Thank You
On Wed, Feb 22, 2023, 11:02 AM Tzu-ping Chung ***@***.***>
wrote:
> This is not valid Python. Did you test it?
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/airflow/pull/29683#issuecomment-1439463713>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AUA2XLWPKKSGCE6ZVWMK6CLWYWQHVANCNFSM6AAAAAAVD3TETQ>
> .
> You are receiving this because you modified the open/close state.Message
> ID: ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #29683: this file adds a on_kill method to Dataproc operator.
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #29683:
URL: https://github.com/apache/airflow/pull/29683#issuecomment-1439451836
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] nervoussidd commented on pull request #29683: this file adds a on_kill method to Dataproc operator.
Posted by "nervoussidd (via GitHub)" <gi...@apache.org>.
nervoussidd commented on PR #29683:
URL: https://github.com/apache/airflow/pull/29683#issuecomment-1439486888
Thanks, I'll check it out.
On Wed, Feb 22, 2023, 11:35 AM Tzu-ping Chung ***@***.***>
wrote:
> Start with reading one of the CONTRIBUTING guides listed here:
> https://github.com/apache/airflow/
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/airflow/pull/29683#issuecomment-1439485650>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AUA2XLQVF22QCBXLKPIGVQLWYWUCZANCNFSM6AAAAAAVD3TETQ>
> .
> You are receiving this because you modified the open/close state.Message
> ID: ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #29683: this file adds a on_kill method to Dataproc operator.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29683:
URL: https://github.com/apache/airflow/pull/29683#issuecomment-1501003306
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org