You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/09/07 16:28:22 UTC

[GitHub] [kafka] rajinisivaram opened a new pull request #11308: KAFKA-13277; Fix size calculation for tagged string fields in message generator

rajinisivaram opened a new pull request #11308:
URL: https://github.com/apache/kafka/pull/11308


   Size calculation for tagged fields is currently incorrect and works only for small strings. This results in BufferOverflowException when serializing requests with large strings in tagged fields. The PR fixes size calculation to match the bytes written.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] rajinisivaram commented on pull request #11308: KAFKA-13277; Fix size calculation for tagged string fields in message generator

Posted by GitBox <gi...@apache.org>.
rajinisivaram commented on pull request #11308:
URL: https://github.com/apache/kafka/pull/11308#issuecomment-915008347


   @cmccabe Thanks for reviewing and merging to master. @ijuma @dajac Yes, will cherry-pick to 3.0 and 2.8, thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] ijuma commented on pull request #11308: KAFKA-13277; Fix size calculation for tagged string fields in message generator

Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #11308:
URL: https://github.com/apache/kafka/pull/11308#issuecomment-914931279


   @rajinisivaram Please cherry-pick to 3.0.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] dajac commented on pull request #11308: KAFKA-13277; Fix size calculation for tagged string fields in message generator

Posted by GitBox <gi...@apache.org>.
dajac commented on pull request #11308:
URL: https://github.com/apache/kafka/pull/11308#issuecomment-914988398


   We could also include it in 2.8.1.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] cmccabe merged pull request #11308: KAFKA-13277; Fix size calculation for tagged string fields in message generator

Posted by GitBox <gi...@apache.org>.
cmccabe merged pull request #11308:
URL: https://github.com/apache/kafka/pull/11308


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org