You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/09/02 02:48:50 UTC
[GitHub] [shardingsphere] codecov-commenter commented on pull request #20721: feat: remove useless rules for push-down filters and projects.
codecov-commenter commented on PR #20721:
URL: https://github.com/apache/shardingsphere/pull/20721#issuecomment-1235009753
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/20721?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#20721](https://codecov.io/gh/apache/shardingsphere/pull/20721?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8934a35) into [master](https://codecov.io/gh/apache/shardingsphere/commit/dfee6d93a66fa3c94e85f1d8c9fa5b08328a7207?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dfee6d9) will **decrease** coverage by `0.02%`.
> The diff coverage is `75.00%`.
```diff
@@ Coverage Diff @@
## master #20721 +/- ##
============================================
- Coverage 61.04% 61.02% -0.03%
- Complexity 2414 2416 +2
============================================
Files 3964 3968 +4
Lines 55086 55101 +15
Branches 9351 9355 +4
============================================
- Hits 33627 33623 -4
- Misses 18595 18614 +19
Partials 2864 2864
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/20721?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...optimizer/planner/QueryOptimizePlannerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/20721/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZmVkZXJhdGlvbi9zaGFyZGluZ3NwaGVyZS1pbmZyYS1mZWRlcmF0aW9uLW9wdGltaXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvZmVkZXJhdGlvbi9vcHRpbWl6ZXIvcGxhbm5lci9RdWVyeU9wdGltaXplUGxhbm5lckZhY3RvcnkuamF2YQ==) | `83.33% <75.00%> (-7.08%)` | :arrow_down: |
| [...handler/distsql/ral/hint/enums/HintSourceType.java](https://codecov.io/gh/apache/shardingsphere/pull/20721/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL2hpbnQvZW51bXMvSGludFNvdXJjZVR5cGUuamF2YQ==) | `0.00% <0.00%> (-42.86%)` | :arrow_down: |
| [...tsql/handler/query/TrafficRulesQueryResultSet.java](https://codecov.io/gh/apache/shardingsphere/pull/20721/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXRyYWZmaWMvc2hhcmRpbmdzcGhlcmUtdHJhZmZpYy1kaXN0c3FsL3NoYXJkaW5nc3BoZXJlLXRyYWZmaWMtZGlzdHNxbC1oYW5kbGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS90cmFmZmljL2Rpc3RzcWwvaGFuZGxlci9xdWVyeS9UcmFmZmljUnVsZXNRdWVyeVJlc3VsdFNldC5qYXZh) | `64.70% <0.00%> (-1.97%)` | :arrow_down: |
| [...ser/core/kernel/KernelDistSQLStatementVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/20721/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGlzdHNxbC9zaGFyZGluZ3NwaGVyZS1kaXN0c3FsLXBhcnNlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGlzdHNxbC9wYXJzZXIvY29yZS9rZXJuZWwvS2VybmVsRGlzdFNRTFN0YXRlbWVudFZpc2l0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../distsql/ral/impl/UpdatableRALStatementAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/20721/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtdGVzdC9zaGFyZGluZ3NwaGVyZS1wYXJzZXItdGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvdGVzdC9zcWwvcGFyc2VyL3BhcmFtZXRlcml6ZWQvYXNzZXJ0cy9zdGF0ZW1lbnQvZGlzdHNxbC9yYWwvaW1wbC9VcGRhdGFibGVSQUxTdGF0ZW1lbnRBc3NlcnQuamF2YQ==) | `100.00% <0.00%> (ø)` | |
| [...andler/update/DropTrafficRuleStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/20721/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXRyYWZmaWMvc2hhcmRpbmdzcGhlcmUtdHJhZmZpYy1kaXN0c3FsL3NoYXJkaW5nc3BoZXJlLXRyYWZmaWMtZGlzdHNxbC1oYW5kbGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS90cmFmZmljL2Rpc3RzcWwvaGFuZGxlci91cGRhdGUvRHJvcFRyYWZmaWNSdWxlU3RhdGVtZW50VXBkYXRlci5qYXZh) | `97.50% <0.00%> (ø)` | |
| [...ndler/update/AlterTrafficRuleStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/20721/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXRyYWZmaWMvc2hhcmRpbmdzcGhlcmUtdHJhZmZpYy1kaXN0c3FsL3NoYXJkaW5nc3BoZXJlLXRyYWZmaWMtZGlzdHNxbC1oYW5kbGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS90cmFmZmljL2Rpc3RzcWwvaGFuZGxlci91cGRhdGUvQWx0ZXJUcmFmZmljUnVsZVN0YXRlbWVudFVwZGF0ZXIuamF2YQ==) | `98.27% <0.00%> (ø)` | |
| [...dler/update/CreateTrafficRuleStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/20721/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXRyYWZmaWMvc2hhcmRpbmdzcGhlcmUtdHJhZmZpYy1kaXN0c3FsL3NoYXJkaW5nc3BoZXJlLXRyYWZmaWMtZGlzdHNxbC1oYW5kbGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS90cmFmZmljL2Rpc3RzcWwvaGFuZGxlci91cGRhdGUvQ3JlYXRlVHJhZmZpY1J1bGVTdGF0ZW1lbnRVcGRhdGVyLmphdmE=) | `97.91% <0.00%> (ø)` | |
| [...sql/ral/updatable/AlterTransactionRuleHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/20721/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL3VwZGF0YWJsZS9BbHRlclRyYW5zYWN0aW9uUnVsZUhhbmRsZXIuamF2YQ==) | | |
| ... and [10 more](https://codecov.io/gh/apache/shardingsphere/pull/20721/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org