You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/08/02 07:42:34 UTC
[GitHub] [druid] bananaaggle opened a new pull request #11531: Fix document about pi in sql
bananaaggle opened a new pull request #11531:
URL: https://github.com/apache/druid/pull/11531
Fix PI in document. I test PI in sql, and it works. In source code, this `SqlFunction` is bound to its implementation. But I can not find it in document. I think it should be added in document.
<hr>
<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist below are strictly necessary, but it would be very helpful if you at least self-review the PR. -->
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] bananaaggle commented on a change in pull request #11531: Fix document about pi in sql
Posted by GitBox <gi...@apache.org>.
bananaaggle commented on a change in pull request #11531:
URL: https://github.com/apache/druid/pull/11531#discussion_r681370898
##########
File path: docs/querying/sql.md
##########
@@ -376,6 +376,7 @@ to FLOAT. At runtime, Druid will widen 32-bit floats to 64-bit for most expressi
|Function|Notes|
|--------|-----|
+|`PI`|Constant Pi.|
Review comment:
Just like `CURRENT_TIMESTAMP`, this function does not need a `()`. Actually, sql will not work when write PI as `PI()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] bananaaggle commented on a change in pull request #11531: Fix document about pi in sql
Posted by GitBox <gi...@apache.org>.
bananaaggle commented on a change in pull request #11531:
URL: https://github.com/apache/druid/pull/11531#discussion_r681370898
##########
File path: docs/querying/sql.md
##########
@@ -376,6 +376,7 @@ to FLOAT. At runtime, Druid will widen 32-bit floats to 64-bit for most expressi
|Function|Notes|
|--------|-----|
+|`PI`|Constant Pi.|
Review comment:
Just like `CURRENT_TIMESTAMP`, this function does not need a `()` in document. Actually, sql will not work when write `PI` as `PI()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] asdf2014 commented on a change in pull request #11531: Fix document about pi in sql
Posted by GitBox <gi...@apache.org>.
asdf2014 commented on a change in pull request #11531:
URL: https://github.com/apache/druid/pull/11531#discussion_r681103895
##########
File path: docs/querying/sql.md
##########
@@ -376,6 +376,7 @@ to FLOAT. At runtime, Druid will widen 32-bit floats to 64-bit for most expressi
|Function|Notes|
|--------|-----|
+|`PI`|Constant Pi.|
Review comment:
```suggestion
|`PI()`|Constant Pi.|
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] bananaaggle commented on a change in pull request #11531: Fix document about pi in sql
Posted by GitBox <gi...@apache.org>.
bananaaggle commented on a change in pull request #11531:
URL: https://github.com/apache/druid/pull/11531#discussion_r681370898
##########
File path: docs/querying/sql.md
##########
@@ -376,6 +376,7 @@ to FLOAT. At runtime, Druid will widen 32-bit floats to 64-bit for most expressi
|Function|Notes|
|--------|-----|
+|`PI`|Constant Pi.|
Review comment:
Just like `CURRENT_TIMESTAMP`, this function not need a `()`. Actually, sql will not work when write PI as `PI()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] asdf2014 merged pull request #11531: Fix document about pi in sql
Posted by GitBox <gi...@apache.org>.
asdf2014 merged pull request #11531:
URL: https://github.com/apache/druid/pull/11531
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org