You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by oknet <gi...@git.apache.org> on 2016/05/18 12:08:15 UTC
[GitHub] trafficserver pull request: TS-4455: remove isEosRcvd() and eosRcv...
GitHub user oknet opened a pull request:
https://github.com/apache/trafficserver/pull/646
TS-4455: remove isEosRcvd() and eosRcvd
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/oknet/trafficserver patch-12
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/646.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #646
----
commit 87d8d3864d4b0a5a567778cece17e1aab648075a
Author: Oknet <xu...@gmail.com>
Date: 2016-05-18T11:48:34Z
remove call to isEosRcvd()
commit 8b52939a9479ea71ffcedd33c7bf579ae13388e6
Author: Oknet <xu...@gmail.com>
Date: 2016-05-18T11:52:39Z
remove eosRcvd
commit 43e894aa7520f6754a60f4d11f8bba3b2b14b205
Author: Oknet <xu...@gmail.com>
Date: 2016-05-18T11:53:53Z
remove eosRcvd and isEosRcvd()
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4455: remove isEosRcvd() and eosRcv...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/646#issuecomment-220007429
Can one of the admins verify this patch? Only approve PRs which have been reviewed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4455: remove isEosRcvd() and eosRcv...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/646#issuecomment-220368272
I think we should squash these three commits to one, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4455: remove isEosRcvd() and eosRcv...
Posted by shinrich <gi...@git.apache.org>.
Github user shinrich commented on the pull request:
https://github.com/apache/trafficserver/pull/646#issuecomment-220056278
Looks reasonable to me. The isEosRcvd was added as part of TS-3714. Much of that buffer saving logic has already been removed because changes in handshake buffering in 5.3.x made it unnecessary.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4455: remove isEosRcvd() and eosRcv...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/646
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4455: remove isEosRcvd() and eosRcv...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/646#issuecomment-220376259
.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4455: remove isEosRcvd() and eosRcv...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/646#issuecomment-220007659
Can one of the admins verify this patch? Only approve PRs which have been reviewed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---