You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/26 02:53:23 UTC
[GitHub] [pulsar-client-go] liangyuanpeng opened a new pull request, #798: [Issue 797]Filter tableview message for empty key and add example for tableview
liangyuanpeng opened a new pull request, #798:
URL: https://github.com/apache/pulsar-client-go/pull/798
*(If this PR fixes a github issue, please add `Fixes #<xyz>`.)*
Fixes #797
### Motivation
*Explain here the context, and why you're making that change. What is the problem you're trying to solve.*
### Modifications
- Add example for tableview
- Filter tableview message for empty key
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / GoDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] liangyuanpeng commented on pull request #798: [Issue 797]Filter tableview message for empty key and add example for tableview
Posted by GitBox <gi...@apache.org>.
liangyuanpeng commented on PR #798:
URL: https://github.com/apache/pulsar-client-go/pull/798#issuecomment-1238934707
@merlimat @pgier Resolved review command and add test, PTAL, Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] pgier commented on a diff in pull request #798: [Issue 797]Filter tableview message for empty key and add example for tableview
Posted by GitBox <gi...@apache.org>.
pgier commented on code in PR #798:
URL: https://github.com/apache/pulsar-client-go/pull/798#discussion_r917316822
##########
pulsar/table_view_impl.go:
##########
@@ -242,17 +242,20 @@ func (tv *TableViewImpl) Close() {
}
func (tv *TableViewImpl) handleMessage(msg Message) {
- tv.dataMu.Lock()
- defer tv.dataMu.Unlock()
+ if msg.Key() != "" {
Review Comment:
Minor suggestion to just return if the key is empty instead of nesting in the if.
```suggestion
if msg.Key() == "" {
return
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] liangyuanpeng closed pull request #798: [Issue 797]Filter tableview message for empty key and add example for tableview
Posted by "liangyuanpeng (via GitHub)" <gi...@apache.org>.
liangyuanpeng closed pull request #798: [Issue 797]Filter tableview message for empty key and add example for tableview
URL: https://github.com/apache/pulsar-client-go/pull/798
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-go] liangyuanpeng commented on pull request #798: [Issue 797]Filter tableview message for empty key and add example for tableview
Posted by "liangyuanpeng (via GitHub)" <gi...@apache.org>.
liangyuanpeng commented on PR #798:
URL: https://github.com/apache/pulsar-client-go/pull/798#issuecomment-1628426359
Closed by not review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org