You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@iotdb.apache.org by Yuan Tian <ja...@gmail.com> on 2024/01/05 12:50:58 UTC
PRs about tsfile module
Hi all,
Since we've already set up our tsfile repo, so if you want to make some
changes to common-api and tsfile submodule in IoTDB repo, you also need to
submit another pr for tsfile repo.
Best regards,
------------------------
Yuan Tian
Re: PRs about tsfile module
Posted by Jialin Qiao <qi...@apache.org>.
Hi,
TsFile is an independent project and need its own release schedule and
version, so no submodule is better.
Jialin Qiao
Giorgio Zoppi <gi...@gmail.com> 于2024年1月6日周六 03:41写道：
>
> Ok,
> thanks i will join that list.
>
> Il giorno ven 5 gen 2024 alle ore 18:17 Christofer Dutz <
> christofer.dutz@c-ware.de> ha scritto:
>
> > Generally that will definitely be discussed on the dev@tsfile.apache.org
> > list ;-)
> >
> > Chris
> >
> > Gesendet von Outlook für Android<https://aka.ms/AAb9ysg>
> > ________________________________
> > From: Giorgio Zoppi <gi...@gmail.com>
> > Sent: Friday, January 5, 2024 5:18:55 PM
> > To: dev@iotdb.apache.org <de...@iotdb.apache.org>
> > Subject: Re: PRs about tsfile module
> >
> > Ok, i like it. I also suggest to include docusaurs for the format docs.
> > https://docusaurus.io/,
> > so we can use it. Also what is the plan for python/cpp/rust format
> > implementation?
> > BR,
> > Giorgio
> >
> > Il giorno ven 5 gen 2024 alle ore 12:51 Yuan Tian <ja...@gmail.com>
> > ha scritto:
> >
> > > Hi all,
> > >
> > > Since we've already set up our tsfile repo, so if you want to make some
> > > changes to common-api and tsfile submodule in IoTDB repo, you also need
> > to
> > > submit another pr for tsfile repo.
> > >
> > >
> > > Best regards,
> > > ------------------------
> > > Yuan Tian
> > >
> >
> >
> > --
> > Life is a chess game - Anonymous.
> >
>
>
> --
> Life is a chess game - Anonymous.
Re: PRs about tsfile module
Posted by Giorgio Zoppi <gi...@gmail.com>.
Ok,
thanks i will join that list.
Il giorno ven 5 gen 2024 alle ore 18:17 Christofer Dutz <
christofer.dutz@c-ware.de> ha scritto:
> Generally that will definitely be discussed on the dev@tsfile.apache.org
> list ;-)
>
> Chris
>
> Gesendet von Outlook für Android<https://aka.ms/AAb9ysg>
> ________________________________
> From: Giorgio Zoppi <gi...@gmail.com>
> Sent: Friday, January 5, 2024 5:18:55 PM
> To: dev@iotdb.apache.org <de...@iotdb.apache.org>
> Subject: Re: PRs about tsfile module
>
> Ok, i like it. I also suggest to include docusaurs for the format docs.
> https://docusaurus.io/,
> so we can use it. Also what is the plan for python/cpp/rust format
> implementation?
> BR,
> Giorgio
>
> Il giorno ven 5 gen 2024 alle ore 12:51 Yuan Tian <ja...@gmail.com>
> ha scritto:
>
> > Hi all,
> >
> > Since we've already set up our tsfile repo, so if you want to make some
> > changes to common-api and tsfile submodule in IoTDB repo, you also need
> to
> > submit another pr for tsfile repo.
> >
> >
> > Best regards,
> > ------------------------
> > Yuan Tian
> >
>
>
> --
> Life is a chess game - Anonymous.
>
--
Life is a chess game - Anonymous.
Re: PRs about tsfile module
Posted by Christofer Dutz <ch...@c-ware.de>.
Generally that will definitely be discussed on the dev@tsfile.apache.org list ;-)
Chris
Gesendet von Outlook für Android<https://aka.ms/AAb9ysg>
________________________________
From: Giorgio Zoppi <gi...@gmail.com>
Sent: Friday, January 5, 2024 5:18:55 PM
To: dev@iotdb.apache.org <de...@iotdb.apache.org>
Subject: Re: PRs about tsfile module
Ok, i like it. I also suggest to include docusaurs for the format docs.
https://docusaurus.io/,
so we can use it. Also what is the plan for python/cpp/rust format
implementation?
BR,
Giorgio
Il giorno ven 5 gen 2024 alle ore 12:51 Yuan Tian <ja...@gmail.com>
ha scritto:
> Hi all,
>
> Since we've already set up our tsfile repo, so if you want to make some
> changes to common-api and tsfile submodule in IoTDB repo, you also need to
> submit another pr for tsfile repo.
>
>
> Best regards,
> ------------------------
> Yuan Tian
>
--
Life is a chess game - Anonymous.
Re: PRs about tsfile module
Posted by Giorgio Zoppi <gi...@gmail.com>.
Ok, i like it. I also suggest to include docusaurs for the format docs.
https://docusaurus.io/,
so we can use it. Also what is the plan for python/cpp/rust format
implementation?
BR,
Giorgio
Il giorno ven 5 gen 2024 alle ore 12:51 Yuan Tian <ja...@gmail.com>
ha scritto:
> Hi all,
>
> Since we've already set up our tsfile repo, so if you want to make some
> changes to common-api and tsfile submodule in IoTDB repo, you also need to
> submit another pr for tsfile repo.
>
>
> Best regards,
> ------------------------
> Yuan Tian
>
--
Life is a chess game - Anonymous.
回复： PRs about tsfile module
Posted by ZDandsomSP <11...@qq.com.INVALID>.
+1
------------------ 原始邮件 ------------------
发件人: "dev" <qiaojialin@apache.org>;
发送时间: 2024年1月5日(星期五) 晚上8:57
收件人: "dev"<dev@iotdb.apache.org>;
主题: Re: PRs about tsfile module
+1
Jialin Qiao
Yuan Tian <jackietien97@gmail.com> 于2024年1月5日周五 20:51写道：
>
> Hi all,
>
> Since we've already set up our tsfile repo, so if you want to make some
> changes to common-api and tsfile submodule in IoTDB repo, you also need to
> submit another pr for tsfile repo.
>
>
> Best regards,
> ------------------------
> Yuan Tian
Re: PRs about tsfile module
Posted by Jialin Qiao <qi...@apache.org>.
+1
Jialin Qiao
Yuan Tian <ja...@gmail.com> 于2024年1月5日周五 20:51写道：
>
> Hi all,
>
> Since we've already set up our tsfile repo, so if you want to make some
> changes to common-api and tsfile submodule in IoTDB repo, you also need to
> submit another pr for tsfile repo.
>
>
> Best regards,
> ------------------------
> Yuan Tian
AW: PRs about tsfile module
Posted by Christofer Dutz <ch...@c-ware.de>.
But submodules can be hell when releasing software … so I would actually be in favor of not using Git submodules.
Chris
Von: 刘旭鑫 <li...@outlook.com>
Datum: Freitag, 5. Januar 2024 um 14:14
An: dev@iotdb.apache.org <de...@iotdb.apache.org>
Betreff: Re: PRs about tsfile module
Moreover, submodules also support allowing different branches of IoTDB to track corresponding branches of TsFile. For example, the master branch of IoTDB can refer to the master branch of TsFile, and the rel/1.3 branch of IoTDB can refer to the rel/1.3 branch of TsFile. When switching branches in the IoTDB repository, the TsFile branch will also switch accordingly. We can even have IoTDB directly reference a specific fixed commit of TsFile to ensure the stability of a branch that is no longer being updated. I believe this approach makes management more convenient and flexible.
> 2024年1月5日 21:03，刘旭鑫 <li...@outlook.com> 写道：
>
> Hi, I suggest setting TsFile as a submodule of IoTDB. This would allow the 'tsfile' directory to directly reference the TsFile repository. For example, LevelDB provides a reference to GoogleTest in this manner: https://github.com/google/leveldb/tree/main/third_party.
> The specific steps are:
>
> Add the submodule: git submodule add tsfile https://github.com/apache/tsfile.git
> Initialize the submodule: git submodule init
> Update the submodule: git submodule update
>
> When cloning the IoTDB repository, use the following command to clone the submodule as well:
>
> git clone --recurse-submodules https://github.com/apache/iotdb.git
>
> The advantage of this approach is that whenever the TsFile code is updated, we can pull the latest code through Git. If managed through a POM, it's not easy to package the code of TsFile that hasn't been released yet.
>
> ――――――――――
> Xuxin Liu
>
>> 2024年1月5日 20:50，Yuan Tian <ja...@gmail.com> 写道：
>>
>> Hi all,
>>
>> Since we've already set up our tsfile repo, so if you want to make some
>> changes to common-api and tsfile submodule in IoTDB repo, you also need to
>> submit another pr for tsfile repo.
>>
>>
>> Best regards,
>> ------------------------
>> Yuan Tian
>
Re: PRs about tsfile module
Posted by 刘旭鑫 <li...@outlook.com>.
Moreover, submodules also support allowing different branches of IoTDB to track corresponding branches of TsFile. For example, the master branch of IoTDB can refer to the master branch of TsFile, and the rel/1.3 branch of IoTDB can refer to the rel/1.3 branch of TsFile. When switching branches in the IoTDB repository, the TsFile branch will also switch accordingly. We can even have IoTDB directly reference a specific fixed commit of TsFile to ensure the stability of a branch that is no longer being updated. I believe this approach makes management more convenient and flexible.
> 2024年1月5日 21:03，刘旭鑫 <li...@outlook.com> 写道：
>
> Hi, I suggest setting TsFile as a submodule of IoTDB. This would allow the 'tsfile' directory to directly reference the TsFile repository. For example, LevelDB provides a reference to GoogleTest in this manner: https://github.com/google/leveldb/tree/main/third_party.
> The specific steps are:
>
> Add the submodule: git submodule add tsfile https://github.com/apache/tsfile.git
> Initialize the submodule: git submodule init
> Update the submodule: git submodule update
>
> When cloning the IoTDB repository, use the following command to clone the submodule as well:
>
> git clone --recurse-submodules https://github.com/apache/iotdb.git
>
> The advantage of this approach is that whenever the TsFile code is updated, we can pull the latest code through Git. If managed through a POM, it's not easy to package the code of TsFile that hasn't been released yet.
>
> ——————————
> Xuxin Liu
>
>> 2024年1月5日 20:50，Yuan Tian <ja...@gmail.com> 写道：
>>
>> Hi all,
>>
>> Since we've already set up our tsfile repo, so if you want to make some
>> changes to common-api and tsfile submodule in IoTDB repo, you also need to
>> submit another pr for tsfile repo.
>>
>>
>> Best regards,
>> ------------------------
>> Yuan Tian
>
Re: PRs about tsfile module
Posted by 刘旭鑫 <li...@outlook.com>.
Hi, I suggest setting TsFile as a submodule of IoTDB. This would allow the 'tsfile' directory to directly reference the TsFile repository. For example, LevelDB provides a reference to GoogleTest in this manner: https://github.com/google/leveldb/tree/main/third_party.
The specific steps are:
Add the submodule: git submodule add tsfile https://github.com/apache/tsfile.git
Initialize the submodule: git submodule init
Update the submodule: git submodule update
When cloning the IoTDB repository, use the following command to clone the submodule as well:
git clone --recurse-submodules https://github.com/apache/iotdb.git
The advantage of this approach is that whenever the TsFile code is updated, we can pull the latest code through Git. If managed through a POM, it's not easy to package the code of TsFile that hasn't been released yet.
——————————
Xuxin Liu
> 2024年1月5日 20:50，Yuan Tian <ja...@gmail.com> 写道：
>
> Hi all,
>
> Since we've already set up our tsfile repo, so if you want to make some
> changes to common-api and tsfile submodule in IoTDB repo, you also need to
> submit another pr for tsfile repo.
>
>
> Best regards,
> ------------------------
> Yuan Tian