[GitHub] matthiasblaesing commented on a change in pull request #959: [NETBEANS-1074] Module review j2ee.platform

[GitBox <gi...@apache.org>]

matthiasblaesing commented on a change in pull request #959: [NETBEANS-1074] Module review j2ee.platform
URL: https://github.com/apache/incubator-netbeans/pull/959#discussion_r230560052
 
 

 ##########
 File path: enterprise/j2ee.platform/external/binaries-list
 ##########
 @@ -1 +1,18 @@
-27E9711AA35C39EF455BFD900D544BACB99C0E89 javaee-doc-api.jar
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+CC1024CBFA7C3A9CC84485603A7D458BFD2F3B4A javax:javaee-api:7.0:javadoc
 
 Review comment:
   I disagree. Have a look at `org.netbeans.modules.maven.queries.RepositoryForBinaryQueryImpl`. here is this code:
   
   ```java
           public URL[] getRoots() {
               try {
                   File j2eeDoc = InstalledFileLocator.getDefault().locate("docs/javaee-doc-api.jar", "org.netbeans.modules.j2ee.platform", false); // NOI18N
                   if (j2eeDoc != null) {
                       URL url = FileUtil.getArchiveRoot(Utilities.toURI(j2eeDoc).toURL());
                       url = new URL(url + "docs/api/"); //NOI18N
                       return new URL[]{url};
                   }
               } catch (MalformedURLException ex) {
                   Exceptions.printStackTrace(ex);
               }
               return new URL[0];
           }
   ```
   
   The returned URL points to a place, that does not exist after the switch of the binary.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists