You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by co...@apache.org on 2018/03/12 19:05:41 UTC
svn commit: r1826585 - /httpd/test/framework/trunk/t/apache/http_strict.t
Author: covener
Date: Mon Mar 12 19:05:41 2018
New Revision: 1826585
URL: http://svn.apache.org/viewvc?rev=1826585&view=rev
Log:
don't depend on need_min_apache_ver
Sorry, when I added this, it magically just used the Apache::test
in my svn:external. Now I can't get it to work on another system.
The goal was to keep old releases and old maintenance levels testable
Modified:
httpd/test/framework/trunk/t/apache/http_strict.t
Modified: httpd/test/framework/trunk/t/apache/http_strict.t
URL: http://svn.apache.org/viewvc/httpd/test/framework/trunk/t/apache/http_strict.t?rev=1826585&r1=1826584&r2=1826585&view=diff
==============================================================================
--- httpd/test/framework/trunk/t/apache/http_strict.t (original)
+++ httpd/test/framework/trunk/t/apache/http_strict.t Mon Mar 12 19:05:41 2018
@@ -119,7 +119,9 @@ my @test_cases = (
have_module qw(mod_headers) ],
);
-my $test_fold = need_min_apache_fix("2.2.33", "2.4.26", "2.5.0");
+my $test_fold = defined(&need_min_apache_fix) ?
+ need_min_apache_fix("2.2.33", "2.4.26", "2.5.0") :
+ need_min_apache_version('2.4.26');
plan tests => scalar(@test_cases) * 2 + $test_fold * 2,
need_min_apache_version('2.2.32');
Re: svn commit: r1826585 - /httpd/test/framework/trunk/t/apache/http_strict.t
Posted by Eric Covener <co...@gmail.com>.
On Tue, Mar 13, 2018 at 4:43 AM, Joe Orton <jo...@redhat.com> wrote:
> On Mon, Mar 12, 2018 at 07:05:41PM -0000, covener@apache.org wrote:
>> Author: covener
>> Date: Mon Mar 12 19:05:41 2018
>> New Revision: 1826585
>>
>> URL: http://svn.apache.org/viewvc?rev=1826585&view=rev
>> Log:
>> don't depend on need_min_apache_ver
>>
>> Sorry, when I added this, it magically just used the Apache::test
>> in my svn:external. Now I can't get it to work on another system.
>>
>> The goal was to keep old releases and old maintenance levels testable
>
> This was working fine for me, FWIW.
>
> I hit a bunch of weird problems with the test suite which I *think* were
> due to the INC path omitting . in Perl 5.26+, which I fixed in r1825901,
> but you need to regenerate t/TEST. Not very confident in my Perl skills
> as usual, so may be misdiagnosing that.
Thanks -- will check it out.
As soon as I hit it, i recalled at least wrowe (I think) had been
sidetracked by it too during a release vote.
--
Eric Covener
covener@gmail.com
Re: svn commit: r1826585 -
/httpd/test/framework/trunk/t/apache/http_strict.t
Posted by Joe Orton <jo...@redhat.com>.
On Mon, Mar 12, 2018 at 07:05:41PM -0000, covener@apache.org wrote:
> Author: covener
> Date: Mon Mar 12 19:05:41 2018
> New Revision: 1826585
>
> URL: http://svn.apache.org/viewvc?rev=1826585&view=rev
> Log:
> don't depend on need_min_apache_ver
>
> Sorry, when I added this, it magically just used the Apache::test
> in my svn:external. Now I can't get it to work on another system.
>
> The goal was to keep old releases and old maintenance levels testable
This was working fine for me, FWIW.
I hit a bunch of weird problems with the test suite which I *think* were
due to the INC path omitting . in Perl 5.26+, which I fixed in r1825901,
but you need to regenerate t/TEST. Not very confident in my Perl skills
as usual, so may be misdiagnosing that.
Regards, Joe