[GitHub] [kafka] tombentley commented on a diff in pull request #12306: KAFKA-13976: Improvements for OpenAPI specs

[GitBox <gi...@apache.org>]

tombentley commented on code in PR #12306:
URL: https://github.com/apache/kafka/pull/12306#discussion_r908272740


##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/resources/ConnectorPluginsResource.java:
##########
@@ -105,7 +115,28 @@ private <T> void addConnectorPlugins(Collection<PluginDesc<T>> plugins, Collecti
 
     @PUT
     @Path("/{pluginName}/config/validate")
-    @Operation(summary = "Validate the provided configuration against the configuration definition for the specified pluginName")
+    @Operation(
+            summary = "Validate the provided configuration against the configuration definition for the specified pluginName",
+            parameters = {

Review Comment:
   It looks like declaring parameters like this results in duplicates in the output, for example:
   
   ```yaml
     /connector-plugins/{pluginName}/config/validate:
       put:
         operationId: validateConfigs
         parameters:
         - in: path
           name: pluginName
           required: true
           schema:
             $ref: '#/components/schemas/StringSchema'
         - in: path
           name: pluginName
           required: true
           schema:
             type: string
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org