[GitHub] [airflow] FloChehab edited a comment on pull request #10584: Add support for envFrom in helm chart

[GitBox <gi...@apache.org>]

FloChehab edited a comment on pull request #10584:
URL: https://github.com/apache/airflow/pull/10584#issuecomment-712721095


   > I don't know if we should adopt a more generic approach to `EnvFrom`.
   > https://github.com/apache/airflow/pull/11426/files
   > https://github.com/codecentric/helm-charts/tree/master/charts/keycloak#using-a-secret-managed-by-the-chart
   > What do you think?
   
   Hello,
   
   The second link looks pretty nice to me and I was initially going for something like that if I remember well.
   The issue was about the integration with the KubernetesExecutor.
   
   In my emails, I can see another comment of yours linked to that (that I guess you have deleted since):
   
   > Hi. We currently want to significantly simplify KubernetesExecutor/KubernetesPodOperators and delete many configuration options. https://lists.apache.org/thread.html/rb1bcafea1b8f86e6d155aea7169c05805f7021e90f1636afc8019074%40%3Cdev.airflow.apache.org%3E
   For this reason, it seems to me that your change is not very useful. Can you make sure that the appropriate features options can be passed using pod_template_file?
   https://github.com/apache/airflow/blob/master/chart/values.yaml#L636
   
   So what would you recommend ?
   * Refactoring to use something like  https://github.com/codecentric/helm-charts/tree/master/charts/keycloak#using-a-secret-managed-by-the-chart and ignoring the kubernetes executor ?
   * Doing the first point ; but doing the integration with the KubernetesExecutor another way ?
   * Something else ? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org