You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ath0mas (via GitHub)" <gi...@apache.org> on 2023/08/22 21:58:03 UTC

[GitHub] [cordova-plugin-media-capture] ath0mas opened a new pull request, #280: Android: remove RECORD_AUDIO permission

ath0mas opened a new pull request, #280:
URL: https://github.com/apache/cordova-plugin-media-capture/pull/280

   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   Android
   
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   Permissions `RECORD_AUDIO` is not requested at runtime and unnecessary.
   Replace #211 to fix #209?
   
   
   ### Description
   <!-- Describe your changes in detail -->
   See previous PR #211 and issue #209.
   But contrary to both of them, stating that `The external permissions are already handled by the cordova-plugin-file, which this plugin depends on.`, seems wrong now: `cordova-plugin-file` ^8.0.0 does not declare any permission at all inside its `plugin.xml`, so this plugin can still do it.
   
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   
   
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [x] I added automated test coverage as appropriate for this change
   - [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [x] I've updated the documentation if necessary
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

Re: [PR] Android: remove RECORD_AUDIO permission [cordova-plugin-media-capture]

Posted by "breautek (via GitHub)" <gi...@apache.org>.
breautek merged PR #280:
URL: https://github.com/apache/cordova-plugin-media-capture/pull/280


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

Re: [PR] Android: remove RECORD_AUDIO permission [cordova-plugin-media-capture]

Posted by "breautek (via GitHub)" <gi...@apache.org>.
breautek commented on PR #280:
URL: https://github.com/apache/cordova-plugin-media-capture/pull/280#issuecomment-2551914308

   @ath0mas are you able to rebase? I'll merge once it's rebased.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

Re: [PR] Android: remove RECORD_AUDIO permission [cordova-plugin-media-capture]

Posted by "ath0mas (via GitHub)" <gi...@apache.org>.
ath0mas commented on PR #280:
URL: https://github.com/apache/cordova-plugin-media-capture/pull/280#issuecomment-2556402644

   @breautek rebase done 👍


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org