You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/06/24 15:18:42 UTC

[GitHub] [camel-k] astefanutti opened a new issue #1555: Migrate from ServiceMonitor to PodMonitor in Prometheus trait

astefanutti opened a new issue #1555:
URL: https://github.com/apache/camel-k/issues/1555


   The Prometheus creates a `ServiceMonitor` resource, so that a Prometheus operator instance can discover the integration metrics endpoints. In newer versions of the Prometheus operator, the `PodMonitor` resource has been introduced that seems more appropriate, as it would prevent the creation of an ah-hoc service for the sole monitoring purpose.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] astefanutti edited a comment on issue #1555: Migrate from ServiceMonitor to PodMonitor in Prometheus trait

Posted by GitBox <gi...@apache.org>.
astefanutti edited a comment on issue #1555:
URL: https://github.com/apache/camel-k/issues/1555#issuecomment-651038282


   A first implementation has been done at https://github.com/astefanutti/camel-k/commit/0cff2daafd4c2d4699ceef4bad074c7c83e6b547.
   
   However, it seems it hits the limitation enforced by Knative Serving, that only a single container port can be declared. In that case, the work-around used with `ServiceMonitor`, that is, not declaring the metrics endpoint port, does not work with `PodMonitor`.
   
   A couple of issues are already reported in Knative Serving, that we should support:
   * https://github.com/knative/serving/issues/8047
   * https://github.com/knative/serving/issues/8471
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] heiko-braun commented on issue #1555: Migrate from ServiceMonitor to PodMonitor in Prometheus trait

Posted by GitBox <gi...@apache.org>.
heiko-braun commented on issue #1555:
URL: https://github.com/apache/camel-k/issues/1555#issuecomment-649226844


   Is a composite resource that contains servicemonitor, alerts, etc?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] astefanutti commented on issue #1555: Migrate from ServiceMonitor to PodMonitor in Prometheus trait

Posted by GitBox <gi...@apache.org>.
astefanutti commented on issue #1555:
URL: https://github.com/apache/camel-k/issues/1555#issuecomment-649293837


   > Is a composite resource that contains servicemonitor, alerts, etc?
   
   As `ServiceMonitor`, `PodMonitor` purpose is to configure Prometheus operator discovery of metrics endpoints. The difference is that there is no intermediate service exposing these endpoints when using `PodMonitor`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] astefanutti edited a comment on issue #1555: Migrate from ServiceMonitor to PodMonitor in Prometheus trait

Posted by GitBox <gi...@apache.org>.
astefanutti edited a comment on issue #1555:
URL: https://github.com/apache/camel-k/issues/1555#issuecomment-651038282


   A first implementation has been done at https://github.com/astefanutti/camel-k/commit/0cff2daafd4c2d4699ceef4bad074c7c83e6b547.
   
   However, it seems it hits the limitation enforced by Knative Serving, that only a single container port can be declared. In that case, the work-around used with `ServiceMonitor`, that is, not declaring the metrics endpoint port, does not work with `PodMonitor`.
   
   A couple of issues are already reported in Knative Serving, that we should support:
   * https://github.com/knative/serving/issues/8047
   * https://github.com/knative/serving/issues/8471
   
   Another option would be to use a single port serving both application and monitoring traffic. While this would be difficult for the _main_ runtime, that relies on the JMX exporter Prometheus agent, this is the default with Quarkus.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] astefanutti closed issue #1555: Migrate from ServiceMonitor to PodMonitor in Prometheus trait

Posted by GitBox <gi...@apache.org>.
astefanutti closed issue #1555:
URL: https://github.com/apache/camel-k/issues/1555


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] astefanutti commented on issue #1555: Migrate from ServiceMonitor to PodMonitor in Prometheus trait

Posted by GitBox <gi...@apache.org>.
astefanutti commented on issue #1555:
URL: https://github.com/apache/camel-k/issues/1555#issuecomment-651038282


   A first implementation has been done at https://github.com/astefanutti/camel-k/commit/0cff2daafd4c2d4699ceef4bad074c7c83e6b547.
   
   However, it seems it hits the limitation enforced by Knative Serving, that only a single container port can be declared. In that case, the work-around used with `ServiceMonitor`, that is, not declaring the metrics endpoint port, does not work with `PodMonitor`.
   
   A couple of issues already in Knative Serving, that we should support:
   * https://github.com/knative/serving/issues/8047
   * https://github.com/knative/serving/issues/8471
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] astefanutti edited a comment on issue #1555: Migrate from ServiceMonitor to PodMonitor in Prometheus trait

Posted by GitBox <gi...@apache.org>.
astefanutti edited a comment on issue #1555:
URL: https://github.com/apache/camel-k/issues/1555#issuecomment-651038282


   A first implementation has been done at https://github.com/astefanutti/camel-k/commit/0cff2daafd4c2d4699ceef4bad074c7c83e6b547.
   
   However, it seems it hits the limitation enforced by Knative Serving, that only a single container port can be declared. In that case, the work-around used with `ServiceMonitor`, that is, not declaring the metrics endpoint port, does not work with `PodMonitor`.
   
   A couple of issues are already reported in Knative Serving:
   * https://github.com/knative/serving/issues/8047
   * https://github.com/knative/serving/issues/8471
   
   Another option would be to use a single port serving both application and monitoring traffic. While this would be difficult for the _main_ runtime, that relies on the JMX exporter Prometheus agent, this is the default with Quarkus. So it may become the preferred option when #1562 gets fixed.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org