You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tsfile.apache.org by Yuan Tian <ja...@gmail.com> on 2024/01/02 06:20:37 UTC
Separate the code of the tsfile module from the iotdb project
Hi all,
In order to successfully separate the code of the tsfile module from the
iotdb project, I made some changes in this PR (
https://github.com/apache/iotdb/pull/11813):
1. move some Path related antlr defined g4 file to tsfile module, so
that tsfile module won't depend on iotdb-antlr module
2. move some codes that are only used in datanode from tsfile module to
datanode module.
After the PR is merged, the code of the tsfile module should be completely
separated from the iotdb project.
Best regards
-----------------------------
Yuan Tian
Re: Separate the code of the tsfile module from the iotdb project
Posted by Jialin Qiao <qi...@apache.org>.
Hi, The PR looks good.
—————————————————
Jialin Qiao
Yuan Tian <ja...@gmail.com> 于2024年1月2日周二 14:20写道：
>
> Hi all,
>
> In order to successfully separate the code of the tsfile module from the
> iotdb project, I made some changes in this PR (
> https://github.com/apache/iotdb/pull/11813):
>
>
> 1. move some Path related antlr defined g4 file to tsfile module, so
> that tsfile module won't depend on iotdb-antlr module
> 2. move some codes that are only used in datanode from tsfile module to
> datanode module.
>
>
> After the PR is merged, the code of the tsfile module should be completely
> separated from the iotdb project.
>
>
>
> Best regards
> -----------------------------
> Yuan Tian
Re: Separate the code of the tsfile module from the iotdb project
Posted by Yuan Tian <ja...@gmail.com>.
Hi all,
BTW, besides the code in tsfile module, we also need to move the code
in iotdb-api/common-api to tsfile project, and after that, it's better to
change the package name of files in iotdb-api/common-api. The reason that
we didn't change package names before is to keep forward compatibility.
On Tue, Jan 2, 2024 at 2:20 PM Yuan Tian <ja...@gmail.com> wrote:
> Hi all,
>
> In order to successfully separate the code of the tsfile module from the
> iotdb project, I made some changes in this PR (
> https://github.com/apache/iotdb/pull/11813):
>
>
> 1. move some Path related antlr defined g4 file to tsfile module, so
> that tsfile module won't depend on iotdb-antlr module
> 2. move some codes that are only used in datanode from tsfile module
> to datanode module.
>
>
> After the PR is merged, the code of the tsfile module should be
> completely separated from the iotdb project.
>
>
>
> Best regards
> -----------------------------
> Yuan Tian
>
Re: Separate the code of the tsfile module from the iotdb project
Posted by Chao Wang <wa...@apache.org>.
+1
On 2024/01/02 06:20:37 Yuan Tian wrote:
> Hi all,
>
> In order to successfully separate the code of the tsfile module from the
> iotdb project, I made some changes in this PR (
> https://github.com/apache/iotdb/pull/11813):
>
>
> 1. move some Path related antlr defined g4 file to tsfile module, so
> that tsfile module won't depend on iotdb-antlr module
> 2. move some codes that are only used in datanode from tsfile module to
> datanode module.
>
>
> After the PR is merged, the code of the tsfile module should be completely
> separated from the iotdb project.
>
>
>
> Best regards
> -----------------------------
> Yuan Tian
>
Re: Separate the code of the tsfile module from the iotdb project
Posted by Yuan Tian <ja...@gmail.com>.
Hi all,
This PR (https://github.com/apache/iotdb/pull/11813) has been merged, so
the code in iotdb-core/tsfile submodule and iotdb-api/common-api submodule
of iotdb is ready to be separated from iotdb project.
Best regards
-----------------------------
Yuan Tian