You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/10/21 01:25:22 UTC
[kudu-CR] [client] reorder methods for KuduSession in client.cc
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16617
Change subject: [client] reorder methods for KuduSession in client.cc
......................................................................
[client] reorder methods for KuduSession in client.cc
While adding new methods into KuduSession, I found it a bit annoying
that the order of methods in *.h file differ from the order of those
in *.cc file. This patch addresses this nit.
This patch does not contain any functional changes.
Change-Id: Ic91c74642070b3324e4d6f909f61013913c0bcc6
---
M src/kudu/client/client.cc
1 file changed, 16 insertions(+), 16 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/16617/1
--
To view, visit http://gerrit.cloudera.org:8080/16617
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic91c74642070b3324e4d6f909f61013913c0bcc6
Gerrit-Change-Number: 16617
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [client] reorder methods for KuduSession in client.cc
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16617 )
Change subject: [client] reorder methods for KuduSession in client.cc
......................................................................
[client] reorder methods for KuduSession in client.cc
While adding new methods into KuduSession, I found it a bit annoying
that the order of methods in *.h file differ from the order of those
in *.cc file. This patch addresses this nit.
This patch does not contain any functional changes.
Change-Id: Ic91c74642070b3324e4d6f909f61013913c0bcc6
Reviewed-on: http://gerrit.cloudera.org:8080/16617
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/client/client.cc
1 file changed, 16 insertions(+), 16 deletions(-)
Approvals:
Kudu Jenkins: Verified
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/16617
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic91c74642070b3324e4d6f909f61013913c0bcc6
Gerrit-Change-Number: 16617
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [client] reorder methods for KuduSession in client.cc
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16617 )
Change subject: [client] reorder methods for KuduSession in client.cc
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16617
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic91c74642070b3324e4d6f909f61013913c0bcc6
Gerrit-Change-Number: 16617
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 21 Oct 2020 17:39:35 +0000
Gerrit-HasComments: No