[GitHub] [calcite] yanlin-Lynn commented on a change in pull request #1531: [CALCITE-3447] Fix equals and hashcode methods of class MutableScan

[GitBox <gi...@apache.org>]

yanlin-Lynn commented on a change in pull request #1531: [CALCITE-3447] Fix equals and hashcode methods of class MutableScan
URL: https://github.com/apache/calcite/pull/1531#discussion_r339932142
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/rel/mutable/MutableScan.java
 ##########
 @@ -36,11 +36,11 @@ public static MutableScan of(TableScan scan) {
   @Override public boolean equals(Object obj) {
     return obj == this
         || obj instanceof MutableScan
-        && rel.equals(((MutableScan) obj).rel);
+        && rel.getTable().equals(((MutableScan) obj).rel.getTable());
   }
 
 Review comment:
   If we make `MaterializedViewSubstitutionVisitor` non public, do we still need to update `hashCode` and `equals`, although it's harmless.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services