[GitHub] [nifi] YolandaMDavis edited a comment on issue #3554: NIFI-5417: Add missing component status and metrics to S2SStatusReportingTask and PrometheusReportingTask

[GitBox <gi...@apache.org>]

YolandaMDavis edited a comment on issue #3554: NIFI-5417: Add missing component status and metrics to S2SStatusReportingTask and PrometheusReportingTask
URL: https://github.com/apache/nifi/pull/3554#issuecomment-510129242
 
 
   @mattyb149 I took a look at this PR and things looked good.  Below were my test cases:
   
   Prometheus Reporting:
   
   1. Ensuring that values added in Prometheus Metrics Util were recognized and eventually made available via metrics endpoint. 
   2. Ensuring new values also appeared in Prometheus server (via server scrape job)
   
   SiteToSiteStatusReporting:
   1. Using local ports capturing SiteToSite data and review provenance for each component type were enhanced as applicable with new values
   2. Reviewing additional details content and schema
   
   My only outstanding question is posted as inline comments related to executionNode (not clear if this was purposefully excluded from schema and docs?).  I think once that's cleared we're good to go.
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services