You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2025/01/31 16:43:54 UTC
[Impala-ASF-CR] IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22432
Change subject: IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
......................................................................
IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
With this patch Impala skips reloading Iceberg tables when metadata
JSON file is the same, as this means that the table is essentially
unchanged.
This can help in situations when the event processor is lagging behind
and we have an Iceberg table that is updated frequently. Imagine the
case when Impala gets 100 events for an Iceberg table. In this case
after processing the first event, our internal representation of
the Iceberg table is already up-to-date, there is no need to do the
reload 100 times.
Testing
* added e2e tests for REFRESH, also for event processing
Change-Id: I16727000cb11d1c0591875a6542d428564dce664
---
M fe/src/main/java/org/apache/impala/catalog/IcebergTable.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-mixed-format-position-deletes.test
M tests/metadata/test_event_processing.py
3 files changed, 43 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/32/22432/1
--
To view, visit http://gerrit.cloudera.org:8080/22432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I16727000cb11d1c0591875a6542d428564dce664
Gerrit-Change-Number: 22432
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
Posted by "Noemi Pap-Takacs (Code Review)" <ge...@cloudera.org>.
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/22432 )
Change subject: IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
......................................................................
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/22432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16727000cb11d1c0591875a6542d428564dce664
Gerrit-Change-Number: 22432
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 May 2025 15:26:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
Posted by "Noemi Pap-Takacs (Code Review)" <ge...@cloudera.org>.
Noemi Pap-Takacs has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22432 )
Change subject: IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
......................................................................
IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
With this patch Impala skips reloading Iceberg tables when metadata
JSON file is the same, as this means that the table is essentially
unchanged.
This can help in situations when the event processor is lagging behind
and we have an Iceberg table that is updated frequently. Imagine the
case when Impala gets 100 events for an Iceberg table. In this case
after processing the first event, our internal representation of
the Iceberg table is already up-to-date, there is no need to do the
reload 100 times.
We cannot use the internal icebergApiTable_'s metadata location,
as the following statement might silently refresh the metadata
in 'current()':
icebergApiTable_.operations().current().metadataFileLocation()
To guarantee that we check against the actual loaded metadata
this patch introduces a new member to store the metadata location.
Testing
* added e2e tests for REFRESH, also for event processing
Change-Id: I16727000cb11d1c0591875a6542d428564dce664
Reviewed-on: http://gerrit.cloudera.org:8080/22432
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Noemi Pap-Takacs <np...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/catalog/IcebergTable.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-mixed-format-position-deletes.test
M tests/metadata/test_event_processing.py
3 files changed, 108 insertions(+), 47 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Noemi Pap-Takacs: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/22432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I16727000cb11d1c0591875a6542d428564dce664
Gerrit-Change-Number: 22432
Gerrit-PatchSet: 6
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Noemi Pap-Takacs, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22432
to look at the new patch set (#2).
Change subject: IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
......................................................................
IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
With this patch Impala skips reloading Iceberg tables when metadata
JSON file is the same, as this means that the table is essentially
unchanged.
This can help in situations when the event processor is lagging behind
and we have an Iceberg table that is updated frequently. Imagine the
case when Impala gets 100 events for an Iceberg table. In this case
after processing the first event, our internal representation of
the Iceberg table is already up-to-date, there is no need to do the
reload 100 times.
We cannot use the internal icebergApiTable_'s metadata location,
as the following statement silently refreshes the metadata
in 'current()':
icebergApiTable_.operations().current().metadataFileLocation()
To guarantee that we check against the actual loaded metadata
this patch introduces a new member to store the metadata location.
Testing
* added e2e tests for REFRESH, also for event processing
Change-Id: I16727000cb11d1c0591875a6542d428564dce664
---
M fe/src/main/java/org/apache/impala/catalog/IcebergTable.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-mixed-format-position-deletes.test
M tests/metadata/test_event_processing.py
3 files changed, 51 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/32/22432/2
--
To view, visit http://gerrit.cloudera.org:8080/22432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I16727000cb11d1c0591875a6542d428564dce664
Gerrit-Change-Number: 22432
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
[Impala-ASF-CR] IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22432 )
Change subject: IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11406/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/22432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16727000cb11d1c0591875a6542d428564dce664
Gerrit-Change-Number: 22432
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Feb 2025 15:50:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/22432 )
Change subject: IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22432/4/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java
File fe/src/main/java/org/apache/impala/catalog/IcebergTable.java:
http://gerrit.cloudera.org:8080/#/c/22432/4/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@551
PS4, Line 551: }
> Now that this set method is removed, I wonder if there is any way we can up
We can still directly update the field in this class. E.g. we do it in loadTableMetadata() at L489.
I stopped using this method because we now update icebergApiTable_ and currentMetadataLocation_ at different places.
--
To view, visit http://gerrit.cloudera.org:8080/22432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16727000cb11d1c0591875a6542d428564dce664
Gerrit-Change-Number: 22432
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 May 2025 14:41:47 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22432 )
Change subject: IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
......................................................................
Patch Set 5:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/19125/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/22432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16727000cb11d1c0591875a6542d428564dce664
Gerrit-Change-Number: 22432
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 May 2025 17:25:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Peter Rozsa, Noemi Pap-Takacs, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22432
to look at the new patch set (#4).
Change subject: IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
......................................................................
IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
With this patch Impala skips reloading Iceberg tables when metadata
JSON file is the same, as this means that the table is essentially
unchanged.
This can help in situations when the event processor is lagging behind
and we have an Iceberg table that is updated frequently. Imagine the
case when Impala gets 100 events for an Iceberg table. In this case
after processing the first event, our internal representation of
the Iceberg table is already up-to-date, there is no need to do the
reload 100 times.
We cannot use the internal icebergApiTable_'s metadata location,
as the following statement might silently refresh the metadata
in 'current()':
icebergApiTable_.operations().current().metadataFileLocation()
To guarantee that we check against the actual loaded metadata
this patch introduces a new member to store the metadata location.
Testing
* added e2e tests for REFRESH, also for event processing
Change-Id: I16727000cb11d1c0591875a6542d428564dce664
---
M fe/src/main/java/org/apache/impala/catalog/IcebergTable.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-mixed-format-position-deletes.test
M tests/metadata/test_event_processing.py
3 files changed, 113 insertions(+), 48 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/32/22432/4
--
To view, visit http://gerrit.cloudera.org:8080/22432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I16727000cb11d1c0591875a6542d428564dce664
Gerrit-Change-Number: 22432
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22432 )
Change subject: IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
......................................................................
Patch Set 3: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/11418/
--
To view, visit http://gerrit.cloudera.org:8080/22432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16727000cb11d1c0591875a6542d428564dce664
Gerrit-Change-Number: 22432
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Comment-Date: Thu, 06 Feb 2025 23:07:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/22432 )
Change subject: IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
......................................................................
Patch Set 5:
(3 comments)
Thanks for the comments!
http://gerrit.cloudera.org:8080/#/c/22432/4/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java
File fe/src/main/java/org/apache/impala/catalog/IcebergTable.java:
http://gerrit.cloudera.org:8080/#/c/22432/4/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@499
PS4, Line 499: unless
> nit: unless
Done
http://gerrit.cloudera.org:8080/#/c/22432/4/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@514
PS4, Line 514: upedContentFiles icebergFiles = IcebergUtil.getIcebergFiles(this,
: new ArrayList<>(), /*timeTravelSpec=*/null);
> I know this comment is from the original code, but I find it difficult to u
Thanks for the suggestion. I rephrased a bit to emphasize that Iceberg schema loading must precede hdfs table loading.
http://gerrit.cloudera.org:8080/#/c/22432/4/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@551
PS4, Line 551: }
> unused method, see also the comment on L246
Nice catch, done.
--
To view, visit http://gerrit.cloudera.org:8080/22432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16727000cb11d1c0591875a6542d428564dce664
Gerrit-Change-Number: 22432
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 May 2025 16:58:26 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/22432 )
Change subject: IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
......................................................................
Patch Set 3:
Fixing the column stats issue will be easier after IMPALA-13738.
--
To view, visit http://gerrit.cloudera.org:8080/22432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16727000cb11d1c0591875a6542d428564dce664
Gerrit-Change-Number: 22432
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 11 Feb 2025 15:25:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22432 )
Change subject: IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
......................................................................
Patch Set 2:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/18217/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/22432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16727000cb11d1c0591875a6542d428564dce664
Gerrit-Change-Number: 22432
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Comment-Date: Thu, 06 Feb 2025 16:50:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22432 )
Change subject: IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
......................................................................
Patch Set 4: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/11842/
--
To view, visit http://gerrit.cloudera.org:8080/22432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16727000cb11d1c0591875a6542d428564dce664
Gerrit-Change-Number: 22432
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 May 2025 15:55:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/22432 )
Change subject: IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/22432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16727000cb11d1c0591875a6542d428564dce664
Gerrit-Change-Number: 22432
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Fri, 07 Feb 2025 08:45:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22432 )
Change subject: IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
......................................................................
Patch Set 1:
(1 comment)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/22432/1/tests/metadata/test_event_processing.py
File tests/metadata/test_event_processing.py:
http://gerrit.cloudera.org:8080/#/c/22432/1/tests/metadata/test_event_processing.py@78
PS1, Line 78: h
flake8: F841 local variable 'hive_res' is assigned to but never used
--
To view, visit http://gerrit.cloudera.org:8080/22432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16727000cb11d1c0591875a6542d428564dce664
Gerrit-Change-Number: 22432
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Comment-Date: Fri, 31 Jan 2025 16:45:49 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22432 )
Change subject: IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/19123/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/22432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16727000cb11d1c0591875a6542d428564dce664
Gerrit-Change-Number: 22432
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 May 2025 10:09:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
Posted by "Noemi Pap-Takacs (Code Review)" <ge...@cloudera.org>.
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/22432 )
Change subject: IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
......................................................................
Patch Set 4:
(3 comments)
Thanks! Nice to see that a small refactor unblocked this patch. Feel free to improve it and remove any code from getPartialInfo() that may be redundant.
http://gerrit.cloudera.org:8080/#/c/22432/4/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java
File fe/src/main/java/org/apache/impala/catalog/IcebergTable.java:
http://gerrit.cloudera.org:8080/#/c/22432/4/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@499
PS4, Line 499: except
nit: unless
http://gerrit.cloudera.org:8080/#/c/22432/4/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@514
PS4, Line 514: Loading hdfs table after loaded schema from Iceberg,
: // in case we create external Iceberg table skipping column info in sql.
I know this comment is from the original code, but I find it difficult to understand. Could you please rephrase it? AFAIU it means something like:
"In case we create an external Iceberg table, we load the schema from Iceberg and not from the column info provided in the SQL statement."
http://gerrit.cloudera.org:8080/#/c/22432/4/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@551
PS4, Line 551: private void setIcebergApiTable(org.apache.iceberg.Table newIceTable) {
unused method, see also the comment on L246
--
To view, visit http://gerrit.cloudera.org:8080/22432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16727000cb11d1c0591875a6542d428564dce664
Gerrit-Change-Number: 22432
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 May 2025 12:05:15 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22432 )
Change subject: IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
......................................................................
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/22432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16727000cb11d1c0591875a6542d428564dce664
Gerrit-Change-Number: 22432
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 May 2025 22:51:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
Posted by "Noemi Pap-Takacs (Code Review)" <ge...@cloudera.org>.
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/22432 )
Change subject: IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
......................................................................
Patch Set 5:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/22432/4/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java
File fe/src/main/java/org/apache/impala/catalog/IcebergTable.java:
http://gerrit.cloudera.org:8080/#/c/22432/4/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@514
PS4, Line 514: upedContentFiles icebergFiles = IcebergUtil.getIcebergFiles(this,
: new ArrayList<>(), /*timeTravelSpec=*/null);
> Thanks for the suggestion. I rephrased a bit to emphasize that Iceberg sche
Nice explanation, thanks!
http://gerrit.cloudera.org:8080/#/c/22432/4/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@551
PS4, Line 551: }
> Nice catch, done.
Now that this set method is removed, I wonder if there is any way we can update the ApiTable, or is it necessary to be able to update it at all?
--
To view, visit http://gerrit.cloudera.org:8080/22432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16727000cb11d1c0591875a6542d428564dce664
Gerrit-Change-Number: 22432
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 May 2025 08:38:14 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
Posted by "Noemi Pap-Takacs (Code Review)" <ge...@cloudera.org>.
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/22432 )
Change subject: IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/22432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16727000cb11d1c0591875a6542d428564dce664
Gerrit-Change-Number: 22432
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 May 2025 11:36:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22432 )
Change subject: IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11850/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/22432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16727000cb11d1c0591875a6542d428564dce664
Gerrit-Change-Number: 22432
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 May 2025 08:42:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22432 )
Change subject: IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/18218/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/22432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16727000cb11d1c0591875a6542d428564dce664
Gerrit-Change-Number: 22432
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Comment-Date: Thu, 06 Feb 2025 17:22:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22432 )
Change subject: IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
......................................................................
Patch Set 1: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/11406/
--
To view, visit http://gerrit.cloudera.org:8080/22432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16727000cb11d1c0591875a6542d428564dce664
Gerrit-Change-Number: 22432
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Feb 2025 17:53:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22432 )
Change subject: IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11842/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/22432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16727000cb11d1c0591875a6542d428564dce664
Gerrit-Change-Number: 22432
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 May 2025 09:42:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22432 )
Change subject: IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11845/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/22432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16727000cb11d1c0591875a6542d428564dce664
Gerrit-Change-Number: 22432
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 May 2025 16:58:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22432 )
Change subject: IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
......................................................................
Patch Set 5:
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/11850/
--
To view, visit http://gerrit.cloudera.org:8080/22432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16727000cb11d1c0591875a6542d428564dce664
Gerrit-Change-Number: 22432
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 May 2025 15:07:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Peter Rozsa, Noemi Pap-Takacs, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22432
to look at the new patch set (#5).
Change subject: IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
......................................................................
IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
With this patch Impala skips reloading Iceberg tables when metadata
JSON file is the same, as this means that the table is essentially
unchanged.
This can help in situations when the event processor is lagging behind
and we have an Iceberg table that is updated frequently. Imagine the
case when Impala gets 100 events for an Iceberg table. In this case
after processing the first event, our internal representation of
the Iceberg table is already up-to-date, there is no need to do the
reload 100 times.
We cannot use the internal icebergApiTable_'s metadata location,
as the following statement might silently refresh the metadata
in 'current()':
icebergApiTable_.operations().current().metadataFileLocation()
To guarantee that we check against the actual loaded metadata
this patch introduces a new member to store the metadata location.
Testing
* added e2e tests for REFRESH, also for event processing
Change-Id: I16727000cb11d1c0591875a6542d428564dce664
---
M fe/src/main/java/org/apache/impala/catalog/IcebergTable.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-mixed-format-position-deletes.test
M tests/metadata/test_event_processing.py
3 files changed, 108 insertions(+), 47 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/32/22432/5
--
To view, visit http://gerrit.cloudera.org:8080/22432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I16727000cb11d1c0591875a6542d428564dce664
Gerrit-Change-Number: 22432
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22432 )
Change subject: IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
......................................................................
Patch Set 5: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/11845/
--
To view, visit http://gerrit.cloudera.org:8080/22432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16727000cb11d1c0591875a6542d428564dce664
Gerrit-Change-Number: 22432
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 May 2025 23:16:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22432 )
Change subject: IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11859/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/22432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16727000cb11d1c0591875a6542d428564dce664
Gerrit-Change-Number: 22432
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 May 2025 16:30:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22432 )
Change subject: IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/18150/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/22432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16727000cb11d1c0591875a6542d428564dce664
Gerrit-Change-Number: 22432
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Comment-Date: Fri, 31 Jan 2025 17:10:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22432 )
Change subject: IMPALA-13718: Skip reloading Iceberg tables when metadata JSON file is the same
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11418/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/22432
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16727000cb11d1c0591875a6542d428564dce664
Gerrit-Change-Number: 22432
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Comment-Date: Thu, 06 Feb 2025 17:36:01 +0000
Gerrit-HasComments: No