You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "jadams-tresys (via GitHub)" <gi...@apache.org> on 2023/03/03 12:23:33 UTC
[GitHub] [daffodil] jadams-tresys opened a new pull request, #978: Appease scalafmt with extraneous comma
jadams-tresys opened a new pull request, #978:
URL: https://github.com/apache/daffodil/pull/978
In my last PR I missed that scalafmt wasn't happy after I removed what I thought was an extraneous comma. The PR page said that all checks had passed, but it must have been stale and needed refreshing to see the scalamt fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] jadams-tresys merged pull request #978: Appease scalafmt with extraneous comma
Posted by "jadams-tresys (via GitHub)" <gi...@apache.org>.
jadams-tresys merged PR #978:
URL: https://github.com/apache/daffodil/pull/978
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] jadams-tresys commented on pull request #978: Appease scalafmt with extraneous comma
Posted by "jadams-tresys (via GitHub)" <gi...@apache.org>.
jadams-tresys commented on PR #978:
URL: https://github.com/apache/daffodil/pull/978#issuecomment-1453509246
Ah, I think I realized what happened. On my one machine I have my "origin" set to my daffodil fork, but the other machine 'origin' points to the main branch. My mistake there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] stevedlawrence commented on pull request #978: Appease scalafmt with extraneous comma
Posted by "stevedlawrence (via GitHub)" <gi...@apache.org>.
stevedlawrence commented on PR #978:
URL: https://github.com/apache/daffodil/pull/978#issuecomment-1453516016
> We should add this command to some setup instructions.
Good call. I've added it to step 6 of the [Code Contributor Workflow](https://cwiki.apache.org/confluence/display/DAFFODIL/Code+Contributor+Workflow)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] mbeckerle commented on pull request #978: Appease scalafmt with extraneous comma
Posted by "mbeckerle (via GitHub)" <gi...@apache.org>.
mbeckerle commented on PR #978:
URL: https://github.com/apache/daffodil/pull/978#issuecomment-1453503699
We should add this command to some setup instructions.
I plan to use this on all my github/gitlab based projects that use the
fork+review discipline
On Fri, Mar 3, 2023 at 8:00 AM Steve Lawrence ***@***.***>
wrote:
> ***@***.**** approved this pull request.
>
> +1, I'm not sure why there's all the extra runs in the github actions.
> Maybe it's because you accidentally pushed to the apache/daffodil repo
> instead of your fork? FYI, I came acrossd a bit of a hack that prevents
> this: Assuming "asf" is your apache/daffodil remote, you can do:
>
> git remote set-url --push asf "push to apache/daffodil disabled"
>
> This is a hack because it changes the push url for the asf remote to a
> string that doesn't resolve to an actual repo. So git will complain if you
> ever try to push to asf.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/daffodil/pull/978#pullrequestreview-1323761313>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AALUDAZIKGS2ZHEHW2F2NDTW2HTPHANCNFSM6AAAAAAVORQC54>
> .
> You are receiving this because you are subscribed to this thread.Message
> ID: ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] mbeckerle commented on a diff in pull request #978: Appease scalafmt with extraneous comma
Posted by "mbeckerle (via GitHub)" <gi...@apache.org>.
mbeckerle commented on code in PR #978:
URL: https://github.com/apache/daffodil/pull/978#discussion_r1124443668
##########
daffodil-core/src/main/scala/org/apache/daffodil/core/dsom/GroupDef.scala:
##########
@@ -141,7 +141,7 @@ sealed abstract class GlobalGroupDef(
if (dais.nonEmpty)
SDW(
WarnID.InvalidAnnotationPoint,
- "Annotations placed directly on a group definition will be ignored by DFDL. Any annotation expected to be processed by DFDL should instead be placed on the group reference, sequence or choice."
+ "Annotations placed directly on a group definition will be ignored by DFDL. Any annotation expected to be processed by DFDL should instead be placed on the group reference, sequence or choice.",
Review Comment:
If this comma is truly required, then our scalafmt rules are wrong.
This comma should be tolerated, ... maybe... but not required.
This is not a list, it's the arguments to a function call. They are fundamentally different concepts that only occasionally overlap.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] mbeckerle commented on pull request #978: Appease scalafmt with extraneous comma
Posted by "mbeckerle (via GitHub)" <gi...@apache.org>.
mbeckerle commented on PR #978:
URL: https://github.com/apache/daffodil/pull/978#issuecomment-1453519979
Honestly, the only way I stay sane with git is no remote is named "origin". I name them all based on who owns them. My fork is named mbeckerle. If for review I pull down someone else' fork to look at more closely than a github review, the name of that remote is that person's username. The central daffodil repo is named "asf", at my job the central repos for other projects are named "owl", or if they are for clients it's the client/project's name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org