You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/03/10 22:17:11 UTC
[GitHub] [incubator-superset] villebro opened a new pull request #9274: fix:
remove duplicate metric from bullet chart
villebro opened a new pull request #9274: fix: remove duplicate metric from bullet chart
URL: https://github.com/apache/incubator-superset/pull/9274
### CATEGORY
Choose one
- [x] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
In the Bullet Chart control panel, `metric` is defined twice, causing a weird user experience and duplicated metrics in the viz request payload.
### BEFORE
### AFTER
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro merged pull request #9274: fix:
remove duplicate metric from bullet chart
Posted by GitBox <gi...@apache.org>.
villebro merged pull request #9274: fix: remove duplicate metric from bullet chart
URL: https://github.com/apache/incubator-superset/pull/9274
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #9274: fix:
remove duplicate metric from bullet chart
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #9274: fix: remove duplicate metric from bullet chart
URL: https://github.com/apache/incubator-superset/pull/9274#issuecomment-597388091
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9274?src=pr&el=h1) Report
> Merging [#9274](https://codecov.io/gh/apache/incubator-superset/pull/9274?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/724b8a3c310a123b5c41a294c88b651b39409876?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9274?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9274 +/- ##
======================================
Coverage 58.9% 58.9%
======================================
Files 373 373
Lines 12026 12026
Branches 2953 2953
======================================
Hits 7084 7084
Misses 4763 4763
Partials 179 179
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9274?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9274?src=pr&el=footer). Last update [724b8a3...0004470](https://codecov.io/gh/apache/incubator-superset/pull/9274?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org