You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/25 06:43:16 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5330: board/Board.mk: Make romfs_img 4 byte aligned

xiaoxiang781216 commented on a change in pull request #5330:
URL: https://github.com/apache/incubator-nuttx/pull/5330#discussion_r791400330



##########
File path: boards/Board.mk
##########
@@ -36,7 +36,7 @@ $(ETCSRC): $(RCRAWS) $(RCOBJS)
 	  $(shell mkdir -p $(dir $(ETCDIR)$(DELIM)$(raw))) \
 	  $(shell cp -rfp $(raw) $(ETCDIR)$(DELIM)$(raw)))
 	$(Q) genromfs -f romfs.img -d $(ETCDIR)$(DELIM)$(CONFIG_NSH_ROMFSMOUNTPT) -V "$(basename $<)"
-	$(Q) xxd -i romfs.img | sed -e "s/^unsigned/const unsigned/g" > $@
+	$(Q) xxd -i romfs.img | sed -e "s/^unsigned char/const unsigned char __attribute__((aligned(4)))/g" > $@

Review comment:
       It's hard or unnecessary to include compiler.h for the dynamic generated code.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org