You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by mike-jumper <gi...@git.apache.org> on 2018/06/17 07:14:18 UTC
[GitHub] guacamole-server pull request #172: GUACAMOLE-573: Allow selection of text w...
GitHub user mike-jumper opened a pull request:
https://github.com/apache/guacamole-server/pull/172
GUACAMOLE-573: Allow selection of text while scrolling.
This change adds the ability to select text while scrolling Guacamole's terminal emulator. The current selection is preserved while the user scrolls and can be expanded by holding Shift and left-clicking elsewhere within the terminal, even if parts of the selection are off-screen.
Selecting text by holding the mouse button down while scrolling using the mouse scrollwheel (or Shift+Page Up/Down) also works, though doing so involves uncomfortable finger gymnastics.
Implementing this required isolating and rearranging the text selection logic in a way that implicitly addresses [GUACAMOLE-191](https://issues.apache.org/jira/browse/GUACAMOLE-191) ("Allow deselection of text in terminal by single clicking").
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mike-jumper/guacamole-server select-scroll
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/guacamole-server/pull/172.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #172
----
commit f87af06ad69af16702ceb96477470607be060111
Author: Michael Jumper <mj...@...>
Date: 2018-06-17T01:12:19Z
GUACAMOLE-573: Move terminal text selection code into own file.
commit c0d323828e1db5c3068c5d9e7730690dcad80460
Author: Michael Jumper <mj...@...>
Date: 2018-06-17T02:43:26Z
GUACAMOLE-573: Copy terminal data directly into clipboard. Do not assume selected region will be strictly visible.
commit 6f08ef2a07b8f908cc0ce8a9f82f846f3b73a7cd
Author: Michael Jumper <mj...@...>
Date: 2018-06-17T05:50:20Z
GUACAMOLE-573: Allow text selection to be expanded using Shift (fixes GUACAMOLE-191).
commit 1756c015228ab528ad65ee20eb6ecc01df2cd390
Author: Michael Jumper <mj...@...>
Date: 2018-06-17T06:09:43Z
GUACAMOLE-573: Update selected region when terminal scrolls.
commit ecda5c1df958ac9725b0bcbe2897ec43163aea29
Author: Michael Jumper <mj...@...>
Date: 2018-06-17T06:36:01Z
GUACAMOLE-573: Read selection only within bounds of terminal/scrollback.
----
---
[GitHub] guacamole-server pull request #172: GUACAMOLE-573: Allow selection of text w...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/guacamole-server/pull/172
---