You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Mona Chitnis <mo...@yahoo.in> on 2013/09/04 05:47:31 UTC
Review Request 13961: OOZIE-1503 [DB optimization] revisit eagerLoadState at
places
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13961/
-----------------------------------------------------------
Review request for oozie.
Bugs: OOZIE-1503
https://issues.apache.org/jira/browse/OOZIE-1503
Repository: oozie
Description
-------
Patch to revisit eagerLoadState calls causing multiple DB calls, at times redundant, and to load only select columns for eagerLoadState where applicable. This JIRA depends on OOZIE-1499, and builds on top of the QueryExecutors code from there. I'll rebase the patch once OOZIE-1499 is committed.
Diffs
-----
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java 1519764
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleStatusUpdateXCommand.java 1519764
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1519764
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1519764
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1519764
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1519764
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 1519764
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 1519764
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 1519764
trunk/core/src/main/java/org/apache/oozie/command/wf/CompletedActionXCommand.java 1519764
trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 1519764
trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1519764
trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1519764
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleActionQueryExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobQueryExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/QueryExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/service/StatusTransitService.java 1519764
trunk/core/src/test/java/org/apache/oozie/service/TestRecoveryService.java 1519764
Diff: https://reviews.apache.org/r/13961/diff/
Testing
-------
Thanks,
Mona Chitnis
Re: Review Request 13961: OOZIE-1503 [DB optimization] revisit
eagerLoadState at places
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13961/#review26359
-----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java
<https://reviews.apache.org/r/13961/#comment51467>
Delete BundleActionsGetJPAExecutor
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java
<https://reviews.apache.org/r/13961/#comment51446>
Set it in the QueryExecutor itself instead of setting it here.
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleKillXCommand.java
<https://reviews.apache.org/r/13961/#comment51447>
Remove jpa service
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java
<https://reviews.apache.org/r/13961/#comment51448>
Remove jpa service
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java
<https://reviews.apache.org/r/13961/#comment51453>
We need these retries
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java
<https://reviews.apache.org/r/13961/#comment51454>
Remove this
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java
<https://reviews.apache.org/r/13961/#comment51455>
Do not change the signature of overriding method
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java
<https://reviews.apache.org/r/13961/#comment51456>
eagerVerifyPrecondition is removed. Should be there
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java
<https://reviews.apache.org/r/13961/#comment51457>
keep the retries
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java
<https://reviews.apache.org/r/13961/#comment51458>
keep the retry
trunk/core/src/main/java/org/apache/oozie/command/wf/CompletedActionXCommand.java
<https://reviews.apache.org/r/13961/#comment51459>
we should keep eagerLoad for this one.
trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java
<https://reviews.apache.org/r/13961/#comment51460>
Remove this
trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java
<https://reviews.apache.org/r/13961/#comment51462>
We should keep it
trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java
<https://reviews.apache.org/r/13961/#comment51463>
We should keep it
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobQueryExecutor.java
<https://reviews.apache.org/r/13961/#comment51464>
set the bundle id here
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java
<https://reviews.apache.org/r/13961/#comment51465>
set coord id here
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java
<https://reviews.apache.org/r/13961/#comment51466>
Why this change?
- Rohini Palaniswamy
On Sept. 24, 2013, 7:34 a.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13961/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2013, 7:34 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1503
> https://issues.apache.org/jira/browse/OOZIE-1503
>
>
> Repository: oozie
>
>
> Description
> -------
>
> Patch to revisit eagerLoadState calls causing multiple DB calls, at times redundant, and to load only select columns for eagerLoadState where applicable
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1525636
> trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1525636
> trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1525636
> trunk/core/src/main/java/org/apache/oozie/WorkflowActionBean.java 1525636
> trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1525636
> trunk/core/src/main/java/org/apache/oozie/command/RerunTransitionXCommand.java 1525636
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java 1525636
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobResumeXCommand.java 1525636
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java 1525636
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleKillXCommand.java 1525636
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java 1525636
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleStartXCommand.java 1525636
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleStatusUpdateXCommand.java 1525636
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java 1525636
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1525636
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1525636
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1525636
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1525636
> trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 1525636
> trunk/core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 1525636
> trunk/core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 1525636
> trunk/core/src/main/java/org/apache/oozie/command/wf/CompletedActionXCommand.java 1525636
> trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 1525636
> trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1525636
> trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1525636
> trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1525636
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleActionQueryExecutor.java 1525636
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobQueryExecutor.java 1525636
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 1525636
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 1525636
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java 1525636
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 1525636
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleActionQueryExecutor.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobQueryExecutor.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobQueryExecutor.java 1525636
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionQueryExecutor.java 1525636
>
> Diff: https://reviews.apache.org/r/13961/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request 13961: OOZIE-1503 [DB optimization] revisit
eagerLoadState at places
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13961/#review26382
-----------------------------------------------------------
Ship it!
Ship It!
- Rohini Palaniswamy
On Sept. 25, 2013, 6:43 p.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13961/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2013, 6:43 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1503
> https://issues.apache.org/jira/browse/OOZIE-1503
>
>
> Repository: oozie
>
>
> Description
> -------
>
> Patch to revisit eagerLoadState calls causing multiple DB calls, at times redundant, and to load only select columns for eagerLoadState where applicable
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/BundleActionBean.java 1526048
> trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1526048
> trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1526048
> trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1526048
> trunk/core/src/main/java/org/apache/oozie/WorkflowActionBean.java 1526048
> trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1526048
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java 1526048
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobResumeXCommand.java 1526048
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java 1526048
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleKillXCommand.java 1526048
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java 1526048
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleStartXCommand.java 1526048
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleStatusUpdateXCommand.java 1526048
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java 1526048
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1526048
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1526048
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1526048
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1526048
> trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 1526048
> trunk/core/src/main/java/org/apache/oozie/command/wf/CompletedActionXCommand.java 1526048
> trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 1526048
> trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1526048
> trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1526048
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleActionQueryExecutor.java 1526048
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleActionsGetJPAExecutor.java 1526048
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobQueryExecutor.java 1526048
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 1526048
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 1526048
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java 1526048
> trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobSuspendXCommand.java 1526048
> trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleKillXCommand.java 1526048
> trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleStartXCommand.java 1526048
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleActionQueryExecutor.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobQueryExecutor.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobQueryExecutor.java 1526048
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionQueryExecutor.java 1526048
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobQueryExecutor.java 1526048
> trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 1526048
>
> Diff: https://reviews.apache.org/r/13961/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request 13961: OOZIE-1503 [DB optimization] revisit
eagerLoadState at places
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13961/
-----------------------------------------------------------
(Updated Sept. 25, 2013, 6:43 p.m.)
Review request for oozie.
Changes
-------
Changed SuspendX loadstate to load more needed columns with GET_WORKFLOW_SUSPEND, while eagerLoad gets GET_WORKFLOW_STATUS only
Bugs: OOZIE-1503
https://issues.apache.org/jira/browse/OOZIE-1503
Repository: oozie
Description
-------
Patch to revisit eagerLoadState calls causing multiple DB calls, at times redundant, and to load only select columns for eagerLoadState where applicable
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/BundleActionBean.java 1526048
trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1526048
trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1526048
trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1526048
trunk/core/src/main/java/org/apache/oozie/WorkflowActionBean.java 1526048
trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1526048
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java 1526048
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobResumeXCommand.java 1526048
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java 1526048
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleKillXCommand.java 1526048
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java 1526048
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleStartXCommand.java 1526048
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleStatusUpdateXCommand.java 1526048
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java 1526048
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1526048
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1526048
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1526048
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1526048
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 1526048
trunk/core/src/main/java/org/apache/oozie/command/wf/CompletedActionXCommand.java 1526048
trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 1526048
trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1526048
trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1526048
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleActionQueryExecutor.java 1526048
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleActionsGetJPAExecutor.java 1526048
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobQueryExecutor.java 1526048
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 1526048
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 1526048
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java 1526048
trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobSuspendXCommand.java 1526048
trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleKillXCommand.java 1526048
trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleStartXCommand.java 1526048
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleActionQueryExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobQueryExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobQueryExecutor.java 1526048
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionQueryExecutor.java 1526048
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobQueryExecutor.java 1526048
trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 1526048
Diff: https://reviews.apache.org/r/13961/diff/
Testing
-------
Thanks,
Mona Chitnis
Re: Review Request 13961: OOZIE-1503 [DB optimization] revisit
eagerLoadState at places
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13961/
-----------------------------------------------------------
(Updated Sept. 25, 2013, 4:49 p.m.)
Review request for oozie.
Changes
-------
addressed last comments
Bugs: OOZIE-1503
https://issues.apache.org/jira/browse/OOZIE-1503
Repository: oozie
Description
-------
Patch to revisit eagerLoadState calls causing multiple DB calls, at times redundant, and to load only select columns for eagerLoadState where applicable
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/BundleActionBean.java 1526048
trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1526048
trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1526048
trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1526048
trunk/core/src/main/java/org/apache/oozie/WorkflowActionBean.java 1526048
trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1526048
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java 1526048
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobResumeXCommand.java 1526048
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java 1526048
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleKillXCommand.java 1526048
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java 1526048
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleStartXCommand.java 1526048
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleStatusUpdateXCommand.java 1526048
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java 1526048
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1526048
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1526048
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1526048
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1526048
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 1526048
trunk/core/src/main/java/org/apache/oozie/command/wf/CompletedActionXCommand.java 1526048
trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 1526048
trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1526048
trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1526048
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleActionQueryExecutor.java 1526048
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleActionsGetJPAExecutor.java 1526048
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobQueryExecutor.java 1526048
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 1526048
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 1526048
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java 1526048
trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobSuspendXCommand.java 1526048
trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleKillXCommand.java 1526048
trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleStartXCommand.java 1526048
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleActionQueryExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobQueryExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobQueryExecutor.java 1526048
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionQueryExecutor.java 1526048
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobQueryExecutor.java 1526048
trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 1526048
Diff: https://reviews.apache.org/r/13961/diff/
Testing
-------
Thanks,
Mona Chitnis
Re: Review Request 13961: OOZIE-1503 [DB optimization] revisit
eagerLoadState at places
Posted by Mona Chitnis <mo...@yahoo.in>.
> On Sept. 25, 2013, 4:04 p.m., Rohini Palaniswamy wrote:
> > trunk/core/src/main/java/org/apache/oozie/command/wf/CompletedActionXCommand.java, line 60
> > <https://reviews.apache.org/r/13961/diff/4-5/?file=356571#file356571line60>
> >
> > Isn't status enough for eagerload?
GET_ATION_COMPLETED only gets minor fields - id, job-id, status, type and logtoken which will be < 10KB combined
> On Sept. 25, 2013, 4:04 p.m., Rohini Palaniswamy wrote:
> > trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java, line 147
> > <https://reviews.apache.org/r/13961/diff/4-5/?file=356574#file356574line147>
> >
> > jpa service not required
jpaService object is being passed later to setPendingFalseForActions() and actions = jpaService.execute(new WorkflowActionRetryManualGetJPAExecutor(id)); So initialization will be required here. removing the null check
- Mona
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13961/#review26376
-----------------------------------------------------------
On Sept. 25, 2013, 3:31 p.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13961/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2013, 3:31 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1503
> https://issues.apache.org/jira/browse/OOZIE-1503
>
>
> Repository: oozie
>
>
> Description
> -------
>
> Patch to revisit eagerLoadState calls causing multiple DB calls, at times redundant, and to load only select columns for eagerLoadState where applicable
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/BundleActionBean.java 1526048
> trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1526048
> trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1526048
> trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1526048
> trunk/core/src/main/java/org/apache/oozie/WorkflowActionBean.java 1526048
> trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1526048
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java 1526048
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobResumeXCommand.java 1526048
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java 1526048
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleKillXCommand.java 1526048
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java 1526048
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleStartXCommand.java 1526048
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleStatusUpdateXCommand.java 1526048
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java 1526048
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1526048
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1526048
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1526048
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1526048
> trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 1526048
> trunk/core/src/main/java/org/apache/oozie/command/wf/CompletedActionXCommand.java 1526048
> trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 1526048
> trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1526048
> trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1526048
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleActionQueryExecutor.java 1526048
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleActionsGetJPAExecutor.java 1526048
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobQueryExecutor.java 1526048
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 1526048
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 1526048
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java 1526048
> trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobSuspendXCommand.java 1526048
> trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleKillXCommand.java 1526048
> trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleStartXCommand.java 1526048
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleActionQueryExecutor.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobQueryExecutor.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobQueryExecutor.java 1526048
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionQueryExecutor.java 1526048
> trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 1526048
>
> Diff: https://reviews.apache.org/r/13961/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request 13961: OOZIE-1503 [DB optimization] revisit
eagerLoadState at places
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13961/#review26376
-----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/command/wf/CompletedActionXCommand.java
<https://reviews.apache.org/r/13961/#comment51516>
Isn't status enough for eagerload?
trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java
<https://reviews.apache.org/r/13961/#comment51518>
jpa service not required
trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java
<https://reviews.apache.org/r/13961/#comment51519>
Isn't status enough for eagerload
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java
<https://reviews.apache.org/r/13961/#comment51520>
Pass parameters ... instead of [0]
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java
<https://reviews.apache.org/r/13961/#comment51517>
To be removed
- Rohini Palaniswamy
On Sept. 25, 2013, 3:31 p.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13961/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2013, 3:31 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1503
> https://issues.apache.org/jira/browse/OOZIE-1503
>
>
> Repository: oozie
>
>
> Description
> -------
>
> Patch to revisit eagerLoadState calls causing multiple DB calls, at times redundant, and to load only select columns for eagerLoadState where applicable
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/BundleActionBean.java 1526048
> trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1526048
> trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1526048
> trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1526048
> trunk/core/src/main/java/org/apache/oozie/WorkflowActionBean.java 1526048
> trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1526048
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java 1526048
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobResumeXCommand.java 1526048
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java 1526048
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleKillXCommand.java 1526048
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java 1526048
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleStartXCommand.java 1526048
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleStatusUpdateXCommand.java 1526048
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java 1526048
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1526048
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1526048
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1526048
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1526048
> trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 1526048
> trunk/core/src/main/java/org/apache/oozie/command/wf/CompletedActionXCommand.java 1526048
> trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 1526048
> trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1526048
> trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1526048
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleActionQueryExecutor.java 1526048
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleActionsGetJPAExecutor.java 1526048
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobQueryExecutor.java 1526048
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 1526048
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 1526048
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java 1526048
> trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobSuspendXCommand.java 1526048
> trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleKillXCommand.java 1526048
> trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleStartXCommand.java 1526048
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleActionQueryExecutor.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobQueryExecutor.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobQueryExecutor.java 1526048
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionQueryExecutor.java 1526048
> trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 1526048
>
> Diff: https://reviews.apache.org/r/13961/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request 13961: OOZIE-1503 [DB optimization] revisit
eagerLoadState at places
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13961/
-----------------------------------------------------------
(Updated Sept. 25, 2013, 3:31 p.m.)
Review request for oozie.
Changes
-------
addressed Rohini's comments. unit tests (except flaky one) pass
Bugs: OOZIE-1503
https://issues.apache.org/jira/browse/OOZIE-1503
Repository: oozie
Description
-------
Patch to revisit eagerLoadState calls causing multiple DB calls, at times redundant, and to load only select columns for eagerLoadState where applicable
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/BundleActionBean.java 1526048
trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1526048
trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1526048
trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1526048
trunk/core/src/main/java/org/apache/oozie/WorkflowActionBean.java 1526048
trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1526048
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java 1526048
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobResumeXCommand.java 1526048
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java 1526048
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleKillXCommand.java 1526048
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java 1526048
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleStartXCommand.java 1526048
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleStatusUpdateXCommand.java 1526048
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java 1526048
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1526048
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1526048
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1526048
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1526048
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 1526048
trunk/core/src/main/java/org/apache/oozie/command/wf/CompletedActionXCommand.java 1526048
trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 1526048
trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1526048
trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1526048
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleActionQueryExecutor.java 1526048
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleActionsGetJPAExecutor.java 1526048
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobQueryExecutor.java 1526048
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 1526048
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 1526048
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java 1526048
trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobSuspendXCommand.java 1526048
trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleKillXCommand.java 1526048
trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleStartXCommand.java 1526048
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleActionQueryExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobQueryExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobQueryExecutor.java 1526048
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionQueryExecutor.java 1526048
trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java 1526048
Diff: https://reviews.apache.org/r/13961/diff/
Testing
-------
Thanks,
Mona Chitnis
Re: Review Request 13961: OOZIE-1503 [DB optimization] revisit
eagerLoadState at places
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13961/#review26362
-----------------------------------------------------------
Ship it!
Ship It!
- Ryota Egashira
On Sept. 24, 2013, 7:34 a.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13961/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2013, 7:34 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1503
> https://issues.apache.org/jira/browse/OOZIE-1503
>
>
> Repository: oozie
>
>
> Description
> -------
>
> Patch to revisit eagerLoadState calls causing multiple DB calls, at times redundant, and to load only select columns for eagerLoadState where applicable
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1525636
> trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1525636
> trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1525636
> trunk/core/src/main/java/org/apache/oozie/WorkflowActionBean.java 1525636
> trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1525636
> trunk/core/src/main/java/org/apache/oozie/command/RerunTransitionXCommand.java 1525636
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java 1525636
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobResumeXCommand.java 1525636
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java 1525636
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleKillXCommand.java 1525636
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java 1525636
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleStartXCommand.java 1525636
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleStatusUpdateXCommand.java 1525636
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java 1525636
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1525636
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1525636
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1525636
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1525636
> trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 1525636
> trunk/core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 1525636
> trunk/core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 1525636
> trunk/core/src/main/java/org/apache/oozie/command/wf/CompletedActionXCommand.java 1525636
> trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 1525636
> trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1525636
> trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1525636
> trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1525636
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleActionQueryExecutor.java 1525636
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobQueryExecutor.java 1525636
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 1525636
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 1525636
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java 1525636
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 1525636
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleActionQueryExecutor.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobQueryExecutor.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobQueryExecutor.java 1525636
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionQueryExecutor.java 1525636
>
> Diff: https://reviews.apache.org/r/13961/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request 13961: OOZIE-1503 [DB optimization] revisit
eagerLoadState at places
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13961/
-----------------------------------------------------------
(Updated Sept. 24, 2013, 7:34 a.m.)
Review request for oozie.
Changes
-------
addressed Ryota's comments and fixed failing tests
Bugs: OOZIE-1503
https://issues.apache.org/jira/browse/OOZIE-1503
Repository: oozie
Description
-------
Patch to revisit eagerLoadState calls causing multiple DB calls, at times redundant, and to load only select columns for eagerLoadState where applicable
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1525636
trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1525636
trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1525636
trunk/core/src/main/java/org/apache/oozie/WorkflowActionBean.java 1525636
trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1525636
trunk/core/src/main/java/org/apache/oozie/command/RerunTransitionXCommand.java 1525636
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java 1525636
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobResumeXCommand.java 1525636
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java 1525636
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleKillXCommand.java 1525636
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java 1525636
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleStartXCommand.java 1525636
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleStatusUpdateXCommand.java 1525636
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java 1525636
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1525636
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1525636
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1525636
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1525636
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 1525636
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 1525636
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 1525636
trunk/core/src/main/java/org/apache/oozie/command/wf/CompletedActionXCommand.java 1525636
trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 1525636
trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1525636
trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1525636
trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1525636
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleActionQueryExecutor.java 1525636
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobQueryExecutor.java 1525636
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 1525636
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 1525636
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java 1525636
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 1525636
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleActionQueryExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobQueryExecutor.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobQueryExecutor.java 1525636
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionQueryExecutor.java 1525636
Diff: https://reviews.apache.org/r/13961/diff/
Testing
-------
Thanks,
Mona Chitnis
Re: Review Request 13961: OOZIE-1503 [DB optimization] revisit
eagerLoadState at places
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13961/#review26323
-----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java
<https://reviews.apache.org/r/13961/#comment51419>
the same comment for GET_COORD_JOB_STATUS,
originally thought it's cleaner to add w.id in namedquery, but GET_BUNDLE_JOB_STATUS is used only here anyway, so it is fine.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java
<https://reviews.apache.org/r/13961/#comment51418>
originally thought it is cleaner to add w.id in namedQuery while removing coordJob.setId here, but this is only place to use GET_COORD_JOB_STATUS, so it is fine.
trunk/core/src/main/java/org/apache/oozie/command/wf/CompletedActionXCommand.java
<https://reviews.apache.org/r/13961/#comment51417>
isn't loadState the same with eagerloadState? can avoid repetition
- Ryota Egashira
On Sept. 20, 2013, 11:23 p.m., Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13961/
> -----------------------------------------------------------
>
> (Updated Sept. 20, 2013, 11:23 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1503
> https://issues.apache.org/jira/browse/OOZIE-1503
>
>
> Repository: oozie
>
>
> Description
> -------
>
> Patch to revisit eagerLoadState calls causing multiple DB calls, at times redundant, and to load only select columns for eagerLoadState where applicable
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1525149
> trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1525149
> trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1525149
> trunk/core/src/main/java/org/apache/oozie/WorkflowActionBean.java 1525149
> trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1525149
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java 1525149
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobResumeXCommand.java 1525149
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java 1525149
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleKillXCommand.java 1525149
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java 1525149
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleStartXCommand.java 1525149
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleStatusUpdateXCommand.java 1525149
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java 1525149
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1525149
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1525149
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1525149
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1525149
> trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 1525149
> trunk/core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 1525149
> trunk/core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 1525149
> trunk/core/src/main/java/org/apache/oozie/command/wf/CompletedActionXCommand.java 1525149
> trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 1525149
> trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1525149
> trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1525149
> trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1525149
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleActionQueryExecutor.java 1525149
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobQueryExecutor.java 1525149
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 1525149
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 1525149
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java 1525149
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionQueryExecutor.java 1525149
>
> Diff: https://reviews.apache.org/r/13961/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mona Chitnis
>
>
Re: Review Request 13961: OOZIE-1503 [DB optimization] revisit
eagerLoadState at places
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13961/
-----------------------------------------------------------
(Updated Sept. 20, 2013, 11:23 p.m.)
Review request for oozie.
Changes
-------
fixed some missing queries for unit test failures.
Bugs: OOZIE-1503
https://issues.apache.org/jira/browse/OOZIE-1503
Repository: oozie
Description (updated)
-------
Patch to revisit eagerLoadState calls causing multiple DB calls, at times redundant, and to load only select columns for eagerLoadState where applicable
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1525149
trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1525149
trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1525149
trunk/core/src/main/java/org/apache/oozie/WorkflowActionBean.java 1525149
trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1525149
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java 1525149
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobResumeXCommand.java 1525149
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java 1525149
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleKillXCommand.java 1525149
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java 1525149
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleStartXCommand.java 1525149
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleStatusUpdateXCommand.java 1525149
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java 1525149
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1525149
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1525149
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1525149
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1525149
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 1525149
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 1525149
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 1525149
trunk/core/src/main/java/org/apache/oozie/command/wf/CompletedActionXCommand.java 1525149
trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 1525149
trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1525149
trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1525149
trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1525149
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleActionQueryExecutor.java 1525149
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobQueryExecutor.java 1525149
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 1525149
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 1525149
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java 1525149
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionQueryExecutor.java 1525149
Diff: https://reviews.apache.org/r/13961/diff/
Testing
-------
Thanks,
Mona Chitnis
Re: Review Request 13961: OOZIE-1503 [DB optimization] revisit
eagerLoadState at places
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13961/
-----------------------------------------------------------
(Updated Sept. 20, 2013, 9:53 p.m.)
Review request for oozie.
Changes
-------
Changed BundleJob and BundleAction QueryExecutors as needed. Investigating some unit test failures
Bugs: OOZIE-1503
https://issues.apache.org/jira/browse/OOZIE-1503
Repository: oozie
Description
-------
Patch to revisit eagerLoadState calls causing multiple DB calls, at times redundant, and to load only select columns for eagerLoadState where applicable. This JIRA depends on OOZIE-1499, and builds on top of the QueryExecutors code from there. I'll rebase the patch once OOZIE-1499 is committed.
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1525149
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java 1525149
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobResumeXCommand.java 1525149
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java 1525149
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleKillXCommand.java 1525149
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleRerunXCommand.java 1525149
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleStartXCommand.java 1525149
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleStatusUpdateXCommand.java 1525149
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java 1525149
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 1525149
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionUpdateXCommand.java 1525149
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1525149
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 1525149
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java 1525149
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 1525149
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 1525149
trunk/core/src/main/java/org/apache/oozie/command/wf/CompletedActionXCommand.java 1525149
trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 1525149
trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 1525149
trunk/core/src/main/java/org/apache/oozie/command/wf/SuspendXCommand.java 1525149
trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java 1525149
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleActionQueryExecutor.java 1525149
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobQueryExecutor.java 1525149
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 1525149
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 1525149
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java 1525149
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionQueryExecutor.java 1525149
Diff: https://reviews.apache.org/r/13961/diff/
Testing
-------
Thanks,
Mona Chitnis