You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by markap14 <gi...@git.apache.org> on 2018/08/14 13:04:12 UTC

[GitHub] nifi-registry pull request #136: NIFIREG-194: Updated VersionedConnection to...

GitHub user markap14 opened a pull request:

    https://github.com/apache/nifi-registry/pull/136

    NIFIREG-194: Updated VersionedConnection to support load balancing co…

    …nfiguration

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/markap14/nifi-registry NIFIREG-194

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi-registry/pull/136.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #136
    
----
commit c22f49d42a8637d179a2fb8ec06bc7aff27c50b7
Author: Mark Payne <ma...@...>
Date:   2018-08-14T13:03:38Z

    NIFIREG-194: Updated VersionedConnection to support load balancing configuration

----


---

[GitHub] nifi-registry pull request #136: NIFIREG-194: Updated VersionedConnection to...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/nifi-registry/pull/136


---

[GitHub] nifi-registry issue #136: NIFIREG-194: Updated VersionedConnection to suppor...

Posted by bbende <gi...@git.apache.org>.
Github user bbende commented on the issue:

    https://github.com/apache/nifi-registry/pull/136
  
    Looks good to me, will merge, thanks!


---

[GitHub] nifi-registry pull request #136: NIFIREG-194: Updated VersionedConnection to...

Posted by bbende <gi...@git.apache.org>.
Github user bbende commented on a diff in the pull request:

    https://github.com/apache/nifi-registry/pull/136#discussion_r209961895
  
    --- Diff: nifi-registry-data-model/src/main/java/org/apache/nifi/registry/flow/VersionedConnection.java ---
    @@ -134,6 +139,36 @@ public void setPrioritizers(List<String> prioritizers) {
             this.prioritizers = prioritizers;
         }
     
    +    @ApiModelProperty(value = "The Strategy to use for load balancing data across the cluster, or null, if no Load Balance Strategy has been specified.",
    +            allowableValues = "DO_NOT_LOAD_BALANCE, PARTITION_BY_ATTRIBUTE, ROUND_ROBIN")
    +    public String getLoadBalanceStrategy() {
    +        return loadBalanceStrategy;
    +    }
    +
    +    public void setLoadBalanceStrategy(String loadBalanceStrategy) {
    +        this.loadBalanceStrategy = loadBalanceStrategy;
    +    }
    +
    +    @ApiModelProperty("The attribute to use for partitioning data as it is load balanced across the cluster. If the Load Balance Strategy is configured to use PARTITION_BY_ATTRIBUTE, the value " +
    +            "returned by this method is the name of the FlowFile Attribute that will be used to determine which node in the cluster should receive a given FlowFile. If the Load Balance Strategy is " +
    +            "unset or is set to any other value, the Partitioning Attribute has no effect.")
    +    public String getPartitioningAttribute() {
    +        return partitioningAttribute;
    +    }
    +
    +    public void setPartitioningAttribute(final String partitioningAttribute) {
    +        this.partitioningAttribute = partitioningAttribute;
    +    }
    +
    +    @ApiModelProperty("Whether or not compression should be used when transferring FlowFiles between nodes")
    --- End diff --
    
    Is there a list of allowable values for the types of compression?


---

[GitHub] nifi-registry issue #136: NIFIREG-194: Updated VersionedConnection to suppor...

Posted by markap14 <gi...@git.apache.org>.
Github user markap14 commented on the issue:

    https://github.com/apache/nifi-registry/pull/136
  
    @bbende good catch. Yes, there should be allowable values added there. Just pushed another commit to address.


---